From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Douglas Anderson <dianders@chromium.org>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Bhuvanesh Surachari <Bhuvanesh_Surachari@mentor.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Flavio Suligoi <f.suligoi@asem.it>, Ray Chi <raychi@google.com>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1] usb: phy: add usb phy notify port status API
Date: Fri, 21 Apr 2023 11:19:40 +0000 [thread overview]
Message-ID: <eecf54cdc06a4e3690e2cad62a8d4596@realtek.com> (raw)
In-Reply-To: <ZEJux2KTnGw-WE1A@kroah.com>
> > > We can not add callbacks in the kernel that are not actually used,
> > > otherwise they will just be instantly removed.
> > >
> > > Please submit any drivers that need this change at the same time so
> > > that we can verify that the callback is actually correct and needed,
> > > otherwise we can not take this change.
> > >
> >
> > In this stage, we usb phy driver is not at linux upstream.
>
> Then obviously we can not take this change (nor would you want us to.)
I will prepare a complete driver for review.
> > For the android GKI, we have to add this callback to upstream or use the
> vendor hook of android.
> > I will plan to upstream the realtek usb phy driver.
>
> As you already have this driver, why not send it to us now?
>
Now the driver doesn't match the coding style.
After I refactor it, I will send this driver upstream.
Thanks,
Stanley
next prev parent reply other threads:[~2023-04-21 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 8:03 [PATCH v1] usb: phy: add usb phy notify port status API Stanley Chang
2023-04-21 8:19 ` Greg Kroah-Hartman
2023-04-21 8:32 ` Stanley Chang[昌育德]
2023-04-21 11:08 ` Greg Kroah-Hartman
2023-04-21 11:19 ` Stanley Chang[昌育德] [this message]
2023-04-21 8:21 ` Greg Kroah-Hartman
2023-04-21 8:40 ` Stanley Chang[昌育德]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eecf54cdc06a4e3690e2cad62a8d4596@realtek.com \
--to=stanley_chang@realtek.com \
--cc=Bhuvanesh_Surachari@mentor.com \
--cc=dianders@chromium.org \
--cc=f.suligoi@asem.it \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mathias.nyman@linux.intel.com \
--cc=raychi@google.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.