From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:240b:b0:1be9:327d:8ee3 with SMTP id v11csp1256926njc; Fri, 14 Feb 2025 04:23:16 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCU+Vqmke19lMIftuTf5hIBYkyiCPYDbwu+RK76+SvGdvzYmNS0P8blXjAIJvSVpAnK4+U2AI96epAAIQQ==@linaro.org X-Google-Smtp-Source: AGHT+IGZFU0rho8qC8hdK42AP0Yjgt7NYtPk5wcTe9m5uSp3ldVRTFWQUHGcsx3cs1foZ1AJalzJ X-Received: by 2002:a05:6214:c86:b0:6e4:4288:61a3 with SMTP id 6a1803df08f44-6e46ed83425mr188476966d6.18.1739535795824; Fri, 14 Feb 2025 04:23:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739535795; cv=none; d=google.com; s=arc-20240605; b=Tu5hO5530y4ANX4sNkf3KIzNSuWy9wggAJsnMM3AH4fMt7m1xyj+t7AtBMH2z1L58J C0lBqdH2JCfd0ivPCMFqfyNa5kO1e6sAdWDF+IG3AbZB0bgbbgYQaG3DGzCE8l/uLs7d A/iuiIQ81Booym0Cec5xdYx06tp3SWTmzb42l1FZe//oRCO99ayowtKAijQ1z2SQngq3 GR3VaHUC1+KIy8NCn3H84TD6FuttQDWiXcSJqBTNzVMGQSkcGc0OKQr7lzYZbgniDWWK vVHekgqmG/1JUFQ9Ecij7OVaAAnkHZzUK1JS8f2W9HHv0cKyrUIMtjeww1qMWC+zzI3E +wUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=nLKsqGE/1IcijdeTlYJxozj2UMrtOjxKXaQ53M4yRvY=; fh=6rrE52cgrYC9rXTqUznJzNUw28CrRy1ExPnK9AwMPYQ=; b=ifwaT26BiIa2/CG3N36pfXAIOFnEGSrcMoTBDD3ljoNnaDQU4DB2NIFDhZnQQQ/UQ6 m944OnE6IZUoFMY6JQ6WAmEFD3eSj9jgAwnvW14JMyuWBEwMUwZyYfKTJDL2NOAP9Xt5 z7r7+zwGisYYDbWSdLvcn30Sfd68zA2qWmTbxo2V0rbaJMsRHNWPUYo9ximeekACdBDo cxQIPXNWuhgKow8RQXj41TcU49cr3KJkiGs0fhPn9TsyrvynAYg2vaiHKgxOB4qfBwf0 aTcm55MLCSiIjzpG/jzUa0ImL6rV3/PaCJsMKBWGKHJG+8Mb7kP5caMF7zc56x6TTh8/ xt8A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=NeA4xyBE; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6e65d7431b1si34160156d6.165.2025.02.14.04.23.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Feb 2025 04:23:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=NeA4xyBE; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tiuiW-00010l-Rk; Fri, 14 Feb 2025 07:22:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tiuiU-00010N-Kd; Fri, 14 Feb 2025 07:22:46 -0500 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tiuiS-0003HH-P2; Fri, 14 Feb 2025 07:22:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1739535765; x=1771071765; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nLKsqGE/1IcijdeTlYJxozj2UMrtOjxKXaQ53M4yRvY=; b=NeA4xyBEa9uK8uLwCz+X7/No4gq04ae4fBtkZpW0QlAJ9G8CpeH+FhhU SMOIjeWjUHoHnUhjcVWdUKBrSq4r/aOPX6kfwvRJKj99YPiv+ZJ2tpA5O gCYwrO+mzHswyb8+C6GwZ7tDBMSL1QY6nVhp6kisA1AVkTMIJhcwIj1+w o=; X-IronPort-AV: E=Sophos;i="6.13,285,1732579200"; d="scan'208";a="462547518" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.2]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2025 12:22:40 +0000 Received: from EX19MTAUWB001.ant.amazon.com [10.0.7.35:43970] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.28.176:2525] with esmtp (Farcaster) id 189c9969-2a3d-49db-a012-bff917a0d461; Fri, 14 Feb 2025 12:22:38 +0000 (UTC) X-Farcaster-Flow-ID: 189c9969-2a3d-49db-a012-bff917a0d461 Received: from EX19D020UWC004.ant.amazon.com (10.13.138.149) by EX19MTAUWB001.ant.amazon.com (10.250.64.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.39; Fri, 14 Feb 2025 12:22:38 +0000 Received: from [0.0.0.0] (10.253.83.51) by EX19D020UWC004.ant.amazon.com (10.13.138.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.39; Fri, 14 Feb 2025 12:22:35 +0000 Message-ID: Date: Fri, 14 Feb 2025 13:22:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/23] hw/uefi: add var-service-core.c To: Gerd Hoffmann CC: , Eric Blake , Peter Maydell , Paolo Bonzini , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Thomas Huth , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , , Michael Roth , Markus Armbruster , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Ard Biesheuvel References: <73fe41f7-dff0-4506-8769-1997323c0a76@amazon.com> <4bwjwcs2k4hbrj6mokc57a5dy57jjssfxnvd4qm5257dgnid3x@yqdx7e47o2mf> <2c06a98c-f286-4632-a352-8b47dc4cc43c@amazon.com> <2vgc4scgezmb3med6dypykcym7te7gzlx7wp3vm5ehtfmxj3xr@kswpu35wt5ns> <342a1bd9-52e9-4a6d-8a2a-63d2b478d896@amazon.com> <5whdvrcqkpted5wl53yo5qbq2g4bf4j57vrzvbsebho56xfz4w@mjpktoiarmto> Content-Language: en-US From: Alexander Graf In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.253.83.51] X-ClientProxiedBy: EX19D032UWA001.ant.amazon.com (10.13.139.62) To EX19D020UWC004.ant.amazon.com (10.13.138.149) Received-SPF: pass client-ip=52.95.48.154; envelope-from=prvs=133e246af=graf@amazon.de; helo=smtp-fw-6001.amazon.com X-Spam_score_int: -59 X-Spam_score: -6.0 X-Spam_bar: ------ X-Spam_report: (-6.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.732, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: TSWdMcjBn9nU On 14.02.25 12:16, Gerd Hoffmann wrote: > On Fri, Feb 14, 2025 at 10:51:17AM +0100, Alexander Graf wrote: > >> I also like to have dedicated register spaces per component. So even if you >> choose to make it a hard split, I think we're better off with 4k at >> 0xfef10000 for control and 64k at 0xfef20000 for the buffer for example. > Well, if we go for PIO transfer mode instead of device memory we don't > need map the buffer any more. > > The control registers for the x86 variant are in io address space right > now (0x520, next to fw_cfg). We could place them in a mmio page @ > 0xfef10000 instead. Any preference, and if so, why? I did the same mistake in my version and use PIO for x86 but MMIO for ARM. In hindsight, I think the same mechanism for both would have simplified things a lot: You get better testing coverage of the exact same code path. If you split between PIO and MMIO, you always have issues that only pop up in one of the implementations. It complexifies your test matrix for little gain. Since you need an MMIO avenue anyway, you may as well always use that. This is not a high performance interface where the exit latency difference between PIO and MMIO really matters. Alex