Re: [PATCH iproute2-next 1/2] ip/tunnel: Be consistent when printing tunnel collect metadata

[Serhey Popovych <serhe.popovych@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1074 bytes --]

Jiri Benc wrote:
> On Mon, 22 Jan 2018 18:46:53 +0200, Serhey Popovych wrote:
>> +	if (tb[IFLA_GRE_COLLECT_METADATA]) {
>> +		print_bool(PRINT_ANY, "collect_metadata", "external", true);
>> +		return;
>> +	}
> 
> Nacked-by: Jiri Benc <jbenc@redhat.com>
> 
> Don't ever use "collect_metadata" for anything visible to the user.
> 
> collect_metadata is a *horrible* name. It describes the internal
> implementation of the lwtunneling in the kernel and provides zero
> explanation to the user about what's that feature good for.
> 
> The netlink attribute should have never had such name but it's uAPI and
> we have to live with it. But there's no reason to expose this to the
> user.
> 
> Stick with the "external" name. It explains what it is about: instead of
> the traffic being controlled by the tunnel internal logic (or tunnel
> control plane, if you want), an external logic needs to be attached to
> the tunnel in order for the tunneling to work.

Thanks! That's probably what I expect to hear. Will prepare v2 shortly.

> 
>  Jiri
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]