From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/3] drm/i915: Return immediately if trylock fails for direct-reclaim Date: Fri, 9 Nov 2018 07:30:34 +0000 Message-ID: References: <20181108081740.25615-1-chris@chris-wilson.co.uk> <20181108081740.25615-2-chris@chris-wilson.co.uk> <892ae58f-33ed-b468-fe7c-bd655f8567d4@linux.intel.com> <154169568572.30559.8677186074374608822@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0A166E751 for ; Fri, 9 Nov 2018 07:30:36 +0000 (UTC) In-Reply-To: <154169568572.30559.8677186074374608822@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA4LzExLzIwMTggMTY6NDgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTExLTA4IDE2OjIzOjA4KQo+Pgo+PiBPbiAwOC8xMS8yMDE4IDA4OjE3 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBJZ25vcmUgdHJ5aW5nIHRvIHNocmluayBmcm9tIGk5 MTUgaWYgd2UgZmFpbCB0byBhY3F1aXJlIHRoZSBzdHJ1Y3RfbXV0ZXgKPj4+IGluIHRoZSBzaHJp bmtlciB3aGlsZSBwZXJmb3JtaW5nIGRpcmVjdC1yZWNsYWltLiBUaGUgdHJhZGUtb2ZmIGJlaW5n Cj4+PiAobXVjaCkgbG93ZXIgbGF0ZW5jeSBmb3Igbm9uLWk5MTUgY2xpZW50cyBhdCBhbiBpbmNy ZWFzZWQgcmlzayBvZiBiZWluZwo+Pj4gdW5hYmxlIHRvIG9idGFpbiBhIHBhZ2UgZnJvbSBkaXJl Y3QtcmVjbGFpbSB3aXRob3V0IGhpdHRpbmcgdGhlCj4+PiBvb20tbm90aWZpZXIuIFRoZSBwcm92 aXNvIGJlaW5nIHRoYXQgd2Ugc3RpbGwga2VlcCB0cnlpbmcgdG8gaGFyZAo+Pj4gb2J0YWluIHRo ZSBsb2NrIGZvciBvb20gc28gdGhhdCB3ZSBjYW4gcmVhcCB1bmRlciBoZWF2eSBtZW1vcnkgcHJl c3N1cmUuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13 aWxzb24uY28udWs+Cj4+PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVs LmNvbT4KPj4+IC0tLQo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc2hyaW5r ZXIuYyB8IDI0ICsrKysrKysrKysrLS0tLS0tLS0tLS0tLQo+Pj4gICAgMSBmaWxlIGNoYW5nZWQs IDExIGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zaHJpbmtlci5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fc2hyaW5rZXIuYwo+Pj4gaW5kZXggZWE5MGQzYTBkNTExLi5kNDYxZjQ1 OGY0YWYgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zaHJp bmtlci5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zaHJpbmtlci5j Cj4+PiBAQCAtMzYsNyArMzYsOSBAQAo+Pj4gICAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4+PiAg ICAjaW5jbHVkZSAiaTkxNV90cmFjZS5oIgo+Pj4gICAgCj4+PiAtc3RhdGljIGJvb2wgc2hyaW5r ZXJfbG9jayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgYm9vbCAqdW5sb2NrKQo+Pj4g K3N0YXRpYyBib29sIHNocmlua2VyX2xvY2soc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUs Cj4+PiArICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxhZ3MsCj4+PiArICAg ICAgICAgICAgICAgICAgICAgICBib29sICp1bmxvY2spCj4+PiAgICB7Cj4+PiAgICAgICAgc3dp dGNoIChtdXRleF90cnlsb2NrX3JlY3Vyc2l2ZSgmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCkpIHsK Pj4+ICAgICAgICBjYXNlIE1VVEVYX1RSWUxPQ0tfUkVDVVJTSVZFOgo+Pj4gQEAgLTQ1LDE1ICs0 NywxMSBAQCBzdGF0aWMgYm9vbCBzaHJpbmtlcl9sb2NrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICppOTE1LCBib29sICp1bmxvY2spCj4+PiAgICAKPj4+ICAgICAgICBjYXNlIE1VVEVYX1RSWUxP Q0tfRkFJTEVEOgo+Pj4gICAgICAgICAgICAgICAgKnVubG9jayA9IGZhbHNlOwo+Pj4gLSAgICAg ICAgICAgICBwcmVlbXB0X2Rpc2FibGUoKTsKPj4+IC0gICAgICAgICAgICAgZG8gewo+Pj4gLSAg ICAgICAgICAgICAgICAgICAgIGNwdV9yZWxheCgpOwo+Pj4gLSAgICAgICAgICAgICAgICAgICAg IGlmIChtdXRleF90cnlsb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4KSkgewo+Pj4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKnVubG9jayA9IHRydWU7Cj4+PiAtICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBicmVhazsKPj4+IC0gICAgICAgICAgICAgICAgICAgICB9Cj4+PiAt ICAgICAgICAgICAgIH0gd2hpbGUgKCFuZWVkX3Jlc2NoZWQoKSk7Cj4+PiAtICAgICAgICAgICAg IHByZWVtcHRfZW5hYmxlKCk7Cj4+PiArICAgICAgICAgICAgIGlmIChmbGFncyAmIEk5MTVfU0hS SU5LX0FDVElWRSkgewo+Pgo+PiBTbyB1bnRpbCBJOTE1X1NIUklOS19BQ1RJVkUsIHdoaWNoIGlz IHRoZSBsYXN0IGRpdGNoIGF0dGVtcHQgdG8gc2hyaW5rCj4+IGluIHRoZSBub3JtYWwgY2FzZSAo ZGlyZWN0IHJlY2xhaW0/KSBvciBvb20sIHdlIGJhaWwgb3V0IG9uIHRoZSBmaXJzdAo+PiBzaWdu IG9mIHN0cnVjdCBtdXRleCBjb250ZW50aW9uLiBEb2Vzbid0IHRoaXMgbWFrZSBvdXIgc2hyaW5r ZXIgbXVjaAo+PiBsZXNzIGVmZmVjdGl2ZSBhdCBydW50aW1lIGFuZCB3aHkgaXMgdGhhdCBPSz8K PiAKPiBBcyBJIHNhaWQsIGl0J3MgYSB0cmFkZW9mZiBiZXR3ZWVuIGJsb2NraW5nIG90aGVycyBm b3IgX3NldmVyYWxfCj4gX3NlY29uZHNfIGFuZCBtYWtpbmcgbm8gcHJvZ3Jlc3MgYW5kIHJldHVy bmluZyBpbW1lZGlhdGVseSBhbmQgbWFraW5nIG5vCj4gcHJvZ3Jlc3MuIE15IGFyZ3VtZW50IGlz IGFsb25nIHRoZSBsaW5lcyBvZiBpZiBkaXJlY3QtcmVjbGFpbSBpcyBydW5uaW5nCj4gaW4gYW5v dGhlciBwcm9jZXNzIGFuZCBzb21ldGhpbmcgZWxzZSBpcyBlbmdhZ2VkIGluIHRoZSBkcml2ZXIg aG9wZWZ1bGx5Cj4gdGhlIGRyaXZlciB3aWxsIGJlIGNsZWFuaW5nIHVwIGFzIGl0IGdvZXMgYWxv bmcgb3IgZWxzZSB3aGF0IHJlbWFpbnMgaXMKPiBhY3RpdmUgYW5kIHdvbid0IGJlIHJlYXBlZCBh bnl3YXkuIElmIGRpcmVjdCByZWNsYWltIGlzIGZhaWxpbmcsIHRoZQo+IGRlbGF5IGJlZm9yZSB0 cnlpbmcgdGhlIG9vbSBwYXRoIGlzIGluc2lnbmlmaWNhbnQuCgpXaGF0IHdhcyB0aGUgcmF0aW9u YWxlIGJlaGluZCBidXN5IGxvb3BpbmcgdGhlcmUgYnR3PyBDb21wYXJlZCB0byAKcGVyaGFwcyBh biBhbHRlcm5hdGl2ZSBvZiBtaWNyby1zbGVlcHMgYW5kIHRyeWluZyBhIGZldyB0aW1lcz8gSSBr bm93IGl0IAp3b3VsZCBiZSBvcHBvc2l0ZSBmcm9tIHdoYXQgdGhpcyBwYXRjaCBpcyB0cnlpbmcg dG8gYWNoaWV2ZSwgSSBKdXN0IApkb24ndCBoYWQgYSBnb29kIGp1ZGdtZW50IG9uIHdoYXQgbWFr ZXMgbW9zdCBzZW5zZSBmb3IgdGhlIHNocmlua2VyLiBJcyAKaXQgYmV0dGVyIHRvIHBlcmhhcHMg dHJ5IGEgbGl0dGxlIGJpdCBoYXJkZXIgaW5zdGVhZCBvZiBnaXZpbmcgdXAgCmltbWVkaWF0ZWx5 LCBidXQgdHJ5IGEgbGl0dGxlIGJpdCBoYXJkZXIgaW4gYSBzb2Z0ZXIgd2F5PyBPciB0aGF0IGVu ZHMgCnVwIGJsb2NraW5nIHRoZSBjYWxsZXJzIGFuZCBoYXMgdGhlIHNhbWUgZWZmZWN0IG9mIG1h a2luZyBubyBwcm9ncmVzcz8KCj4+IE9yIGluIG90aGVyIHdvcmRzLCBmb3Igd2hhdCB1c2UgY2Fz ZXMsIHRlc3RzIG9yIGJlbmNobWFyayB3YXMgdGhlCj4+IGV4aXN0aW5nIGFwcHJvYWNoIG9mIGJ1 c3kgbG9vcGluZyBhIHByb2JsZW0/Cj4gCj4gRG8gc29tZXRoaW5nIGxpa2UgJ2ZpbmQgLyAtZXhl YyBjYXQnIHdoaWxlIHJ1bm5pbmcgaTkxNSBhbmQgc2VlIGhvdyBsb25nCj4geW91IGhhdmUgdG8g d2FpdCBmb3IgYSBraHVuZ3Rhc2tkIDp8CgpJIGNvdWxkbid0IHJlcHJvZHVjZSBhbnl0aGluZyBz dHJhbmdlIHdpdGggdGhpcy4gQXNzdW1pbmcgeW91IG1lYW50IApzb21ldGhpbmcgbGlrZSAtZXhl YyBjYXQgeyB9IFw7ID5kZXYvbnVsbC4KCkVpdGhlciBjYXNlIEkgdGhpbmsgZXhwbGFuYXRpb25z IGxpa2UgdGhpcyBzaG91bGQgZ28gaW50byB0aGUgY29tbWl0IAptZXNzYWdlLgoKPiBnZW1fc3lz bGF0ZW5jeSByZXBvcnRzIG1heCBsYXRlbmNpZXMgb2Ygb3ZlciA2MDBzLCBhbmQgSSdtIHN1cmUg aXQncwo+IHByZXR0eSBtdWNoIHVuYm91bmRlZC4gSXQncyBiYWQgZW5vdWdoIHRoYXQgSSBleHBl Y3Qgd2UgYXJlIHRoZSBjYXVzZSBvZgo+IHNpZ25pZmljYW50IGhpdGNoaW5nIChtYWlubHkgaW4g b3RoZXIgdGFza3MpIG9uIHRoZSBkZXNrdG9wIHJ1bm5pbmcgYXQKPiBtZW1vcnkgY2FwYWNpdHku CgpSdW5uaW5nIGdlbV9zeXNsYXRlbmN5IGluIHBhcmFsbGVsIHRvIHRoZSBmaW5kLCBvciBnZW1f c3lzbGF0ZW5jeSAtYiBpbiAKcGFyYWxsZWwgb3Igbm90IGRpZCBub3QgZG8gYW55dGhpbmcuCgpU aGVuIEkgdHJpZXMgZ2VtX3NocmluayBidXQgdGhhdCBkb2Vzbid0IHNlZW0gdG8gYmUgbWFraW5n IGFueSBwcm9ncmVzcyAKd2l0aCBvciB3aXRob3V0IHRoZSBwYXRjaC4gQnV0IGl0J3Mgbm90IGV2 ZW4gaGl0dGluZyB0aGUgaTkxNSBoYXJkLCBidXQgCnBlcmhhcHMgSSBuZWVkIHRvIHR1cm4gb2Zm IGxvY2tkZXAuLiBXaGljaCB3b3VsZCBiZSBhIGJ1bW1lciBzaW5jZSBJIAp3YW50ZWQgdG8gaGF2 ZSBhIGxvY2tkZXAgdG8gY2hlY2sgdGhlIG5leHQgYml0Li4KCj4+PiArICAgICAgICAgICAgICAg ICAgICAgbXV0ZXhfbG9ja19uZXN0ZWQoJmk5MTUtPmRybS5zdHJ1Y3RfbXV0ZXgsCj4+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSTkxNV9NTV9TSFJJTktFUik7Cj4+ Cj4+IF9uZXN0ZWQgaXMgbmVlZGVkIHNpbmNlIGFiYW5kb25pbmcgdHJ5bG9jayB3b3VsZCBvdGhl cndpc2UgY2F1c2UgbG9ja2RlcAo+PiBpc3N1ZXM/IEJ1dCBpcyBpdCByZWFsbHkgc2FmZT8gSSBk b24ndCBrbm93Li4gaG93IGNhbiBpdCBiZT8gSXQgaXMKPj4gZ3VhcmFudGVlZCB0byBiZSBhIGRp ZmZlcmVudCBwcm9jZXNzIGhlcmUgb3RoZXJ3aXNlIHRoZSByZXN1bHQgd291bGRuJ3QKPj4gYmUg TVVURVhfVFJZTE9DS19GQUlMRUQuCj4gCj4gVGhlIGVhc3kgb3B0aW9uIHdhcyB0byBvbmx5IGZv cmNlIHRoZSBtdXRleF9sb2NrIGZvciBrc3dhcGQuIEhvd2V2ZXIsCj4gbm90aW5nIHRoYXQgd2Ug ZG8gbmVlZCB0byBmb3JjaWJseSBzaHJpbmsgYmVmb3JlIG9vbSwgSSBvcHRlZCBmb3IgdGhlCj4g bW9yZSBpbmNsdXNpdmUgYXR0ZW1wdCB0byB0YWtlIGl0IGluIGJvdGguIEZvciB0aGUgb29tIGFw cHJvYWNoLCBteSBvbmx5Cj4gaGFuZHdhdmluZyBpcyB3ZSBzaG91bGRuJ3QgYmUgbmVzdGVkIHVu ZGVyIG9vbSBzZXJpYWxpc2F0aW9uIGFuZCBzbwo+IGF2b2lkIGFuIEFCQkEgZGVhZGxvY2suIEl0 J3Mgc3Vydml2ZWQgc29tZSBvb20gYWJ1c2UsIGJ1dCB0aGUgbWFjaGluZQo+IHN0aWxsIGJlY29t ZXMgdW5yZXNwb25zaXZlIChidXQgcGluZ2FibGUpIGV2ZW50dWFsbHkgKGFzIGl0IGRvZXMgYmVm b3JlCj4gdGhlIHBhdGNoKS4KCi4uLndoaWNoIEkgY29tcGxldGVseSBkaWQgbm90IHVuZGVyc3Rh bmQhIDooCgpXaGVuIHlvdSBzYXkga3N3YXBkIC0gdGhhdCBtZWFucyBtdXRleC0+b3duZXIgIT0g Y3VycmVudCBpbiB0aGUgc2hyaW5rZXIgCmFuZCBvdGhlcndpc2UgaXQgaXMgZGlyZWN0IHJlY2xh aW0/CgpJZiB0cnVlLCBob3cgaXMgdGhlIG5lc3RlZCBhbm5vdGF0aW9uIGNvcnJlY3QgZm9yIHRo ZSBrc3dhcGQgY2FzZT8KCj4gCj4+IEFsc28sIEk5MTVfTU1fU0hSSU5LRVIgaXMgc28gZmFyIG9u bHkgZG9jdW1lbnRlZCB0byBhcHBseSB0byBvYmotPm1tLmxvY2suCj4gCj4gSXQgc3VpdHMgdmVy eSBuaWNlbHkgYXMgaXQgYmVpbmcgYXBwbGllZCBmb3IgdGhlIHNhbWUgcHVycG9zZS4KCk1heWJl IHJlbmFtZSBvciBhdCBsZWFzdCB1cGRhdGUgdGhlIGNvbW1lbnQgd2hlcmUgdGhleSBhcmUgZGVm aW5lZD8KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==