From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: fix warnings in PATH_INFO code and add export_ok/strict_export
Date: Mon, 18 Sep 2006 00:45:44 +0200 [thread overview]
Message-ID: <eekj5b$rlc$1@sea.gmane.org> (raw)
In-Reply-To: 7v4pv62lni.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
> Matthias Lederhofer <matled@gmx.net> writes:
>
>> This patch replaces the other two warning fixes by Jakub and me. I've
>> put the whole thing in a sub-routine to keep the indentation level
>> low.
>
> Looks much cleaner with this extra sub.
>
> This does not seem have the "colon as a cue that the URL is also
> talking about a branch", Jakub's summary of the discussion
> between you two on #git channel. I think that proposal makes
> sense as well.
Well, that is because this patch _predates_ the discussion
(and proposal/conclusions).
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-09-17 22:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-16 19:27 [PATCH] gitweb: export-ok option Matthias Lederhofer
2006-09-16 19:40 ` Jakub Narebski
2006-09-16 20:33 ` Matthias Lederhofer
2006-09-16 20:37 ` Junio C Hamano
2006-09-16 19:44 ` Jakub Narebski
2006-09-16 21:43 ` [PATCH] gitweb: option 'strict export' Matthias Lederhofer
2006-09-16 22:30 ` [PATCH/current master] gitweb: do not use 'No such directory' error message Matthias Lederhofer
2006-09-16 22:31 ` [PATCH] gitweb: export options Matthias Lederhofer
2006-09-17 8:53 ` Junio C Hamano
2006-09-17 9:07 ` Matthias Lederhofer
2006-09-17 10:34 ` Junio C Hamano
2006-09-17 13:29 ` [PATCH] gitweb: fix warnings in PATH_INFO code and add export_ok/strict_export Matthias Lederhofer
2006-09-17 22:06 ` Junio C Hamano
2006-09-17 22:45 ` Jakub Narebski [this message]
2006-09-17 23:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eekj5b$rlc$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.