Re: autoip address set/reset loop

[Geoffrey Van Landeghem <geoffrey.vl@gmail.com>]

Hi Daniel,

I did watch your commit earlier, but because you say "It's propably a safe bet to say NULL is never a valid GW, so let's filter it out for all callers", that for me seems to be guessing it could have been a bug and it just didn't seem to fix much or anything you saw at runtime. It would have been better to see what runtime issues you fixed with it, because there is nothing for me to hold.

Regarding assigning the invalid /non-routable 0.0.0.0 gateway IP: it basically means there is none, so I don't see the issue. See https://unix.stackexchange.com/questions/94018/what-is-the-meaning-of-0-0-0-0-as-a-gateway#:~:text=on%20this%20post.-,0.0.,there%20is%20no%20intermediate%20hop.

On 23/11/2022 18:36, Daniel Wagner wrote:
>
>
> On 23.11.22 18:12, Geoffrey Van Landeghem wrote:
>> Subject: Re: autoip address set/reset loop
>>
>>
>> Hi Daniel,
>>
>>
>> Well, as said it autoip (APIPA) was not working because of this because it seems to not have assigned any gateway at this stage. This get's assigned in the __connman_connection_gateway_add() function which is called after this DBG(...):
>
> My patch fixes a bug but introduced a regression. If you want to fix the regression you need to figure out how to address the original problem: cb05780d86c3 ("ipconfig: Don't add invalid gateway routes")
>
> Just reverting is not okay.