All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Tony Huang 黃懷厚" <tony.huang@sunplus.com>,
	"Tony Huang" <tonyhuang.sunplus@gmail.com>,
	"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"lhjeff911@gmail.com" <lhjeff911@gmail.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Cc: "Wells Lu 呂芳騰" <wells.lu@sunplus.com>, "Lh Kuo 郭力豪" <lh.Kuo@sunplus.com>
Subject: Re: [PATCH v4 2/2] mmc: Add mmc driver for Sunplus SP7021
Date: Mon, 21 Mar 2022 10:01:43 +0100	[thread overview]
Message-ID: <ef173db6-4635-8a77-c3e3-d96b0c2fa7a3@kernel.org> (raw)
In-Reply-To: <c6ecbe40dc234454b41bcbc0bf073084@sphcmbx02.sunplus.com.tw>

On 21/03/2022 05:55, Tony Huang 黃懷厚 wrote:
> Dear Krzysztof:
>>
>>> +	int dma_int_threshold;
>>> +	struct sg_mapping_iter sg_miter; /* for pio mode to access sglist */
>>> +	int dma_use_int; /* should raise irq when dma done */
>>> +	struct spmmc_tuning_info emmc_tuning_info;
>>> +	struct spsdc_tuning_info sd_tuning_info;
>>> +	int restore_4bit_sdio_bus;
>>> +	const struct spmmc_compatible *dev_comp; };
>>> +
>>> +struct spsdc_host {
>>
>> Where is this used?
>>
> 
> struct spmmc_host{} for emmc.			
> struct spsdc_host{} for SD card.			
> The register base address and offset address of emmc and sd cards are different.			
> eMMC and sdcard are their respective hardware settings.


This is a weird answer. I asked where is this used (struct spsdc_host).
There is no single reference of this type. Your answer does not cover it
all. I know that eMMC and SD are different. That was not the question.
The question is: point me to the code which uses this type.


Best regards,
Krzysztof

  reply	other threads:[~2022-03-21  9:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-19  1:50 [PATCH v4 0/2] Add mmc driver for Sunplus SP7021 SOC Tony Huang
2022-03-19  1:50 ` [PATCH v4 1/2] dt-binding: mmc: Add mmc yaml file for Sunplus SP7021 Tony Huang
2022-03-20 11:41   ` Krzysztof Kozlowski
2022-03-21  2:35     ` Tony Huang 黃懷厚
2022-03-21  8:59       ` Krzysztof Kozlowski
2022-03-19  1:50 ` [PATCH v4 2/2] mmc: Add mmc driver " Tony Huang
2022-03-20 11:54   ` Krzysztof Kozlowski
2022-03-21  4:55     ` Tony Huang 黃懷厚
2022-03-21  9:01       ` Krzysztof Kozlowski [this message]
2022-03-21  9:12         ` Tony Huang 黃懷厚
2022-03-21  7:40     ` Tony Huang 黃懷厚

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef173db6-4635-8a77-c3e3-d96b0c2fa7a3@kernel.org \
    --to=krzk@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lh.Kuo@sunplus.com \
    --cc=lhjeff911@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=tony.huang@sunplus.com \
    --cc=tonyhuang.sunplus@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wells.lu@sunplus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.