RE: Funny log entries for rtw88_8821ce

[Pkshih <pkshih@realtek.com>]

> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Thursday, February 10, 2022 10:27 PM
> To: Pkshih <pkshih@realtek.com>
> Cc: Larry.Finger@lwfinger.net; linux-wireless@vger.kernel.org
> Subject: Re: Funny log entries for rtw88_8821ce
> 
> Pkshih <pkshih@realtek.com> writes:
> 
> > Then, I have a question about the message of setting SAR:
> > 	rtw_info(rtwdev, "On freq %u to %u, set SAR %d in 1/%lu dBm\n"
> >
> > When a user sets SAR via iw, this message can reflect the action performed
> > by driver. Is this rtw_info acceptable?
> 
> In general the preference for user space commands is not to print
> anything to the log when debug messages are disabled, but of course
> there can be exceptions if the reasons are good. Why do you want to
> print this always? What benefit does it bring for the user?
> 

Understand. My original thinking still focus on debug purpose.

Because the SAR doesn't have a 'get' method to check status, and it affects
TX power but a user can't be aware that clearly. If someone told me his
laptop has low wifi performance, this message can be a good clue to address
the problem.

Fortunately, I still can use debugfs to debug this case, so I will change
this message to debug level.

--
Ping-Ke