From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C2D6236AF9; Mon, 18 Mar 2024 11:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710761133; cv=none; b=YOiwIQHr+4Ep96zkVWd5BMgxFNb1etaIq6elhOXqQK434cS47KDNaYoRJl4KFigdXhL1gElZpOdQ2EvSKUB8m+n8+ZLdeGF9LpZpxCry1mnzOVX1W8R0IGZy3thQfCuILoMlbLY3s9BfrollXdUnc4Y9PND7z90LbTnK8OHmGUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710761133; c=relaxed/simple; bh=aC23jAhpl0yvzLg9qN8KuMrly14TJFysyuJEzIOBEaQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tEqybUf5H/4Awhs2pO8l87LpOZ8Bb6enRvwIiSZO67wEbWhvqWEZQcpRxZS2XLG933ipNBHz6/OSKCCOFDHEL079vn/swr0dWuEkn8b2qwWDVCyM9U1vnpVywOSWap/Ter6hiykgAW9L6jPNj6o9iq3FmJJsNiJHA1VmbTQESp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 268A6DA7; Mon, 18 Mar 2024 04:26:06 -0700 (PDT) Received: from [10.57.12.69] (unknown [10.57.12.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1102E3F762; Mon, 18 Mar 2024 04:25:27 -0700 (PDT) Message-ID: Date: Mon, 18 Mar 2024 11:25:28 +0000 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 09/28] arm64: RME: RTT handling Content-Language: en-GB To: Ganapatrao Kulkarni , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127112932.38045-1-steven.price@arm.com> <20230127112932.38045-10-steven.price@arm.com> <84bb27a2-0649-4ba4-8f31-baff7b3a9b3a@os.amperecomputing.com> From: Steven Price In-Reply-To: <84bb27a2-0649-4ba4-8f31-baff7b3a9b3a@os.amperecomputing.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 18/03/2024 11:01, Ganapatrao Kulkarni wrote: > > On 27-01-2023 04:59 pm, Steven Price wrote: >> The RMM owns the stage 2 page tables for a realm, and KVM must request >> that the RMM creates/destroys entries as necessary. The physical pages >> to store the page tables are delegated to the realm as required, and can >> be undelegated when no longer used. >> >> Signed-off-by: Steven Price >> --- >>   arch/arm64/include/asm/kvm_rme.h |  19 +++++ >>   arch/arm64/kvm/mmu.c             |   7 +- >>   arch/arm64/kvm/rme.c             | 139 +++++++++++++++++++++++++++++++ >>   3 files changed, 162 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/include/asm/kvm_rme.h >> b/arch/arm64/include/asm/kvm_rme.h >> index a6318af3ed11..eea5118dfa8a 100644 >> --- a/arch/arm64/include/asm/kvm_rme.h >> +++ b/arch/arm64/include/asm/kvm_rme.h >> @@ -35,5 +35,24 @@ u32 kvm_realm_ipa_limit(void); >>   int kvm_realm_enable_cap(struct kvm *kvm, struct kvm_enable_cap *cap); >>   int kvm_init_realm_vm(struct kvm *kvm); >>   void kvm_destroy_realm(struct kvm *kvm); >> +void kvm_realm_destroy_rtts(struct realm *realm, u32 ia_bits, u32 >> start_level); >> + >> +#define RME_RTT_BLOCK_LEVEL    2 >> +#define RME_RTT_MAX_LEVEL    3 >> + >> +#define RME_PAGE_SHIFT        12 >> +#define RME_PAGE_SIZE        BIT(RME_PAGE_SHIFT) > > Can we use PAGE_SIZE and PAGE_SHIFT instead of redefining? > May be we can use them to define RME_PAGE_SIZE and RME_PAGE_SHIFT. At the moment the code only supports the host page size matching the RMM's. But I want to leave open the possibility for the host size being larger than the RMM's. In this case PAGE_SHIFT/PAGE_SIZE will not equal RME_PAGE_SIZE and RME_PAGE_SHIFT. The host will have to create multiple RMM RTTs for each host page. >> +/* See ARM64_HW_PGTABLE_LEVEL_SHIFT() */ >> +#define RME_RTT_LEVEL_SHIFT(l)    \ >> +    ((RME_PAGE_SHIFT - 3) * (4 - (l)) + 3) > > Instead of defining again, can we define to > ARM64_HW_PGTABLE_LEVEL_SHIFT? Same as above - ARM64_HW_PGTABLE_LEVEL_SHIFT uses PAGE_SHIFT, but we want the same calculation using RME_PAGE_SHIFT which might be different. Thanks, Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40485C54E58 for ; Mon, 18 Mar 2024 11:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cGVxumyakPhWTFhRLL4jP8CNv73VJ7IUmZkjKmUP5Ys=; b=awg+9+LlOnBLoT 5J/KVDVLNJQ0F1pu9dksims1AFmX94s9LRfT2SbKszBNqLOs9b1jEkJHd4bEXZvvMXK+gfWsAqbop pLS4eJMaVwHRasaAQUz3lPS5bu1atCzIJeSzwy46jvEZjR9EYKrOZxdaUvpaJHFg2rjny3PVh0xBB gHiSdykjexFOMm1yszh5PsUQFjnHqK16dXZxHb7t8cxp/dl5kzQQe/fW4+TAG4J8Tees16IiMaF29 SPBhAO5WspwhlMyoyqyg7w8VRh6H0SjkcPkT09WVelHOivN75//xv6wqsUsQ7HlfgrwK3kMSJHTBD 0pGqIJmOqUSfcVMxWipw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmB7Y-00000008LqY-0mAe; Mon, 18 Mar 2024 11:25:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmB7V-00000008Lq4-0Zv7 for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2024 11:25:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 268A6DA7; Mon, 18 Mar 2024 04:26:06 -0700 (PDT) Received: from [10.57.12.69] (unknown [10.57.12.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1102E3F762; Mon, 18 Mar 2024 04:25:27 -0700 (PDT) Message-ID: Date: Mon, 18 Mar 2024 11:25:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 09/28] arm64: RME: RTT handling Content-Language: en-GB To: Ganapatrao Kulkarni , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev References: <20230127112248.136810-1-suzuki.poulose@arm.com> <20230127112932.38045-1-steven.price@arm.com> <20230127112932.38045-10-steven.price@arm.com> <84bb27a2-0649-4ba4-8f31-baff7b3a9b3a@os.amperecomputing.com> From: Steven Price In-Reply-To: <84bb27a2-0649-4ba4-8f31-baff7b3a9b3a@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_042533_332669_4368BE5E X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTgvMDMvMjAyNCAxMTowMSwgR2FuYXBhdHJhbyBLdWxrYXJuaSB3cm90ZToKPiAKPiBPbiAy Ny0wMS0yMDIzIDA0OjU5IHBtLCBTdGV2ZW4gUHJpY2Ugd3JvdGU6Cj4+IFRoZSBSTU0gb3ducyB0 aGUgc3RhZ2UgMiBwYWdlIHRhYmxlcyBmb3IgYSByZWFsbSwgYW5kIEtWTSBtdXN0IHJlcXVlc3QK Pj4gdGhhdCB0aGUgUk1NIGNyZWF0ZXMvZGVzdHJveXMgZW50cmllcyBhcyBuZWNlc3NhcnkuIFRo ZSBwaHlzaWNhbCBwYWdlcwo+PiB0byBzdG9yZSB0aGUgcGFnZSB0YWJsZXMgYXJlIGRlbGVnYXRl ZCB0byB0aGUgcmVhbG0gYXMgcmVxdWlyZWQsIGFuZCBjYW4KPj4gYmUgdW5kZWxlZ2F0ZWQgd2hl biBubyBsb25nZXIgdXNlZC4KPj4KPj4gU2lnbmVkLW9mZi1ieTogU3RldmVuIFByaWNlIDxzdGV2 ZW4ucHJpY2VAYXJtLmNvbT4KPj4gLS0tCj4+IMKgIGFyY2gvYXJtNjQvaW5jbHVkZS9hc20va3Zt X3JtZS5oIHzCoCAxOSArKysrKwo+PiDCoCBhcmNoL2FybTY0L2t2bS9tbXUuY8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCB8wqDCoCA3ICstCj4+IMKgIGFyY2gvYXJtNjQva3ZtL3JtZS5jwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIHwgMTM5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK Pj4gwqAgMyBmaWxlcyBjaGFuZ2VkLCAxNjIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkK Pj4KPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20va3ZtX3JtZS5oCj4+IGIv YXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1fcm1lLmgKPj4gaW5kZXggYTYzMThhZjNlZDExLi5l ZWE1MTE4ZGZhOGEgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20va3ZtX3Jt ZS5oCj4+ICsrKyBiL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20va3ZtX3JtZS5oCj4+IEBAIC0zNSw1 ICszNSwyNCBAQCB1MzIga3ZtX3JlYWxtX2lwYV9saW1pdCh2b2lkKTsKPj4gwqAgaW50IGt2bV9y ZWFsbV9lbmFibGVfY2FwKHN0cnVjdCBrdm0gKmt2bSwgc3RydWN0IGt2bV9lbmFibGVfY2FwICpj YXApOwo+PiDCoCBpbnQga3ZtX2luaXRfcmVhbG1fdm0oc3RydWN0IGt2bSAqa3ZtKTsKPj4gwqAg dm9pZCBrdm1fZGVzdHJveV9yZWFsbShzdHJ1Y3Qga3ZtICprdm0pOwo+PiArdm9pZCBrdm1fcmVh bG1fZGVzdHJveV9ydHRzKHN0cnVjdCByZWFsbSAqcmVhbG0sIHUzMiBpYV9iaXRzLCB1MzIKPj4g c3RhcnRfbGV2ZWwpOwo+PiArCj4+ICsjZGVmaW5lIFJNRV9SVFRfQkxPQ0tfTEVWRUzCoMKgwqAg Mgo+PiArI2RlZmluZSBSTUVfUlRUX01BWF9MRVZFTMKgwqDCoCAzCj4+ICsKPj4gKyNkZWZpbmUg Uk1FX1BBR0VfU0hJRlTCoMKgwqDCoMKgwqDCoCAxMgo+PiArI2RlZmluZSBSTUVfUEFHRV9TSVpF wqDCoMKgwqDCoMKgwqAgQklUKFJNRV9QQUdFX1NISUZUKQo+IAo+IENhbiB3ZSB1c2UgUEFHRV9T SVpFIGFuZCBQQUdFX1NISUZUIGluc3RlYWQgb2YgcmVkZWZpbmluZz8KPiBNYXkgYmUgd2UgY2Fu IHVzZSB0aGVtIHRvIGRlZmluZSBSTUVfUEFHRV9TSVpFIGFuZCBSTUVfUEFHRV9TSElGVC4KCkF0 IHRoZSBtb21lbnQgdGhlIGNvZGUgb25seSBzdXBwb3J0cyB0aGUgaG9zdCBwYWdlIHNpemUgbWF0 Y2hpbmcgdGhlClJNTSdzLiBCdXQgSSB3YW50IHRvIGxlYXZlIG9wZW4gdGhlIHBvc3NpYmlsaXR5 IGZvciB0aGUgaG9zdCBzaXplIGJlaW5nCmxhcmdlciB0aGFuIHRoZSBSTU0ncy4gSW4gdGhpcyBj YXNlIFBBR0VfU0hJRlQvUEFHRV9TSVpFIHdpbGwgbm90IGVxdWFsClJNRV9QQUdFX1NJWkUgYW5k IFJNRV9QQUdFX1NISUZULiBUaGUgaG9zdCB3aWxsIGhhdmUgdG8gY3JlYXRlIG11bHRpcGxlClJN TSBSVFRzIGZvciBlYWNoIGhvc3QgcGFnZS4KCj4+ICsvKiBTZWUgQVJNNjRfSFdfUEdUQUJMRV9M RVZFTF9TSElGVCgpICovCj4+ICsjZGVmaW5lIFJNRV9SVFRfTEVWRUxfU0hJRlQobCnCoMKgwqAg XAo+PiArwqDCoMKgICgoUk1FX1BBR0VfU0hJRlQgLSAzKSAqICg0IC0gKGwpKSArIDMpCj4gCj4g SW5zdGVhZCBvZiBkZWZpbmluZyBhZ2FpbiwgY2FuIHdlIGRlZmluZSB0bwo+IEFSTTY0X0hXX1BH VEFCTEVfTEVWRUxfU0hJRlQ/CgpTYW1lIGFzIGFib3ZlIC0gQVJNNjRfSFdfUEdUQUJMRV9MRVZF TF9TSElGVCB1c2VzIFBBR0VfU0hJRlQsIGJ1dCB3ZQp3YW50IHRoZSBzYW1lIGNhbGN1bGF0aW9u IHVzaW5nIFJNRV9QQUdFX1NISUZUIHdoaWNoIG1pZ2h0IGJlIGRpZmZlcmVudC4KClRoYW5rcywK ClN0ZXZlCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=