All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lucero Palau, Alejandro" <alejandro.lucero-palau@amd.com>
To: Arnd Bergmann <arnd@kernel.org>,
	Edward Cree <ecree.xilinx@gmail.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Dave Jiang <dave.jiang@intel.com>, Dan Williams <djbw@kernel.org>,
	Alejandro Lucero <alucerop@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Alison Schofield <alison.schofield@intel.com>,
	netdev@vger.kernel.org, linux-net-drivers@amd.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sfc: fix CONFIG_CXL_MEM dependency
Date: Mon, 21 Sep 2026 08:43:28 +0100	[thread overview]
Message-ID: <ef2f9f61-dc86-474a-82a1-ff761237a67c@amd.com> (raw)
In-Reply-To: <20260917155519.2121486-1-arnd@kernel.org>


On 17/09/2026 16:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent patch introduced a call to devm_cxl_probe_mem(), which is only
> available when CXL_MEM is enabled. If CXL_MEM is in a loadable module,
> this causes a link failure for a builtin driver:
>
> s390-linux-ld: drivers/net/ethernet/sfc/efx_cxl.o: in function `efx_cxl_init':
> efx_cxl.c:(.text+0x156): undefined reference to `devm_cxl_probe_mem'
>
> Adapt the dependency to require CXL_MEM instead of CXL_BUS, which
> we know is available when CXL_MEM is.
>
> Fixes: 0418860ef2ca ("sfc: obtain and map cxl range using devm_cxl_probe_mem")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/net/ethernet/sfc/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/Kconfig b/drivers/net/ethernet/sfc/Kconfig
> index 979f2801e2a8..e2898ec2e6e9 100644
> --- a/drivers/net/ethernet/sfc/Kconfig
> +++ b/drivers/net/ethernet/sfc/Kconfig
> @@ -68,7 +68,7 @@ config SFC_MCDI_LOGGING
>   	  a sysfs file 'mcdi_logging' under the PCI device.
>   config SFC_CXL
>   	bool "Solarflare SFC9100-family CXL support"
> -	depends on SFC && CXL_BUS >= SFC
> +	depends on SFC && CXL_MEM >= SFC
>   	default SFC
>   	help
>   	  This enables SFC CXL support if the kernel is configuring CXL for


Reviewed-by: Alejandro Lucero <alucerop@amd.com>


  reply	other threads:[~2026-09-21  7:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 15:55 [PATCH] sfc: fix CONFIG_CXL_MEM dependency Arnd Bergmann
2026-09-21  7:43 ` Lucero Palau, Alejandro [this message]
2026-09-21 23:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef2f9f61-dc86-474a-82a1-ff761237a67c@amd.com \
    --to=alejandro.lucero-palau@amd.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alison.schofield@intel.com \
    --cc=alucerop@amd.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=dave.jiang@intel.com \
    --cc=davem@davemloft.net \
    --cc=djbw@kernel.org \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@amd.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.