From: Srinivas Kandagatla <srini@kernel.org>
To: "Hongmei Xu" <hongmei.xu@oss.qualcomm.com>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Rafał Miłecki" <rafal@milecki.pl>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: nvmem: add byte-mask property for non-contiguous byte selection
Date: Tue, 17 Nov 2026 15:29:20 +0000 [thread overview]
Message-ID: <ef5c8902-2a55-4879-8deb-5109f7bd3cd2@kernel.org> (raw)
In-Reply-To: <20261117-nvmem-byte-mask-for-split-macaddr-v3-1-c02177658f66@oss.qualcomm.com>
On 11/17/26 6:04 AM, Hongmei Xu wrote:
> Add the byte-mask property to the fixed-cell binding. This allows
> selecting non-contiguous physical bytes from an NVMEM region to form
> a logical cell value.
>
> Some SoCs (e.g. Qualcomm efuse controllers) store a logical value such
> as a MAC address across non-contiguous physical bytes, with one or more
> bytes in between reserved or unused. byte-mask lets the DT describe this
> directly in the fixed-cell binding without requiring a device-specific
> provider for a common pattern.
Pl take a look at layouts, which does exactly what you are trying to do.
--srini
>
> Bit N set in byte-mask means physical byte N relative to the cell's
> base offset is included in the output; selected bytes are packed into
> the output buffer in ascending byte order. The number of set bits must
> not exceed the cell's logical size given by reg. byte-mask and bits are
> mutually exclusive. Cells using byte-mask are read-only.
>
> Signed-off-by: Hongmei Xu <hongmei.xu@oss.qualcomm.com>
> ---
> .../bindings/nvmem/layouts/fixed-cell.yaml | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/layouts/fixed-cell.yaml b/Documentation/devicetree/bindings/nvmem/layouts/fixed-cell.yaml
> index 38e3ad50ff4f..46e1101ee98a 100644
> --- a/Documentation/devicetree/bindings/nvmem/layouts/fixed-cell.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/layouts/fixed-cell.yaml
> @@ -34,6 +34,20 @@ properties:
> description:
> Size in bit within the address range specified by reg.
>
> + byte-mask:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 1
> + description: >
> + Bitmask selecting which physical bytes within the NVMEM device region
> + contribute to this cell's output. Bit N set means physical byte N
> + relative to the cell's base offset is included; selected bytes are
> + packed into the output buffer in ascending byte order. Byte positions
> + are relative to the cell's base offset and limited to a 32-byte window.
> + The highest set bit must not reference a byte beyond the device size.
> + The number of set bits must not exceed the cell's logical size given by
> + reg. Cannot be used together with bits. Cells using byte-mask are
> + read-only; write operations are not supported.
> +
> allOf:
> - if:
> properties:
> @@ -48,6 +62,13 @@ allOf:
> const: 1
> required:
> - "#nvmem-cell-cells"
> + - if:
> + required: [ byte-mask ]
> + then:
> + properties:
> + bits: false
> + description:
> + byte-mask and bits are mutually exclusive.
>
> required:
> - reg
>
next prev parent reply other threads:[~2026-11-17 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 6:04 [PATCH v3 0/2] nvmem: Add byte-mask support for non-contiguous byte selection Hongmei Xu
2026-11-17 6:04 ` [PATCH v3 1/2] dt-bindings: nvmem: add byte-mask property " Hongmei Xu
2026-11-17 6:13 ` sashiko-bot
2026-11-17 8:45 ` Hongmei Xu
2026-11-17 15:29 ` Srinivas Kandagatla [this message]
2026-11-18 3:20 ` Hongmei Xu
2026-11-17 6:04 ` [PATCH v3 2/2] nvmem: core: add byte-mask support for non-contiguous cell bytes Hongmei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef5c8902-2a55-4879-8deb-5109f7bd3cd2@kernel.org \
--to=srini@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hongmei.xu@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.