All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Andrii Sultanov <andrii.sultanov@cloud.com>,
	xen-devel@lists.xenproject.org
Cc: Christian Lindig <christian.lindig@citrix.com>,
	David Scott <dave@recoil.org>,
	Anthony PERARD <anthony.perard@vates.tech>
Subject: Re: [PATCH v1 1/1] tools/ocaml: Fix oxenstored build warning
Date: Thu, 13 Feb 2025 13:34:31 +0000	[thread overview]
Message-ID: <ef666424-3643-4938-a3da-90ef3f6c405e@citrix.com> (raw)
In-Reply-To: <58a75da8a5e593c67817632622221af2984efc6d.1739451311.git.andrii.sultanov@cloud.com>

On 13/02/2025 1:03 pm, Andrii Sultanov wrote:
> diff --git a/tools/ocaml/xenstored/process.ml b/tools/ocaml/xenstored/process.ml
> index 432d66321c..cb4efc0fb5 100644
> --- a/tools/ocaml/xenstored/process.ml
> +++ b/tools/ocaml/xenstored/process.ml
> @@ -437,7 +437,7 @@ let input_handle_error ~cons ~doms ~fct ~con ~t ~req =
>    | Quota.Limit_reached          -> reply_error "EQUOTA"
>    | Quota.Data_too_big           -> reply_error "E2BIG"
>    | Quota.Transaction_opened     -> reply_error "EQUOTA"
> -  | (Failure "int_of_string")    -> reply_error "EINVAL"
> +  | Utils.ConversionFailed s     -> reply_error (Printf.sprintf "EINVAL: Could not convert '%s' to int" s)
>    | Define.Unknown_operation     -> reply_error "ENOSYS"

Thanks for working on fixing the warning, but this needs to stay
reply_error "EINVAL".

This is the stringly-typed errno given back to the client, not an
arbitrary message to be rendered into the log.

~Andrew


      parent reply	other threads:[~2025-02-13 13:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13 13:03 [PATCH v1 0/1] Fix OCaml build warning Andrii Sultanov
2025-02-13 13:03 ` [PATCH v1 1/1] tools/ocaml: Fix oxenstored " Andrii Sultanov
2025-02-13 13:22   ` Christian Lindig
2025-02-13 13:34   ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef666424-3643-4938-a3da-90ef3f6c405e@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=andrii.sultanov@cloud.com \
    --cc=anthony.perard@vates.tech \
    --cc=christian.lindig@citrix.com \
    --cc=dave@recoil.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.