From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BC7EC77B75 for ; Wed, 24 May 2023 00:15:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D8E0D85494; Wed, 24 May 2023 02:15:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PdkUTnsl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AD57785494; Wed, 24 May 2023 02:15:00 +0200 (CEST) Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5D5208473B for ; Wed, 24 May 2023 02:14:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cfsworks@gmail.com Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1ae454844edso2218595ad.1 for ; Tue, 23 May 2023 17:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684887296; x=1687479296; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=maeC5t27CrgRVzAz7Honuw0FzLNpdnLAZpssu7DiAzE=; b=PdkUTnslf9qLVy8ie0OysvKZYSeUAjjStO9KKnnnc3RfUL30mOX6kbcrPL5OFYePJj 1aZ3I+VmMgTnvHz8idYJmuQL6ExLLr/pv8IxXdP5mZgcutUWv2aDDMLQ5M2evKhk8nRS WIZVR8p4KgqjH7VGAy88WmAg99z+iFP02vKVK/rMbBeZxvvjCnzTE4fsdexmEM7c0PRb DdiQmQL7SO6vf1OqzOE65KmtR7AOxwL2nc7SWW52TprrsUfcBsOWiBLfHPq1plQSUyLT QjCom+1Bov+3r2giq+kqGk26aoSvljidy0otVqGxT/d6yW9dWNF8gf7u8fKBW0pcmLUQ +FHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684887296; x=1687479296; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=maeC5t27CrgRVzAz7Honuw0FzLNpdnLAZpssu7DiAzE=; b=cULret9mW5WXRTrsNY8mYVHJ0hpxDG3vL6+Z/hITZX91vRLWWsG3jA6wXIsn44DzPK qh0bPQiHowj/czPiQ4Wo8RQodUf/Te5a/Vy4FQET7/cRgige39nPctiyIXZ/QsnBN9xh p9cgtAipsDk6l0KRgg/mRJ5AnY+7zXoCRnUhMaQhj10vV7L4eqJuWlpnBgT95gt6Cffp IaUgaIUk22mnK3FAvbODKNekjkuj+Gs+2ejMimlvG5DsT0RMiWQ017Vwvr/ZS7ixXSQ4 EO97PWefouZOoEtRBq4+YiWYIjeG4PrpzO3m98pPsno+TR17tesbfZR1HxuU3QU17Apw ouCw== X-Gm-Message-State: AC+VfDxm91x7hbtDnLm5fLi4wWRpHTFG28gKFQY3YkEUoa2MSwVaJfxO DDbaXTj4rXC8XStambtFXmBvHYHMbnHVRA== X-Google-Smtp-Source: ACHHUZ6SXDHXAIsYYXLUxvwzbk9sP8mSqnoe8NLAISQg1LnBJW0xQB7DV4paZokqeaciGxb9uWD85g== X-Received: by 2002:a17:903:441:b0:1af:9b8a:9c6c with SMTP id iw1-20020a170903044100b001af9b8a9c6cmr10102211plb.8.1684887296429; Tue, 23 May 2023 17:14:56 -0700 (PDT) Received: from [10.64.107.252] (static-198-54-134-172.cust.tzulo.com. [198.54.134.172]) by smtp.gmail.com with ESMTPSA id jh9-20020a170903328900b001a6f7744a27sm7373721plb.87.2023.05.23.17.14.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 17:14:56 -0700 (PDT) Message-ID: Date: Tue, 23 May 2023 18:14:55 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC PATCH v1 2/3] spi: sunxi: Add support for R329/D1/R528/T113 SPI controller Content-Language: en-US To: u-boot@lists.denx.de References: <20230519134010.3102343-1-bigunclemax@gmail.com> <20230519134010.3102343-3-bigunclemax@gmail.com> From: Sam Edwards In-Reply-To: <20230519134010.3102343-3-bigunclemax@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Maxim, By any chance do you happen to know when in sunxi history the SPI controller grew QuadSPI/DualSPI support? It'd probably be feature creep to have in this patch series, but since they don't look too hard to implement, I might be interested in taking a stab at supporting them. On 5/19/23 07:40, Maxim Kiselev wrote: > These SoCs have two SPI controllers that are quite similar to the SPI > on previous Allwinner SoCs. The main difference is that new SoCs > don't have a clock divider (SPI_CCR register) inside SPI IP. > > Instead SPI sample mode should be configured depending on the input clock. > > For now SPI input clock source selection is not supported by this driver, > and only HOSC@24MHz can be used as input clock. Therefore, according to > the, manual we could change the SPI sample mode from delay half > cycle(default) to normal. > > This patch adds a quirk for this kind of SPI controllers > > Signed-off-by: Maxim Kiselev Tested-by: Sam Edwards Cheers, Sam