From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 327E6ECAAD5 for ; Mon, 5 Sep 2022 15:11:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238786AbiIEPL5 (ORCPT ); Mon, 5 Sep 2022 11:11:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237542AbiIEPLi (ORCPT ); Mon, 5 Sep 2022 11:11:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E817B5E57A; Mon, 5 Sep 2022 08:10:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DE367B811F5; Mon, 5 Sep 2022 15:10:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 494AAC433D7; Mon, 5 Sep 2022 15:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662390638; bh=pmChB25I0/xOioQuvfxS4anHlEB/iWlW/oPqp/l37GY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=exYKUhxTTuUxLlAx8IzrxsRZycm6/RCghmfrKnf2Y+jgggnhvGFRKOfDw938k0eN7 Ka4/6j2Tuj9Zt3Y7X48mHrSvXPQT9guosY4ssOdTs8TzsrlYLI3Nv0vyGfXCiff25g oGcKLVvtoTelM/rTwKUu8ympPdTQ2bUDucZKu/lUv0CpFG/t96Bpd0eBgBtqg4gCAO e9FM9ZW6Nw0N97ZcWZGujwsngRoxOZE4XkM26Vr7u4r1qfaD/sKHzGCn3D9ay7+Kck qjp+hPfCYI/J9b5M4VtpggZ4OO68EL+fS0AvERDajOWIHN2BUedv9uXH9fFqY8X3Ty rErhw2shs1pLw== Message-ID: Date: Mon, 5 Sep 2022 23:10:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] erofs: fix error return code in erofs_fscache_meta_read_folio and erofs_fscache_read_folio Content-Language: en-US To: Sun Ke , xiang@kernel.org Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, yinxin.x@bytedance.com References: <20220815034829.3940803-1-sunke32@huawei.com> From: Chao Yu In-Reply-To: <20220815034829.3940803-1-sunke32@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 2022/8/15 11:48, Sun Ke wrote: > If erofs_fscache_alloc_request fail and then goto out, it will return 0. > it should return a negative error code instead of 0. > > Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache readpage/readahead") > Signed-off-by: Sun Ke Reviewed-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCD0FECAAD3 for ; Mon, 5 Sep 2022 15:10:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MLsQx0Chlz3042 for ; Tue, 6 Sep 2022 01:10:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=exYKUhxT; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=chao@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=exYKUhxT; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MLsQn6tyYz2xfm for ; Tue, 6 Sep 2022 01:10:41 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE25461325; Mon, 5 Sep 2022 15:10:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 494AAC433D7; Mon, 5 Sep 2022 15:10:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662390638; bh=pmChB25I0/xOioQuvfxS4anHlEB/iWlW/oPqp/l37GY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=exYKUhxTTuUxLlAx8IzrxsRZycm6/RCghmfrKnf2Y+jgggnhvGFRKOfDw938k0eN7 Ka4/6j2Tuj9Zt3Y7X48mHrSvXPQT9guosY4ssOdTs8TzsrlYLI3Nv0vyGfXCiff25g oGcKLVvtoTelM/rTwKUu8ympPdTQ2bUDucZKu/lUv0CpFG/t96Bpd0eBgBtqg4gCAO e9FM9ZW6Nw0N97ZcWZGujwsngRoxOZE4XkM26Vr7u4r1qfaD/sKHzGCn3D9ay7+Kck qjp+hPfCYI/J9b5M4VtpggZ4OO68EL+fS0AvERDajOWIHN2BUedv9uXH9fFqY8X3Ty rErhw2shs1pLw== Message-ID: Date: Mon, 5 Sep 2022 23:10:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] erofs: fix error return code in erofs_fscache_meta_read_folio and erofs_fscache_read_folio Content-Language: en-US To: Sun Ke , xiang@kernel.org References: <20220815034829.3940803-1-sunke32@huawei.com> From: Chao Yu In-Reply-To: <20220815034829.3940803-1-sunke32@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, yinxin.x@bytedance.com Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2022/8/15 11:48, Sun Ke wrote: > If erofs_fscache_alloc_request fail and then goto out, it will return 0. > it should return a negative error code instead of 0. > > Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache readpage/readahead") > Signed-off-by: Sun Ke Reviewed-by: Chao Yu Thanks,