Re: [PATCH] xen/keyhandler: Move key_table[] into __ro_after_init

[Jan Beulich <jbeulich@suse.com>]

On 12.09.2024 16:22, Andrew Cooper wrote:
> On 12/09/2024 3:20 pm, Jan Beulich wrote:
>> On 12.09.2024 14:51, Andrew Cooper wrote:
>>> @@ -596,6 +594,8 @@ int __init iommu_setup(void)
>>>      }
>>>      else
>>>      {
>>> +        register_keyhandler('o', &iommu_dump_page_tables, "dump iommu page tables", 0);
>>> +
>>>          if ( iommu_quarantine_init() )
>>>              panic("Could not set up quarantine\n");
>> It's a little odd to have this immediately ahead of something that can
>> panic(), but not a big deal of course. The line wants wrapping though,
>> to stay within 80 cols.
> 
> I'm happy to put it somewhere else if you can suggest somewhere better.

Just at the bottom of this very else block?

Jan