From: Julien Olivain <ju.o@free.fr>
To: Maxim Kochetkov <fido_max@inbox.ru>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/postgresql: add patch to disable docs build
Date: Tue, 31 Dec 2024 18:17:09 +0100 [thread overview]
Message-ID: <ef8da0bbb202d9c4e00285819016bbd9@free.fr> (raw)
In-Reply-To: <6cf7bbe8cdab290b3e8581d40357ecc3@free.fr>
Hi Maxim,
On 11/12/2024 00:00, Julien Olivain wrote:
> Hi Maxim,
>
> Thanks for the patch!
>
> On 10/12/2024 16:42, Maxim Kochetkov via buildroot wrote:
>> docbook package is needed for building docs. Build fails without it
>> if xmllint is found on host:
>>
>> I/O error : Attempt to load network entity:
>> http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd
>> ../doc/src/sgml/postgres.sgml:22: warning: failed to load external
>> entity "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd"
>> ]>
>> ^
>> ../doc/src/sgml/postgres.sgml:24: element book: validity error : No
>> declaration for attribute id of element book
>> <book id="postgres">
>> ^
>>
>> So disable docs build.
>
> It seems postgresql is not always failing. In some situations,
> it can build. See for example:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/8580182027
>
> I also see that the PostgreSQL meson build system provides option
> to build the docs. See:
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=meson_options.txt;h=246cecf382712d94157856d6d5403f6d0fc13148;hb=6304632eaa2107bb1763d29e213ff166ff6104c0#l88
>
> Did you try to always disable docs by setting those options to false
> in _CONF_OPTS?
>
> For example, setting:
>
> POSTGRESQL_CONF_OPTS = \
> -Ddocs=false \
> -Ddocs_pdf=false \
> -Drpath=false
>
> See:
> https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/postgresql/postgresql.mk#L17
For info, I applied the patch from Thomas, see:
https://gitlab.com/buildroot.org/buildroot/-/commit/f0422b41df9d5b638b59ffc9811f9bce135f3e35
There is indeed an upstream bug.
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-12-31 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 15:42 [Buildroot] [PATCH 1/1] package/postgresql: add patch to disable docs build Maxim Kochetkov via buildroot
2024-12-10 23:00 ` Julien Olivain
2024-12-11 4:27 ` Maxim Kochetkov via buildroot
2024-12-31 17:17 ` Julien Olivain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef8da0bbb202d9c4e00285819016bbd9@free.fr \
--to=ju.o@free.fr \
--cc=buildroot@buildroot.org \
--cc=fido_max@inbox.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.