From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E64C2D0A8 for ; Mon, 28 Sep 2020 19:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 277DF2074B for ; Mon, 28 Sep 2020 19:21:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Rj44KFr0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726670AbgI1TVw (ORCPT ); Mon, 28 Sep 2020 15:21:52 -0400 Received: from z5.mailgun.us ([104.130.96.5]:52536 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbgI1TVw (ORCPT ); Mon, 28 Sep 2020 15:21:52 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601320911; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=obVXhgTgepUWdTaJcXF5/0Z4MlxN7LlK1+bxFgWPPcM=; b=Rj44KFr0IWyB+cExn+fDp0JbAJfiCPVLKg2XyIA4lVdDwB76jbpfi/YUe/EYDIn3hAsSBPDu hEWivckXwXBAimDu289taYbCnPCFcGGt2F1DE1Z4nGVDp74icuSiQ67igR6mJSSgYg1ruLMh dHmtD9gxnkFdD6TWX0KqpOVOFnA= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5f7237c270602555f5a9970e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 28 Sep 2020 19:21:38 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5C356C433FF; Mon, 28 Sep 2020 19:21:37 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id A9B0CC433C8; Mon, 28 Sep 2020 19:21:36 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 28 Sep 2020 12:21:36 -0700 From: abhinavk@codeaurora.org To: Stephen Boyd Cc: Rob Clark , Sean Paul , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jeykumar Sankaran , freedreno@lists.freedesktop.org Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: Add newline to printks In-Reply-To: <20200928191657.1193583-1-swboyd@chromium.org> References: <20200928191657.1193583-1-swboyd@chromium.org> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-09-28 12:16, Stephen Boyd wrote: > Printk messages need newlines. Add it here. > > Cc: Abhinav Kumar > Cc: Jeykumar Sankaran > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Signed-off-by: Stephen Boyd Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index f272a8d0f95b..cbe0461246f8 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -906,7 +906,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc > *crtc, > } > > mode = &state->adjusted_mode; > - DPU_DEBUG("%s: check", dpu_crtc->name); > + DPU_DEBUG("%s: check\n", dpu_crtc->name); > > /* force a full mode set if active state changed */ > if (state->active_changed) > @@ -1012,7 +1012,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc > *crtc, > } > > pstates[i].dpu_pstate->stage = z_pos + DPU_STAGE_0; > - DPU_DEBUG("%s: zpos %d", dpu_crtc->name, z_pos); > + DPU_DEBUG("%s: zpos %d\n", dpu_crtc->name, z_pos); > } > > for (i = 0; i < multirect_count; i++) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8394C2D0A8 for ; Mon, 28 Sep 2020 19:21:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7755D2071E for ; Mon, 28 Sep 2020 19:21:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="xIuWP1o5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7755D2071E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 301EA89EF7; Mon, 28 Sep 2020 19:21:40 +0000 (UTC) Received: from z5.mailgun.us (z5.mailgun.us [104.130.96.5]) by gabe.freedesktop.org (Postfix) with ESMTPS id DCECF89EF7 for ; Mon, 28 Sep 2020 19:21:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601320898; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=obVXhgTgepUWdTaJcXF5/0Z4MlxN7LlK1+bxFgWPPcM=; b=xIuWP1o5A45NeZfvkYunP4ae/4TXX8UVuNCQiWADQg/3L2PW+Zkfr824sRG0YKZoSC47VR7/ 8zXoFbh1Oknmmy9RQ9wgNoxjMNY1Ap1KqQTJGQprKQFMWt9nxLDsBwgCKK8GfReXRndg3crS t6cEhmwFe0iy1fW9AjrancaKo/A= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5f7237c2e6be23d0dfcc550a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 28 Sep 2020 19:21:38 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 50D19C433CA; Mon, 28 Sep 2020 19:21:37 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id A9B0CC433C8; Mon, 28 Sep 2020 19:21:36 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 28 Sep 2020 12:21:36 -0700 From: abhinavk@codeaurora.org To: Stephen Boyd Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: Add newline to printks In-Reply-To: <20200928191657.1193583-1-swboyd@chromium.org> References: <20200928191657.1193583-1-swboyd@chromium.org> Message-ID: X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-09-28 12:16, Stephen Boyd wrote: > Printk messages need newlines. Add it here. > > Cc: Abhinav Kumar > Cc: Jeykumar Sankaran > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > Signed-off-by: Stephen Boyd Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index f272a8d0f95b..cbe0461246f8 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -906,7 +906,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc > *crtc, > } > > mode = &state->adjusted_mode; > - DPU_DEBUG("%s: check", dpu_crtc->name); > + DPU_DEBUG("%s: check\n", dpu_crtc->name); > > /* force a full mode set if active state changed */ > if (state->active_changed) > @@ -1012,7 +1012,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc > *crtc, > } > > pstates[i].dpu_pstate->stage = z_pos + DPU_STAGE_0; > - DPU_DEBUG("%s: zpos %d", dpu_crtc->name, z_pos); > + DPU_DEBUG("%s: zpos %d\n", dpu_crtc->name, z_pos); > } > > for (i = 0; i < multirect_count; i++) { _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel