From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254B8C433F5 for ; Sat, 21 May 2022 13:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233773AbiEUN4q (ORCPT ); Sat, 21 May 2022 09:56:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbiEUN4p (ORCPT ); Sat, 21 May 2022 09:56:45 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19FD83EAA4; Sat, 21 May 2022 06:56:45 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id w3so2854719plp.13; Sat, 21 May 2022 06:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=kFTe+XhGcQtsCoxkdaBMhP9gdy39T6uFw4OY1itArqs=; b=lf4BRQDe4TQwfCGwiFVP/JssPHosaBGPwsqgMBj4ZWP4Vq5KIPUFkHC3txKh1EI7n5 Mdc6RCiKccE+hg0QxPUTXIufN2yu1sG39zY7FvBoiNKvRhbPMxWyW1cDR2VWNkMXUCh5 +UOYrrV0+XMrypDknkx1bP4T1+tFPXSTqM7ZyWExtyp2bYkqm4VvnJqJSYfxnpHRjYPp oqqQlOW6VO8GXAodLWFC0Cq0Uq44yvyWbmq6rEu1IK5pNrTphnWqkzVaO6OubxQ6GU/b 56Fr/OdvvDLfK0FoLkWiSxrDaJGJXmI4xPCZMKEvmaPwKQhE+YW5MBlh0OPsT7RfkGIF vIXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=kFTe+XhGcQtsCoxkdaBMhP9gdy39T6uFw4OY1itArqs=; b=JlkhkFdNxWR2Q5jh1x+d76Ia0Z+rIY7yWC8mAzi1CNkFafYCc2E7zc7r6HYqRiuVvg 2+DlRghTWFcEiIjHrCWmA4fZ0atzTiS7MAg1/rlNgcg3G6I4nFpGp3HNGjxR9lRJaJWk CyzxE8u+fL+YV/8j2Z2A/RMDI4KHwGweGk/hwVcG9vQwkH9jkfJfG73CzP9nT4pjIvEV XR5fHVEVxhrWgpwsNayerr5Up16iU1UGf4NAhF3UvL3PXc9Ol0620FNb8LXSWdaY31Gm 9NUr3BDAqlZHN7DXwRY6RCwAtjpPfi43pCyAZ/aLNA0rOagb6kEeixJVlrK1O4sfHR+v FbfQ== X-Gm-Message-State: AOAM532uMazO2lgATp1avdaoW+Lz+5ExwHqKg72gn09bZjlEp/wbMKeO lDm6p4oBByt1oR9bE2tk58EGt/v9yMq+ou9e X-Google-Smtp-Source: ABdhPJy1JKi1c7JDWXFWM58P3YBC8dI7WvgxnvWbgjGMf2zWcYOH0NoWoucyWHrXIRYfzVAxGdFomA== X-Received: by 2002:a17:902:ccd0:b0:156:7ac2:5600 with SMTP id z16-20020a170902ccd000b001567ac25600mr14348873ple.156.1653141404604; Sat, 21 May 2022 06:56:44 -0700 (PDT) Received: from [172.16.10.243] ([219.142.146.204]) by smtp.gmail.com with ESMTPSA id e19-20020a170902f1d300b001617541c94fsm1628412plc.60.2022.05.21.06.56.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 May 2022 06:56:44 -0700 (PDT) Message-ID: Date: Sat, 21 May 2022 21:56:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] i2c: bcm2835: Fix error handling in bcm2835_i2c_probe Content-Language: en-US To: Christophe JAILLET , Wolfram Sang , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Stefan Wahren , Eric Anholt , Lad Prabhakar , Annaliese McDermond , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220403063310.7525-1-linmq006@gmail.com> From: Miaoqian Lin In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 2022/5/21 20:28, Christophe JAILLET wrote: > Le 21/05/2022 à 13:46, Wolfram Sang a écrit : >> On Sun, Apr 03, 2022 at 06:33:08AM +0000, Miaoqian Lin wrote: >>> In the error handling path, the clk_prepare_enable() function >>> call should be balanced by a corresponding 'clk_disable_unprepare()' >>> call. And clk_set_rate_exclusive calls clk_rate_exclusive_get(), >>> it should be balanced with call to clk_rate_exclusive_put(). >>> , as already done in the remove function. >>> >>> Fixes: bebff81fb8b9 ("i2c: bcm2835: Model Divider in CCF") >>> Signed-off-by: Miaoqian Lin >> >> Looking for a reviewer here, pretty please? > > Hi, > > on which tree are you working? > A similar patch is already available in -next since several months. (see [1]) > Hi, I mainly work on master, sorry I didn't notice it when submitted. I may make a mistake with synchronize, thanks for your reply. > CJ > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/i2c/busses/i2c-bcm2835.c?id=b205f5850263632b6897d8f0bfaeeea4955f8663 >> >>> --- >>>   drivers/i2c/busses/i2c-bcm2835.c | 21 ++++++++++++++++----- >>>   1 file changed, 16 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c >>> index 5149454eef4a..d794448866a7 100644 >>> --- a/drivers/i2c/busses/i2c-bcm2835.c >>> +++ b/drivers/i2c/busses/i2c-bcm2835.c >>> @@ -454,18 +454,21 @@ static int bcm2835_i2c_probe(struct platform_device *pdev) >>>       ret = clk_prepare_enable(i2c_dev->bus_clk); >>>       if (ret) { >>>           dev_err(&pdev->dev, "Couldn't prepare clock"); >>> -        return ret; >>> +        goto err_put_clk; >>>       } >>>         i2c_dev->irq = platform_get_irq(pdev, 0); >>> -    if (i2c_dev->irq < 0) >>> -        return i2c_dev->irq; >>> +    if (i2c_dev->irq < 0) { >>> +        ret =  i2c_dev->irq; >>> +        goto err_disable_clk; >>> +    } >>>         ret = request_irq(i2c_dev->irq, bcm2835_i2c_isr, IRQF_SHARED, >>>                 dev_name(&pdev->dev), i2c_dev); >>>       if (ret) { >>>           dev_err(&pdev->dev, "Could not request IRQ\n"); >>> -        return -ENODEV; >>> +        ret = -ENODEV; >>> +        goto err_disable_clk; >>>       } >>>         adap = &i2c_dev->adapter; >>> @@ -489,8 +492,16 @@ static int bcm2835_i2c_probe(struct platform_device *pdev) >>>         ret = i2c_add_adapter(adap); >>>       if (ret) >>> -        free_irq(i2c_dev->irq, i2c_dev); >>> +        goto err_free_irq; >>> + >>> +    return ret; >>>   +err_free_irq: >>> +    free_irq(i2c_dev->irq, i2c_dev); >>> +err_disable_clk: >>> +    clk_disable_unprepare(i2c_dev->bus_clk); >>> +err_put_clk: >>> +    clk_rate_exclusive_put(i2c_dev->bus_clk); >>>       return ret; >>>   } >>>   --  >>> 2.17.1 >>> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A60D6C433EF for ; Sat, 21 May 2022 13:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hVQYaGjFQ8ewliltEtrSBo45va3sgnaxvcsTMGPPvpM=; b=AyLWKI32Umrcqg UZJiACxycwoeO+vJgF3tBXXKvK4ZgLX5fvTCr2AfjfaWhvyU/LKpYxB+YRUcsBqmJTgQ1PXtAZXCL 0UAfmx0AEJbBmC58gkHo0IuCNxXX4cuwzBFXA4hIoO17F8ShCqQ19/Z27XwkBmyOIAsRJcbKgi1XH L1cp51nQx/5/Y4cBxxk1ShWfco79CxloC5TihoTAVNrU49mWuCs/qU90BHLbpvE1Mav+nEpg98Hbd QrL+LIE+LDfngKSvntpCAdEhbiQ/AXzSs/fYg6O4pd2bH3KlfBuCw5UTJF4NlfKj8wFahz1+STKKD UJFPQqb4qxE/8VvkbXrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsPb8-00Gg5r-OY; Sat, 21 May 2022 13:56:50 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsPb4-00Gg55-Ha; Sat, 21 May 2022 13:56:48 +0000 Received: by mail-pl1-x62d.google.com with SMTP id n8so9488862plh.1; Sat, 21 May 2022 06:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=kFTe+XhGcQtsCoxkdaBMhP9gdy39T6uFw4OY1itArqs=; b=lf4BRQDe4TQwfCGwiFVP/JssPHosaBGPwsqgMBj4ZWP4Vq5KIPUFkHC3txKh1EI7n5 Mdc6RCiKccE+hg0QxPUTXIufN2yu1sG39zY7FvBoiNKvRhbPMxWyW1cDR2VWNkMXUCh5 +UOYrrV0+XMrypDknkx1bP4T1+tFPXSTqM7ZyWExtyp2bYkqm4VvnJqJSYfxnpHRjYPp oqqQlOW6VO8GXAodLWFC0Cq0Uq44yvyWbmq6rEu1IK5pNrTphnWqkzVaO6OubxQ6GU/b 56Fr/OdvvDLfK0FoLkWiSxrDaJGJXmI4xPCZMKEvmaPwKQhE+YW5MBlh0OPsT7RfkGIF vIXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=kFTe+XhGcQtsCoxkdaBMhP9gdy39T6uFw4OY1itArqs=; b=KN7dO6BZIneUssEsN+ejVwIRbrhoKuXHAQPTB6B6qeKT2disPGTRA2eIpBHVaD87Zx HvRQ7+7hOdSd2HdYuyhFC/vwamsVPg020ILsxWi1SGyNcO4PHYYY/8H7ZQUEXZEzORuI KSgkr1dp0sF2DoXECv9U6KW4ToqRyOzJgo4SZIazM7/murav71sI55wI9QGWBtMkltZ2 RRViBFWV93mpt+o4LD6cSyP2K1KKQFXqEm+hZHbY8VAXFGXqCg+LnBS4l8W2WyNWLjc/ FhP6VDXxJ0wuSIvZBJlBmOqayUOXMCHuiKdAnOwXwdynMVX3KYAC/UyBXMBhuRGX6FsW o8aQ== X-Gm-Message-State: AOAM533FwQJURABvDwC/IvfaGBBugnsqw9OU1bj3SWwGQiX/zuiZUSBp +DAqqfdQEpO9bRmn7MXemXQ= X-Google-Smtp-Source: ABdhPJy1JKi1c7JDWXFWM58P3YBC8dI7WvgxnvWbgjGMf2zWcYOH0NoWoucyWHrXIRYfzVAxGdFomA== X-Received: by 2002:a17:902:ccd0:b0:156:7ac2:5600 with SMTP id z16-20020a170902ccd000b001567ac25600mr14348873ple.156.1653141404604; Sat, 21 May 2022 06:56:44 -0700 (PDT) Received: from [172.16.10.243] ([219.142.146.204]) by smtp.gmail.com with ESMTPSA id e19-20020a170902f1d300b001617541c94fsm1628412plc.60.2022.05.21.06.56.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 May 2022 06:56:44 -0700 (PDT) Message-ID: Date: Sat, 21 May 2022 21:56:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] i2c: bcm2835: Fix error handling in bcm2835_i2c_probe Content-Language: en-US To: Christophe JAILLET , Wolfram Sang , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Stefan Wahren , Eric Anholt , Lad Prabhakar , Annaliese McDermond , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220403063310.7525-1-linmq006@gmail.com> From: Miaoqian Lin In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220521_065646_621006_89339176 X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjIvNS8yMSAyMDoyOCwgQ2hyaXN0b3BoZSBKQUlMTEVUIHdyb3RlOgo+IExlIDIxLzA1 LzIwMjIgw6AgMTM6NDYsIFdvbGZyYW0gU2FuZyBhIMOpY3JpdMKgOgo+PiBPbiBTdW4sIEFwciAw MywgMjAyMiBhdCAwNjozMzowOEFNICswMDAwLCBNaWFvcWlhbiBMaW4gd3JvdGU6Cj4+PiBJbiB0 aGUgZXJyb3IgaGFuZGxpbmcgcGF0aCwgdGhlIGNsa19wcmVwYXJlX2VuYWJsZSgpIGZ1bmN0aW9u Cj4+PiBjYWxsIHNob3VsZCBiZSBiYWxhbmNlZCBieSBhIGNvcnJlc3BvbmRpbmcgJ2Nsa19kaXNh YmxlX3VucHJlcGFyZSgpJwo+Pj4gY2FsbC4gQW5kIGNsa19zZXRfcmF0ZV9leGNsdXNpdmUgY2Fs bHMgY2xrX3JhdGVfZXhjbHVzaXZlX2dldCgpLAo+Pj4gaXQgc2hvdWxkIGJlIGJhbGFuY2VkIHdp dGggY2FsbCB0byBjbGtfcmF0ZV9leGNsdXNpdmVfcHV0KCkuCj4+PiAsIGFzIGFscmVhZHkgZG9u ZSBpbiB0aGUgcmVtb3ZlIGZ1bmN0aW9uLgo+Pj4KPj4+IEZpeGVzOiBiZWJmZjgxZmI4YjkgKCJp MmM6IGJjbTI4MzU6IE1vZGVsIERpdmlkZXIgaW4gQ0NGIikKPj4+IFNpZ25lZC1vZmYtYnk6IE1p YW9xaWFuIExpbiA8bGlubXEwMDZAZ21haWwuY29tPgo+Pgo+PiBMb29raW5nIGZvciBhIHJldmll d2VyIGhlcmUsIHByZXR0eSBwbGVhc2U/Cj4KPiBIaSwKPgo+IG9uIHdoaWNoIHRyZWUgYXJlIHlv dSB3b3JraW5nPwo+IEEgc2ltaWxhciBwYXRjaCBpcyBhbHJlYWR5IGF2YWlsYWJsZSBpbiAtbmV4 dCBzaW5jZSBzZXZlcmFsIG1vbnRocy4gKHNlZSBbMV0pCj4KCkhpLAoKSSBtYWlubHkgd29yayBv biBtYXN0ZXIsIHNvcnJ5IEkgZGlkbid0IG5vdGljZSBpdCB3aGVuIHN1Ym1pdHRlZC4KCkkgbWF5 IG1ha2UgYSBtaXN0YWtlIHdpdGggc3luY2hyb25pemUsIHRoYW5rcyBmb3IgeW91ciByZXBseS4K Cj4gQ0oKPgo+IFsxXTogaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5l bC9naXQvbmV4dC9saW51eC1uZXh0LmdpdC9jb21taXQvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1i Y20yODM1LmM/aWQ9YjIwNWY1ODUwMjYzNjMyYjY4OTdkOGYwYmZhZWVlYTQ5NTVmODY2Mwo+Pgo+ Pj4gLS0tCj4+PiDCoCBkcml2ZXJzL2kyYy9idXNzZXMvaTJjLWJjbTI4MzUuYyB8IDIxICsrKysr KysrKysrKysrKystLS0tLQo+Pj4gwqAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyks IDUgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaTJjL2J1c3Nlcy9p MmMtYmNtMjgzNS5jIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1iY20yODM1LmMKPj4+IGluZGV4 IDUxNDk0NTRlZWY0YS4uZDc5NDQ0ODg2NmE3IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9pMmMv YnVzc2VzL2kyYy1iY20yODM1LmMKPj4+ICsrKyBiL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtYmNt MjgzNS5jCj4+PiBAQCAtNDU0LDE4ICs0NTQsMjEgQEAgc3RhdGljIGludCBiY20yODM1X2kyY19w cm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+Pj4gwqDCoMKgwqDCoCByZXQgPSBj bGtfcHJlcGFyZV9lbmFibGUoaTJjX2Rldi0+YnVzX2Nsayk7Cj4+PiDCoMKgwqDCoMKgIGlmIChy ZXQpIHsKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBkZXZfZXJyKCZwZGV2LT5kZXYsICJDb3VsZG4n dCBwcmVwYXJlIGNsb2NrIik7Cj4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJldDsKPj4+ICvC oMKgwqDCoMKgwqDCoCBnb3RvIGVycl9wdXRfY2xrOwo+Pj4gwqDCoMKgwqDCoCB9Cj4+PiDCoCDC oMKgwqDCoMKgIGkyY19kZXYtPmlycSA9IHBsYXRmb3JtX2dldF9pcnEocGRldiwgMCk7Cj4+PiAt wqDCoMKgIGlmIChpMmNfZGV2LT5pcnEgPCAwKQo+Pj4gLcKgwqDCoMKgwqDCoMKgIHJldHVybiBp MmNfZGV2LT5pcnE7Cj4+PiArwqDCoMKgIGlmIChpMmNfZGV2LT5pcnEgPCAwKSB7Cj4+PiArwqDC oMKgwqDCoMKgwqAgcmV0ID3CoCBpMmNfZGV2LT5pcnE7Cj4+PiArwqDCoMKgwqDCoMKgwqAgZ290 byBlcnJfZGlzYWJsZV9jbGs7Cj4+PiArwqDCoMKgIH0KPj4+IMKgIMKgwqDCoMKgwqAgcmV0ID0g cmVxdWVzdF9pcnEoaTJjX2Rldi0+aXJxLCBiY20yODM1X2kyY19pc3IsIElSUUZfU0hBUkVELAo+ Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGRldl9uYW1lKCZwZGV2LT5kZXYpLCBp MmNfZGV2KTsKPj4+IMKgwqDCoMKgwqAgaWYgKHJldCkgewo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKg IGRldl9lcnIoJnBkZXYtPmRldiwgIkNvdWxkIG5vdCByZXF1ZXN0IElSUVxuIik7Cj4+PiAtwqDC oMKgwqDCoMKgwqAgcmV0dXJuIC1FTk9ERVY7Cj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0ID0gLUVO T0RFVjsKPj4+ICvCoMKgwqDCoMKgwqDCoCBnb3RvIGVycl9kaXNhYmxlX2NsazsKPj4+IMKgwqDC oMKgwqAgfQo+Pj4gwqAgwqDCoMKgwqDCoCBhZGFwID0gJmkyY19kZXYtPmFkYXB0ZXI7Cj4+PiBA QCAtNDg5LDggKzQ5MiwxNiBAQCBzdGF0aWMgaW50IGJjbTI4MzVfaTJjX3Byb2JlKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4+PiDCoCDCoMKgwqDCoMKgIHJldCA9IGkyY19hZGRfYWRh cHRlcihhZGFwKTsKPj4+IMKgwqDCoMKgwqAgaWYgKHJldCkKPj4+IC3CoMKgwqDCoMKgwqDCoCBm cmVlX2lycShpMmNfZGV2LT5pcnEsIGkyY19kZXYpOwo+Pj4gK8KgwqDCoMKgwqDCoMKgIGdvdG8g ZXJyX2ZyZWVfaXJxOwo+Pj4gKwo+Pj4gK8KgwqDCoCByZXR1cm4gcmV0Owo+Pj4gwqAgK2Vycl9m cmVlX2lycToKPj4+ICvCoMKgwqAgZnJlZV9pcnEoaTJjX2Rldi0+aXJxLCBpMmNfZGV2KTsKPj4+ ICtlcnJfZGlzYWJsZV9jbGs6Cj4+PiArwqDCoMKgIGNsa19kaXNhYmxlX3VucHJlcGFyZShpMmNf ZGV2LT5idXNfY2xrKTsKPj4+ICtlcnJfcHV0X2NsazoKPj4+ICvCoMKgwqAgY2xrX3JhdGVfZXhj bHVzaXZlX3B1dChpMmNfZGV2LT5idXNfY2xrKTsKPj4+IMKgwqDCoMKgwqAgcmV0dXJuIHJldDsK Pj4+IMKgIH0KPj4+IMKgIC0twqAKPj4+IDIuMTcuMQo+Pj4KPgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=