From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03BF0C27C55 for ; Mon, 10 Jun 2024 15:58:50 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.737434.1143739 (Exim 4.92) (envelope-from ) id 1sGhPt-0001Q6-BS; Mon, 10 Jun 2024 15:58:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 737434.1143739; Mon, 10 Jun 2024 15:58:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sGhPt-0001Pz-8z; Mon, 10 Jun 2024 15:58:41 +0000 Received: by outflank-mailman (input) for mailman id 737434; Mon, 10 Jun 2024 15:58:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sGhPr-0001P6-VI for xen-devel@lists.xenproject.org; Mon, 10 Jun 2024 15:58:39 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d179d9e-2742-11ef-90a2-e314d9c70b13; Mon, 10 Jun 2024 17:58:38 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a6e43dad8ecso495944166b.1 for ; Mon, 10 Jun 2024 08:58:38 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6c8072ac1fsm653146266b.222.2024.06.10.08.58.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jun 2024 08:58:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d179d9e-2742-11ef-90a2-e314d9c70b13 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1718035118; x=1718639918; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=ha3gXWnhYiXnhWqYZL762tgIJAgzO9EIImER1q6mngg=; b=Z5zKb0WZzscSv3hQYZQtV8VzUCpLeFiHKc0fhpeKkyJRu+/lRhAUEWkBtKrptqjfm1 L5iH2ycHjDRviK5NwAF+JJWBwvTquWpadlFQ0YryBbtlgRA7Upw68LsFQqo968zzrkeO KxBKI0suW3DVEOFl4g6dxybHI7+pVNB1vU6KcSb80IYhd/eUMy0sSvnDHbPTsE+CX9Jw 4F/vQ6wCUm1/85r5wzHkM4xJeXaiKPZNhFK0fh+VJr0pIpH0KLAB4qHSKAMm4QlKhwqW iIdplGZCtY+7xz1+/dee+BvJWa4MCRfyao6vpDeOKy37H94xkCXM3xhUsWVynHRhsx9E lXuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718035118; x=1718639918; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ha3gXWnhYiXnhWqYZL762tgIJAgzO9EIImER1q6mngg=; b=LiursuIoUQU0ZIQuUmoi6oS5OeJHTTZFbeog4Ajomf1Hd8r37Hn06oKj4br92up0lb 4eaGwXPu+NRlm7bVah45bzKiNYt1KKlkUGz8OM51CDq6HhCTkcfUmWMvNn/kbBby3efz J3HTnNcGJhuxigLS27s993ySozx8nX+6af3vRlMLmKJThOUccNfwUL9rRVJQcVWha6fW Z6+ZfEHh8d6boT/gxUUmhjcyUX4bOKFvxgWAAx5MCoKnaNGynytjyUq3D7NbHGUNCvtx FgcehjvoycWtaunUha7LkxDp9GqlBvd5GFpxlICzQVXwpVsCoQ450Tb7ioXxFDyDeTvG 445g== X-Forwarded-Encrypted: i=1; AJvYcCUKQUSlTCkazVzHAM0NNKfvNmKRuwPGoULxopQP3jSWxvemeZTMe6Vb9YHkrn1+GoCU4Lo162hObOS8RfGV42ZXJClr7DrdxzwwWWE+YB4= X-Gm-Message-State: AOJu0Yw0mfq4mjnGkRjMUJHVqoFnvxzZUdJaJiutSD5sLPqQCkQwGfAU Ug/zt03hzpXpCqmQIkR25C9Q9/4s2woFF955jgd/OO++deZf9tYGALzC3WLwhw== X-Google-Smtp-Source: AGHT+IGyaqcvnQ6yq7vdbXiphgSd1IzzdXKCjqkWoehW+j4W4UfNztB4kZ5DnnoguNWDZOhlEkijXg== X-Received: by 2002:a17:906:1ccb:b0:a6e:542f:b87b with SMTP id a640c23a62f3a-a6f34cf5bf9mr5013666b.19.1718035118184; Mon, 10 Jun 2024 08:58:38 -0700 (PDT) Message-ID: Date: Mon, 10 Jun 2024 17:58:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [XEN PATCH v9 2/5] x86/pvh: Allow (un)map_pirq when dom0 is PVH To: Jiqian Chen Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Anthony PERARD , Juergen Gross , "Daniel P . Smith" , Stewart Hildebrand , Huang Rui , xen-devel@lists.xenproject.org References: <20240607081127.126593-1-Jiqian.Chen@amd.com> <20240607081127.126593-3-Jiqian.Chen@amd.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240607081127.126593-3-Jiqian.Chen@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07.06.2024 10:11, Jiqian Chen wrote: > If run Xen with PVH dom0 and hvm domU, hvm will map a pirq for > a passthrough device by using gsi, see qemu code > xen_pt_realize->xc_physdev_map_pirq and libxl code > pci_add_dm_done->xc_physdev_map_pirq. Then xc_physdev_map_pirq > will call into Xen, but in hvm_physdev_op, PHYSDEVOP_map_pirq > is not allowed because currd is PVH dom0 and PVH has no > X86_EMU_USE_PIRQ flag, it will fail at has_pirq check. > > So, allow PHYSDEVOP_map_pirq when dom0 is PVH and also allow > PHYSDEVOP_unmap_pirq for the failed path to unmap pirq. And > add a new check to prevent self map when subject domain has no > PIRQ flag. > > Signed-off-by: Huang Rui > Signed-off-by: Jiqian Chen > Reviewed-by: Stefano Stabellini What's imo missing in the description is a clarification / justification of why it is going to be a good idea (or at least an acceptable one) to expose the concept of PIRQs to PVH. If I'm not mistaken that concept so far has been entirely a PV one. > --- a/xen/arch/x86/hvm/hypercall.c > +++ b/xen/arch/x86/hvm/hypercall.c > @@ -71,8 +71,14 @@ long hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > > switch ( cmd ) > { > + /* > + * Only being permitted for management of other domains. > + * Further restrictions are enforced in do_physdev_op. > + */ > case PHYSDEVOP_map_pirq: > case PHYSDEVOP_unmap_pirq: > + break; Nit: Imo such a comment ought to be indented like code (statements), not like the case labels. Jan