From: Vasant Hegde <vasant.hegde@amd.com>
To: "Mario Limonciello (AMD)" <superm1@kernel.org>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Alex Deucher <alexander.deucher@amd.com>,
Joerg Roedel <joro@8bytes.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev
Subject: Re: [PATCH v5] iommu/amd: Enable PerfOpt automatically for integrated GPUs
Date: Thu, 5 Nov 2026 15:55:17 +0530 [thread overview]
Message-ID: <efd2a9cc-dcbb-4f45-8dd7-7fcd713830ec@amd.com> (raw)
In-Reply-To: <4206ec86-c6aa-447a-a5d1-4d2e89a31b5c@amd.com>
Alex,
On 11/2/2026 8:26 PM, Vasant Hegde wrote:
>
>
> On 10/23/2026 2:16 AM, Mario Limonciello (AMD) wrote:
>> PerfOpt is usable by integrated GPUs in identity mode. Enable it from
>> the IOMMU driver's domain attachment paths instead of requiring an
>> amdgpu policy knob and exported enable/disable interfaces.
>>
>> Mark supported integrated GPUs as PerfOpt-eligible when selecting their
>> default identity domain. Skip GCR3 setup and ATS/PRI/PASID enablement for
>> these identity attachments, then enable PerfOpt after installing the DTE.
>> Clear PerfOpt before attaching an eligible GPU to a translated or blocked
>> domain, including unmanaged domains used by VFIO. Propagate failures to
>> clear bypass, but keep a completed identity attachment successful if the
>> optional PerfOpt enable fails.
>>
>> Clear inherited PerfOpt state during initialization, including when a crash
>> kernel reuses device tables. Read feature support directly from hardware
>> because cached features may not be available yet, and stop initialization
>> if the initial clear fails.
>>
>> Each IOMMU has at most one PerfOpt-eligible GPU, so track activation with a
>> boolean under the IOMMU lock. Preserve this state while clearing hardware
>> at suspend and shutdown, and restore the bit on resume only where it was
>> active. Do not enable PerfOpt unconditionally during early IOMMU
>> initialization.
>>
>> Remove the amdgpu parameter, driver callbacks, and exported interfaces.
>> Translated attachments retain their normal device capability setup.
>>
>> Suggested-by: Jason Gunthorpe <jgg@ziepe.ca>
>> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
>
> Looks good. Queued for rc.
Can you ack this patch so that we can pick it through IOMMU tree?
-Vasant
next prev parent reply other threads:[~2026-11-05 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 20:46 [PATCH v5] iommu/amd: Enable PerfOpt automatically for integrated GPUs Mario Limonciello (AMD)
2026-11-02 14:56 ` Vasant Hegde
2026-11-05 10:25 ` Vasant Hegde [this message]
2026-11-05 15:25 ` Deucher, Alexander
2026-11-18 18:50 ` Jason Gunthorpe
2026-11-18 18:54 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efd2a9cc-dcbb-4f45-8dd7-7fcd713830ec@amd.com \
--to=vasant.hegde@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=superm1@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.