From: Paolo Abeni <pabeni@redhat.com>
To: Yuyang Huang <yuyanghuang@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Simon Horman" <horms@kernel.org>,
"David Ahern" <dsahern@kernel.org>,
netdev@vger.kernel.org, "Donald Hunter" <donald.hunter@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
"Nikolay Aleksandrov" <razor@blackwall.org>,
"Hangbin Liu" <liuhangbin@gmail.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
linux-kselftest@vger.kernel.org,
"Maciej Żenczykowski" <maze@google.com>,
"Lorenzo Colitti" <lorenzo@google.com>
Subject: Re: [PATCH net-next, v7 1/2] netlink: support dumping IPv4 multicast addresses
Date: Thu, 6 Feb 2025 15:29:02 +0100 [thread overview]
Message-ID: <efd3dee8-5a2d-4928-ba1d-ddccb2f29fbe@redhat.com> (raw)
In-Reply-To: <20250204091918.2652604-1-yuyanghuang@google.com>
On 2/4/25 10:19 AM, Yuyang Huang wrote:
> diff --git a/include/linux/igmp_internal.h b/include/linux/igmp_internal.h
> new file mode 100644
> index 000000000000..0a1bcc8ec8e1
> --- /dev/null
> +++ b/include/linux/igmp_internal.h
I did not undertand you intended to place the new header under the
'include' directory. I still have a preference for a really private
header that would under 'net/ipv4/' (IMHO the possible future divergence
of inet_fill_args and inet6_fill_args is not very relevant) but it's not
a deal breaker.
/P
next prev parent reply other threads:[~2025-02-06 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 9:19 [PATCH net-next, v7 1/2] netlink: support dumping IPv4 multicast addresses Yuyang Huang
2025-02-04 9:19 ` [PATCH net-next, v7 2/2] selftests/net: Add selftest for IPv4 RTM_GETMULTICAST support Yuyang Huang
2025-02-06 14:23 ` Paolo Abeni
2025-02-06 15:59 ` Yuyang Huang
2025-02-06 14:29 ` Paolo Abeni [this message]
2025-02-06 16:00 ` [PATCH net-next, v7 1/2] netlink: support dumping IPv4 multicast addresses Yuyang Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efd3dee8-5a2d-4928-ba1d-ddccb2f29fbe@redhat.com \
--to=pabeni@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=yuyanghuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.