From: Maarten Lankhorst <maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Archit Taneja <architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
intel-gfx-trybot-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 07/12] drm/msm: Handle drm_atomic_helper_swap_state failure
Date: Wed, 19 Jul 2017 12:07:07 +0200 [thread overview]
Message-ID: <efd47993-8f8a-707d-e9e5-e0ed38a3d526@linux.intel.com> (raw)
In-Reply-To: <2d51335c-c1d1-3a01-002a-900bbe77e509-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Op 19-07-17 om 11:24 schreef Archit Taneja:
>
>
> On 07/19/2017 01:10 PM, Maarten Lankhorst wrote:
>> drm_atomic_helper_swap_state() will be changed to interruptible waiting
>> in the next few commits, so all drivers have to be changed to handling
>> failure.
>>
>> MSM has its own busy tracking, which means the swap_state call can be
>> done with stall = false, in which case it should never return an error.
>> Handle failure with BUG_ON for this reason.
>>
>
> Applied #2/12 and tried this out.
>
> Tested-by: Archit Taneja <architt@codeaurora.org>
Thanks, applied series.
I accidentally sent this out to everyone instead of trybot only, but applying your t-b to the commit. :)
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
next prev parent reply other threads:[~2017-07-19 10:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 7:40 [PATCH 01/12] drm/nouveau: Fix error handling in nv50_disp_atomic_commit Maarten Lankhorst
2017-07-19 7:40 ` Maarten Lankhorst
2017-07-19 7:40 ` [PATCH 02/12] drm/atomic: Change drm_atomic_helper_swap_state to return an error Maarten Lankhorst
2017-07-19 7:40 ` Maarten Lankhorst
2017-07-19 7:40 ` [PATCH 06/12] drm/mediatek: Handle drm_atomic_helper_swap_state failure Maarten Lankhorst
2017-07-19 7:40 ` Maarten Lankhorst
[not found] ` <20170719074052.2993-1-maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-07-19 7:40 ` [PATCH 03/12] drm/nouveau: " Maarten Lankhorst
2017-07-19 7:40 ` [PATCH 07/12] drm/msm: " Maarten Lankhorst
[not found] ` <20170719074052.2993-7-maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-07-19 9:24 ` Archit Taneja
[not found] ` <2d51335c-c1d1-3a01-002a-900bbe77e509-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-07-19 10:07 ` Maarten Lankhorst [this message]
2017-07-19 7:40 ` [PATCH 08/12] drm/tegra: " Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efd47993-8f8a-707d-e9e5-e0ed38a3d526@linux.intel.com \
--to=maarten.lankhorst-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=intel-gfx-trybot-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.