Re: [PATCH v7 3/3] tools/ocaml: Add OCaml binding for NUMA claim sets

[Jan Beulich <jbeulich@suse.com>]

On 28.05.2026 10:37, Bernhard Kaindl wrote:
>> -----Original Message-----
>>> Acked-by: Christian Lindig <christian.lindig@cloud.com>
>>> Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> Signed-off-by: Bernhard Kaindl <bernhard.kaindl@citrix.com>
>>
>> Nit: Chronologically order tags, please: Christian can't have ack-ed
>> this before you signed off on it.
> 
> Hi Jan, as this was the last patch in this series,
> 
> I assume you found no reason which can't be fixed on merge for this
> series and you can ack it? (I think item could be fixed on merge)

Why would I ack an OCaml patch?

As to fixing while committing - perhaps that's easily possible here, but
(a) I wouldn't commit this (tools) patch on its own and (b) the other
two patches look to still be pending (with me just having returned from
a week of PTO I still didn't get around to read xen-develq, though).
However, edits upon committing is strictly an offer by the committer. It
shouldn't normally be the submitter to be asking for such.

> If you could, please do so, otherwise could I you expedite your review
> of it?

Expedite review of what? As this isn't the first time to try to apply
pressure for me to review your patches: May I please ask that you don't?
Your patches aren't any different from patches by others.

> At lot of further NUMA work depends on it, and it as it has been posted
> in this or very similar form before the deadlines for Xen 4.22, it would
> be nice if it could be considered for merge.

Again, without having read xen-devel@ yet, it was my understanding
(assumption) that the NUMA work has missed the 4.22 window.

Jan