From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=james.feist@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4721bZ4695zDrgP for ; Tue, 29 Oct 2019 04:16:41 +1100 (AEDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 10:16:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,240,1569308400"; d="scan'208";a="374288041" Received: from skyhawk.jf.intel.com (HELO [10.54.51.81]) ([10.54.51.81]) by orsmga005.jf.intel.com with ESMTP; 28 Oct 2019 10:16:38 -0700 Subject: Re: Showing signed sensor value when the command "ipmitool sel elist" is executed To: =?UTF-8?B?VG9ueSBMZWUgKOadjuaWh+WvjCk=?= , "jason.m.bills@linux.intel.com" Cc: "openbmc@lists.ozlabs.org" , =?UTF-8?B?QnVkZHkgSHVhbmcgKOm7g+Wkqem0uyk=?= References: From: James Feist Message-ID: Date: Mon, 28 Oct 2019 10:16:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=big5; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2019 17:16:43 -0000 On 10/27/19 11:41 PM, Tony Lee (§õ¤å´I) wrote: > Hi Jason, > > We know that when we execute the command "ipmitool sel elist", it will return something like the following, > "18 | 10/16/19 | 18:28:41 UTC | Temperature nvme0 | Upper Non-critical going high | Asserted | Reading 72 > Threshold 70 degrees C". > > I met a problem that when the sensor value in the d-bus is negative, the current reading in "ipmitool sel elist" will be 0. > It seems that because the type of scaledValue is defined "uint32_t", there is always a none negative value even current value is a negative value obtained from the d-bus. In > https://github.com/openbmc/phosphor-sel-logger/blob/master/include/sensorutils.hpp#L159 > > Is this is an issue or I need to set it up somewhere? If min is < 0, then this should work: https://github.com/openbmc/phosphor-sel-logger/blob/6afe9560852c6431c43c8e79a28e2b7cb498e355/include/sensorutils.hpp#L61 https://github.com/openbmc/phosphor-dbus-interfaces/blob/12162be363f11b9dafa92b5379db671712b3523c/xyz/openbmc_project/Sensor/Value.interface.yaml#L28 It uses MinValue < 0 to determine if the sensor is signed or not. Thanks, -James > > Thanks > Best Regards, > Tony >