From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D29DAECAAD4 for ; Fri, 26 Aug 2022 15:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MOtWtmaDFMIySeLE9Js113f5P0+EXoCQS1R6JsEcSbQ=; b=yRnbknMqoM7AAx6stQhHNMUNXX AVLY/0ETDj5Epd4J0573L8U+QKwCPcEcapDZQkzZyAixjgpjJemwto7z1cW/TB+Dxhh7CKKVme00N rbo83dLOSy/2/Qd3GU1uU9PYDUmi/XLJfU6+NKsZ0SIMbaw1Ec/wM+4dULl/NySMis0c+IZjw6+m+ boshnlvVOtOmiv2RcpZQ6A9yJE+l942elTEFJGZtqHLpPN5iimKO9JrFYwsh8m/ANmGXryJcCaqbV IJaAhggUZxEOIDRsB2SM6Zpk48rQRCgoxdIL+jpciWTMEJ5t/hvVPNF4ktE1S2nUBVr5r1Wy2zvpn teMy8IBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRbRE-0076So-T8; Fri, 26 Aug 2022 15:40:04 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRbR2-0076CM-Hq; Fri, 26 Aug 2022 15:39:54 +0000 Received: by mail-wm1-x32d.google.com with SMTP id ay39-20020a05600c1e2700b003a5503a80cfso1054314wmb.2; Fri, 26 Aug 2022 08:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=MOtWtmaDFMIySeLE9Js113f5P0+EXoCQS1R6JsEcSbQ=; b=gZtzZqqAQtgWdXborkrmVTMGKMSHVjEIEnLiJkdCqn3zzJqPr8bPJULbLqZ8ikl37a +7HTYejc+nHXOManj2mYNhzvqnN3XYmD3P8KC6J/SB0VWIIppXEUqAoSmT1LaFtf/fSO PvutQ61YcBLdm4XjGIQxCa921kUpR9xrz2BhkCYY3NwCB1ZJDnPDuFvhkccxagn63c5y ybim+hig6TobRv8l5JL8mQcB2lW7F5fvKwMiAej6Px7gJ+ympkCIpyVEyYDQvYF5Au6H 3nKOUg6EwbjYmKT+pyrY8TWT2fZedIFapE3Px4lJ8QbBdzAcXZPWFMoug+/CVrnBsnzV a0TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=MOtWtmaDFMIySeLE9Js113f5P0+EXoCQS1R6JsEcSbQ=; b=j6sWfNKgZw6ZbnKdP2bGIwkFVpmbm7UHovDX/X6VegkVuoXeJ4mdkbARdRBV5FK0/z sIVp+AV9D0abRvuCY7SqwFZJ7Qy4wUamKg1XSO9CNohVniEK0Tl1pJ80lrzLJQsGO27l vP6THRHhKf5Rbue0qVokLAtGTGFPw6hsM5egAIQA/JWRZGcFrPQglxo8DT/5dlFYwRQY kcWruGQsIzKB2XOzj1KgF2yW4wpqdIZCPGyiYUV/EJiqQR9ZK/YA0Aw9FjggDjuug3VX 6PbT1AbQbHj9QD3ACfVpQxodKut8MfGauEpXELO8n77pRVPBsuVzojNF0zSpdP3K4IyM q0RA== X-Gm-Message-State: ACgBeo2BuoVQWJ7gZvQlYfS9y1exRoVjLr2ySiyqHkAG3hC2EeFH2PYp 2QftVsFF5t5bGmOwkYaCKi8= X-Google-Smtp-Source: AA6agR5AoXPkL721SdanPx83BCkCCPrUSRFNojtDVoeIavHfGdwo4ztYoyqHkgG0kLOwPtD5BNFJ6w== X-Received: by 2002:a7b:ce11:0:b0:3a6:1e4d:8d7b with SMTP id m17-20020a7bce11000000b003a61e4d8d7bmr35044wmc.101.1661528389951; Fri, 26 Aug 2022 08:39:49 -0700 (PDT) Received: from [192.168.1.130] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id j18-20020a05600c191200b003a5c1e916c8sm17667866wmq.1.2022.08.26.08.39.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 08:39:48 -0700 (PDT) Message-ID: Date: Fri, 26 Aug 2022 17:39:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH v2] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195 Content-Language: en-US To: Bo-Chen Chen , Krzysztof Kozlowski , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "chunkuang.hu@kernel.org" , "angelogioacchino.delregno@collabora.com" , "hsinyi@google.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group References: <20220825091448.14008-1-rex-bc.chen@mediatek.com> <3ed3d73a-1671-708e-7c42-498cca6aaf1d@gmail.com> <8f3dba943170361211d9bb4c8bf1be12bbfdec20.camel@mediatek.com> <916bd99bcc4fa77eae5734b22365ce73acd90d58.camel@mediatek.com> From: Matthias Brugger In-Reply-To: <916bd99bcc4fa77eae5734b22365ce73acd90d58.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220826_083952_644484_883F1139 X-CRM114-Status: GOOD ( 29.23 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 26/08/2022 09:13, Bo-Chen Chen wrote: > On Fri, 2022-08-26 at 15:00 +0800, Krzysztof Kozlowski wrote: >> On 26/08/2022 05:07, Bo-Chen Chen wrote: >>> On Thu, 2022-08-25 at 22:57 +0800, Matthias Brugger wrote: >>>> >>>> On 25/08/2022 11:14, Bo-Chen Chen wrote: >>>>> From: "Jason-JH.Lin" >>>>> >>>>> For previous MediaTek SoCs, such as MT8173, there are 2 display >>>>> HW >>>>> pipelines binding to 1 mmsys with the same power domain, the >>>>> same >>>>> clock driver and the same mediatek-drm driver. >>>>> >>>>> For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines >>>>> binding >>>>> to >>>>> 2 different power domains, different clock drivers and >>>>> different >>>>> mediatek-drm drivers. >>>>> >>>>> Moreover, Hardware pipeline of VDOSYS0 has these components: >>>>> COLOR, >>>>> CCORR, AAL, GAMMA, DITHER. They are related to the PQ (Picture >>>>> Quality) >>>>> and they makes VDOSYS0 supports PQ function while they are not >>>>> including in VDOSYS1. >>>>> >>>>> Hardware pipeline of VDOSYS1 has the component ETHDR (HDR >>>>> related >>>>> component). It makes VDOSYS1 supports the HDR function while >>>>> it's >>>>> not >>>>> including in VDOSYS0. >>>>> >>>>> To summarize0: >>>>> Only VDOSYS0 can support PQ adjustment. >>>>> Only VDOSYS1 can support HDR adjustment. >>>>> >>>>> Therefore, we need to separate these two different mmsys >>>>> hardwares >>>>> to >>>>> 2 different compatibles for MT8195. >>>>> >>>>> Fixes: 81c5a41d10b9 ("dt-bindings: arm: mediatek: mmsys: add >>>>> mt8195 >>>>> SoC binding") >>>>> Signed-off-by: Jason-JH.Lin >>>>> Signed-off-by: Bo-Chen Chen >>>>> --- >>>>> Changes for v2: >>>>> 1. Add hardware difference for VDOSYS0 and VDOSYS1 in commit >>>>> message. >>>>> --- >>>>> >>>>> .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml >>>>> | >>>>> 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >>>>> .yam >>>>> l >>>>> b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >>>>> .yam >>>>> l >>>>> index 6ad023eec193..bfbdd30d2092 100644 >>>>> --- >>>>> a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >>>>> .yam >>>>> l >>>>> +++ >>>>> b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >>>>> .yam >>>>> l >>>>> @@ -31,7 +31,8 @@ properties: >>>>> - mediatek,mt8183-mmsys >>>>> - mediatek,mt8186-mmsys >>>>> - mediatek,mt8192-mmsys >>>>> - - mediatek,mt8195-mmsys >>>>> + - mediatek,mt8195-vdosys0 >>>> >>>> Thanks for you patch. As I mentioned on v1, I propose to set >>>> mediatek,mt8195-mmsys as fallback for mediatek,mt8195-vdosys0 to >>>> not >>>> break >>>> backwards compatibility. >>>> >>>> Apart from that, the binding change will need some changes to >>>> support >>>> the new >>>> binding. Please provide these together with this patch. >>>> >>>> Regards, >>>> Matthias >>>> >>> >>> Hello Matthias, >>> >>> Thanks for your comments. >>> The purpose of this patch is to confirm we can separate mt8195 >>> mmsys >>> into two compatibles. I think this modification is accepted. >> >> No, it is not accepted following Matthias comments. You received my >> ack >> based on assumption that ABI break is perfectly ok for platform >> maintainer, as he has decisive voice. If anyone is not happy with a >> ABI >> break, then his concerns must be addressed. >> >> So let it be specific: >> NAK. >> >>> >>> After this, I think Jason-JH will push another series with this >>> binding >>> patch. >> >> I don't know what do you mean here - another series on top of wrong >> patch? >> > > Hello Krzysztof, > > For this mt8195 mmsys binding separation, we still need to modify > driver for this. The reason I send this patch is to confirm we can do > this binding modification and I also think we can not pick this patch > here. > > We will push another series and it contains modification of binding and > drivers. (The series will push by Jason-JH Lin) > Sounds good. So lets wait for Jason-JH Lin to send this series and we can go on with the review. Thanks! Matthias > Maybe I should use "RFC" for this series, and I think it's more > correct. > > BRs, > Bo-Chen > >>> In Jason-JH's series, we will modify mmsys driver based on this. >>> And I think we don't need to keep "mediatek,mt8195-mmsys" if we >>> also >>> modify mmsys drivers in the same series. >> >> This does not fux ABI break and broken bisectability. >> >>> >>> Is it ok that postpones to pick this patch until we finish review >>> follow-up series? >>> >> >> No. You got a clear review to fix. >> >> Best regards, >> Krzysztof > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDE6DECAAA3 for ; Fri, 26 Aug 2022 15:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a8l0bC3NR7R6si1vrhPjP3S3C8KaTwXUNIKIIC+AtUw=; b=kM7SyeNkEuOZuJ ioMamDJ8vol3RNw2dDScI7FV/FB7sDvihA5GkHZ6EqcdkHl+qydd//wtqaWHXvxl+CJ8SZY4EipN8 w836hqEFmkCEYR12njY+cGnNu3i36wWSGsQbRf5kXQi8zVpltstR+3fm6SUieOCvqWzZufEuI5AVN zXkJWsVvGgqoiY0owKdwQL5v1Dx2I8hD6m026mykGnEv6XJsLV5d6pceBURdYP2JqgTgFRx5yVDvm VthpwBNtRHOOLxBPJSvLN5A5WKon4Vd94stVVi3rU9qXS++uaoaV31/GfacJsas4Ng/jMPRmckOpT uyjJB0cRNthfzsVeRUow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRbR6-0076LH-AJ; Fri, 26 Aug 2022 15:39:56 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRbR2-0076CM-Hq; Fri, 26 Aug 2022 15:39:54 +0000 Received: by mail-wm1-x32d.google.com with SMTP id ay39-20020a05600c1e2700b003a5503a80cfso1054314wmb.2; Fri, 26 Aug 2022 08:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=MOtWtmaDFMIySeLE9Js113f5P0+EXoCQS1R6JsEcSbQ=; b=gZtzZqqAQtgWdXborkrmVTMGKMSHVjEIEnLiJkdCqn3zzJqPr8bPJULbLqZ8ikl37a +7HTYejc+nHXOManj2mYNhzvqnN3XYmD3P8KC6J/SB0VWIIppXEUqAoSmT1LaFtf/fSO PvutQ61YcBLdm4XjGIQxCa921kUpR9xrz2BhkCYY3NwCB1ZJDnPDuFvhkccxagn63c5y ybim+hig6TobRv8l5JL8mQcB2lW7F5fvKwMiAej6Px7gJ+ympkCIpyVEyYDQvYF5Au6H 3nKOUg6EwbjYmKT+pyrY8TWT2fZedIFapE3Px4lJ8QbBdzAcXZPWFMoug+/CVrnBsnzV a0TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=MOtWtmaDFMIySeLE9Js113f5P0+EXoCQS1R6JsEcSbQ=; b=j6sWfNKgZw6ZbnKdP2bGIwkFVpmbm7UHovDX/X6VegkVuoXeJ4mdkbARdRBV5FK0/z sIVp+AV9D0abRvuCY7SqwFZJ7Qy4wUamKg1XSO9CNohVniEK0Tl1pJ80lrzLJQsGO27l vP6THRHhKf5Rbue0qVokLAtGTGFPw6hsM5egAIQA/JWRZGcFrPQglxo8DT/5dlFYwRQY kcWruGQsIzKB2XOzj1KgF2yW4wpqdIZCPGyiYUV/EJiqQR9ZK/YA0Aw9FjggDjuug3VX 6PbT1AbQbHj9QD3ACfVpQxodKut8MfGauEpXELO8n77pRVPBsuVzojNF0zSpdP3K4IyM q0RA== X-Gm-Message-State: ACgBeo2BuoVQWJ7gZvQlYfS9y1exRoVjLr2ySiyqHkAG3hC2EeFH2PYp 2QftVsFF5t5bGmOwkYaCKi8= X-Google-Smtp-Source: AA6agR5AoXPkL721SdanPx83BCkCCPrUSRFNojtDVoeIavHfGdwo4ztYoyqHkgG0kLOwPtD5BNFJ6w== X-Received: by 2002:a7b:ce11:0:b0:3a6:1e4d:8d7b with SMTP id m17-20020a7bce11000000b003a61e4d8d7bmr35044wmc.101.1661528389951; Fri, 26 Aug 2022 08:39:49 -0700 (PDT) Received: from [192.168.1.130] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id j18-20020a05600c191200b003a5c1e916c8sm17667866wmq.1.2022.08.26.08.39.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 08:39:48 -0700 (PDT) Message-ID: Date: Fri, 26 Aug 2022 17:39:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH v2] dt-bindings: arm: mediatek: mmsys: change compatible for MT8195 Content-Language: en-US To: Bo-Chen Chen , Krzysztof Kozlowski , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "chunkuang.hu@kernel.org" , "angelogioacchino.delregno@collabora.com" , "hsinyi@google.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group References: <20220825091448.14008-1-rex-bc.chen@mediatek.com> <3ed3d73a-1671-708e-7c42-498cca6aaf1d@gmail.com> <8f3dba943170361211d9bb4c8bf1be12bbfdec20.camel@mediatek.com> <916bd99bcc4fa77eae5734b22365ce73acd90d58.camel@mediatek.com> From: Matthias Brugger In-Reply-To: <916bd99bcc4fa77eae5734b22365ce73acd90d58.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220826_083952_644484_883F1139 X-CRM114-Status: GOOD ( 29.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/08/2022 09:13, Bo-Chen Chen wrote: > On Fri, 2022-08-26 at 15:00 +0800, Krzysztof Kozlowski wrote: >> On 26/08/2022 05:07, Bo-Chen Chen wrote: >>> On Thu, 2022-08-25 at 22:57 +0800, Matthias Brugger wrote: >>>> >>>> On 25/08/2022 11:14, Bo-Chen Chen wrote: >>>>> From: "Jason-JH.Lin" >>>>> >>>>> For previous MediaTek SoCs, such as MT8173, there are 2 display >>>>> HW >>>>> pipelines binding to 1 mmsys with the same power domain, the >>>>> same >>>>> clock driver and the same mediatek-drm driver. >>>>> >>>>> For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines >>>>> binding >>>>> to >>>>> 2 different power domains, different clock drivers and >>>>> different >>>>> mediatek-drm drivers. >>>>> >>>>> Moreover, Hardware pipeline of VDOSYS0 has these components: >>>>> COLOR, >>>>> CCORR, AAL, GAMMA, DITHER. They are related to the PQ (Picture >>>>> Quality) >>>>> and they makes VDOSYS0 supports PQ function while they are not >>>>> including in VDOSYS1. >>>>> >>>>> Hardware pipeline of VDOSYS1 has the component ETHDR (HDR >>>>> related >>>>> component). It makes VDOSYS1 supports the HDR function while >>>>> it's >>>>> not >>>>> including in VDOSYS0. >>>>> >>>>> To summarize0: >>>>> Only VDOSYS0 can support PQ adjustment. >>>>> Only VDOSYS1 can support HDR adjustment. >>>>> >>>>> Therefore, we need to separate these two different mmsys >>>>> hardwares >>>>> to >>>>> 2 different compatibles for MT8195. >>>>> >>>>> Fixes: 81c5a41d10b9 ("dt-bindings: arm: mediatek: mmsys: add >>>>> mt8195 >>>>> SoC binding") >>>>> Signed-off-by: Jason-JH.Lin >>>>> Signed-off-by: Bo-Chen Chen >>>>> --- >>>>> Changes for v2: >>>>> 1. Add hardware difference for VDOSYS0 and VDOSYS1 in commit >>>>> message. >>>>> --- >>>>> >>>>> .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml >>>>> | >>>>> 3 ++- >>>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git >>>>> a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >>>>> .yam >>>>> l >>>>> b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >>>>> .yam >>>>> l >>>>> index 6ad023eec193..bfbdd30d2092 100644 >>>>> --- >>>>> a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >>>>> .yam >>>>> l >>>>> +++ >>>>> b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys >>>>> .yam >>>>> l >>>>> @@ -31,7 +31,8 @@ properties: >>>>> - mediatek,mt8183-mmsys >>>>> - mediatek,mt8186-mmsys >>>>> - mediatek,mt8192-mmsys >>>>> - - mediatek,mt8195-mmsys >>>>> + - mediatek,mt8195-vdosys0 >>>> >>>> Thanks for you patch. As I mentioned on v1, I propose to set >>>> mediatek,mt8195-mmsys as fallback for mediatek,mt8195-vdosys0 to >>>> not >>>> break >>>> backwards compatibility. >>>> >>>> Apart from that, the binding change will need some changes to >>>> support >>>> the new >>>> binding. Please provide these together with this patch. >>>> >>>> Regards, >>>> Matthias >>>> >>> >>> Hello Matthias, >>> >>> Thanks for your comments. >>> The purpose of this patch is to confirm we can separate mt8195 >>> mmsys >>> into two compatibles. I think this modification is accepted. >> >> No, it is not accepted following Matthias comments. You received my >> ack >> based on assumption that ABI break is perfectly ok for platform >> maintainer, as he has decisive voice. If anyone is not happy with a >> ABI >> break, then his concerns must be addressed. >> >> So let it be specific: >> NAK. >> >>> >>> After this, I think Jason-JH will push another series with this >>> binding >>> patch. >> >> I don't know what do you mean here - another series on top of wrong >> patch? >> > > Hello Krzysztof, > > For this mt8195 mmsys binding separation, we still need to modify > driver for this. The reason I send this patch is to confirm we can do > this binding modification and I also think we can not pick this patch > here. > > We will push another series and it contains modification of binding and > drivers. (The series will push by Jason-JH Lin) > Sounds good. So lets wait for Jason-JH Lin to send this series and we can go on with the review. Thanks! Matthias > Maybe I should use "RFC" for this series, and I think it's more > correct. > > BRs, > Bo-Chen > >>> In Jason-JH's series, we will modify mmsys driver based on this. >>> And I think we don't need to keep "mediatek,mt8195-mmsys" if we >>> also >>> modify mmsys drivers in the same series. >> >> This does not fux ABI break and broken bisectability. >> >>> >>> Is it ok that postpones to pick this patch until we finish review >>> follow-up series? >>> >> >> No. You got a clear review to fix. >> >> Best regards, >> Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel