From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: Remove excessively redundant entries from git_difftree_body
Date: Sun, 01 Oct 2006 21:20:26 +0200 [thread overview]
Message-ID: <efp4d6$a7b$1@sea.gmane.org> (raw)
In-Reply-To: 7vmz8k7nhc.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
> Luben Tuikov <ltuikov@yahoo.com> writes:
>
>> 1) All entries on the left are blobs and clicking on them
>> leads to blobs. No more diff or blob depending on what
>> happened (modified or mode changed) to the file -- this goes
>> to the right, in the "link" column.
>>
>> 2) Remove redundant "blob" from the link column on the right.
>> This can now be had by clicking on the entry itself.
>>
>> This reduces and simplifies the code.
>>
>> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
>
> We lost blobdiff from commitdiff page with this patch, which I
> think it probably is a good change. We can say "when we display
> a pathname you can click it to get the blob or tree".
In my opinion it is a bad change. We now have "patch" inner-link
to anchor in commitdiff view, but it's equivalent in commit view
i.e. diff aka blobdiff vanished.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-10-01 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 0:23 [PATCH] gitweb: Remove excessively redundant entries from git_difftree_body Luben Tuikov
2006-09-28 2:07 ` Junio C Hamano
2006-09-28 18:28 ` Luben Tuikov
2006-10-01 19:20 ` Jakub Narebski [this message]
2006-10-02 19:48 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='efp4d6$a7b$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.