All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: start to generate PATH_INFO URLs
Date: Tue, 03 Oct 2006 14:16:05 +0200	[thread overview]
Message-ID: <eftk98$2ii$2@sea.gmane.org> (raw)
In-Reply-To: 20060929221641.GC2871@admingilde.org

Martin Waitz wrote:

> Instead of providing the project as a ?p= parameter it is simply appended
> to the base URI.

I have just modified href() to be able to use it for actions which don't
need the ?p= parameter... and you didn't take into consideration the case
when $params{'project'} is set, but undefined. Undefined params don't get
added, but "unless exists $params{'project'}" in the

        $params{'project'} = $project unless exists $params{'project'};

line prevents of adding 'p' param.

It is important for the project list (and equivalent) views.
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  parent reply	other threads:[~2006-10-03 12:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-29 22:16 [PATCH] gitweb: start to generate PATH_INFO URLs Martin Waitz
2006-09-29 22:30 ` Junio C Hamano
2006-09-30 18:14   ` Martin Waitz
2006-09-30 19:42     ` Junio C Hamano
2006-10-01 21:57       ` Martin Waitz
2006-10-03 12:18         ` Jakub Narebski
2006-10-03 17:39           ` Junio C Hamano
2006-10-03 17:50             ` Jakub Narebski
2006-10-03 20:16               ` Junio C Hamano
2006-10-03 20:28               ` Martin Waitz
2006-10-03 18:07             ` [PATCH] gitweb: warn if feature cannot be overridden Martin Waitz
2006-10-03 16:43   ` [PATCH] gitweb: start to generate PATH_INFO URLs Jakub Narebski
2006-10-03 18:08     ` [PATCH] gitweb: make PATHINFO URL generation conditional on input URL Martin Waitz
2006-10-06 15:30   ` [PATCH] gitweb: start to generate PATH_INFO URLs Petr Baudis
2006-10-07  8:40     ` Junio C Hamano
2006-10-03 12:16 ` Jakub Narebski [this message]
2006-10-03 17:12   ` Martin Waitz
2006-10-03 17:19     ` Jakub Narebski
2006-10-03 17:36     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='eftk98$2ii$2@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.