From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: make leftmost column of blame less cluttered.
Date: Wed, 04 Oct 2006 05:07:12 +0200 [thread overview]
Message-ID: <efv8fv$dvn$1@sea.gmane.org> (raw)
In-Reply-To: 20061004024837.4462.qmail@web31808.mail.mud.yahoo.com
Luben Tuikov wrote:
> --- Junio C Hamano <junkio@cox.net> wrote:
>> > I like the fact that the "data part" of blame is text, and
>> > that the commit-8 is on the left, and color-chunked. Sometimes
>> > people simply _remember_ a number of commit-8's and thus the
>> > layout of blame is intentional, since they can look to the left
>> > and recognize a commit-8...
>>
>> It is not only the initial commit. A substantial rewrite and
>> new development also has the same issue.
>>
>> I think you are also contradicting yourself by saying that
>> people would recognize a commit-8, and at the same time you do
>> not like the chunk code that makes sure you do not get too few
>> of them. If people _do_ recognize commit-8 (I seriously doubt
>> that), then wouldn't it help to make sure you have them on every
>> couple-dozen lines so that the user would see the familiar one
>> even when scrolled?
>
> It is not that I don't like it. For example if we didn't have
> the block-per-commit-coloring, then we'd make use of this, but it
> seems that the block-per-commit-coloring exists for the purpose to
> show conglomerations of same-commit lines, thus obviating the need
> to repeat it (commit-8) every so many lines.
Colors repeat. They are not enough.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-10-04 3:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 9:19 [PATCH] gitweb: make leftmost column of blame less cluttered Junio C Hamano
2006-10-02 19:29 ` Luben Tuikov
2006-10-03 4:19 ` Junio C Hamano
2006-10-03 7:25 ` Junio C Hamano
2006-10-03 19:08 ` Luben Tuikov
2006-10-03 19:20 ` Martin Waitz
2006-10-03 19:45 ` Luben Tuikov
2006-10-04 2:26 ` Junio C Hamano
2006-10-04 2:48 ` Luben Tuikov
2006-10-04 3:07 ` Jakub Narebski [this message]
2006-10-04 8:12 ` Junio C Hamano
2006-10-04 15:59 ` Luben Tuikov
2006-10-05 1:03 ` Junio C Hamano
2006-10-05 1:11 ` Luben Tuikov
2006-10-03 19:01 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='efv8fv$dvn$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.