From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit
Date: Sat, 07 Oct 2006 12:00:29 +0200 [thread overview]
Message-ID: <eg7tqd$lie$1@sea.gmane.org> (raw)
In-Reply-To: 7vmz88ziwv.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
> Petr Baudis <pasky@suse.cz> writes:
>
>> There's no reason for that, the commitdiff view is meaningful for the
>> root commit as well and we link to it everywhere else.
>
> It probably is not any more useful than the blob view but I
> agree there is no strong reason to supress it, as long as the
> commitdiff page is prepared to show the root commit (which I
> haven't checked -- if you have --root you should be Ok).
The commitdiff for root commit is much less useful, I think, and not having
commitdiff link serves as indicator of root (parentless) commit, important
in non-commit views.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-10-07 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 16:59 [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit Petr Baudis
2006-10-06 20:57 ` Jakub Narebski
2006-10-07 7:25 ` Junio C Hamano
2006-10-07 10:00 ` Jakub Narebski [this message]
2006-10-07 12:33 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eg7tqd$lie$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.