All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 2/2] gitweb: Show trailing slash when listing tree entry in tree listing
Date: Sat, 07 Oct 2006 21:06:25 +0200	[thread overview]
Message-ID: <eg8tpu$drj$1@sea.gmane.org> (raw)
In-Reply-To: 20061007184418.64881.qmail@web31812.mail.mud.yahoo.com

Luben Tuikov wrote:

> --- Petr Baudis <pasky@suse.cz> wrote:
>> +                          esc_html($t->{'name'} . '/'));
> 
> First, this is a Unixism, and would confuse other OS users.
But AFAIK _Git_ uses it, in output and in index.

> Second, "/" is after all _not part of the name_ of the tree/directory,
> but part of the filesystem's path separator, let's not export it
> to users of other OS's.
> Third, directories/trees are already clearly 
>   1) underlined, and
>   2) differently colored,
> which makes it overly obvious what it what.
> 
> In fact, my eyes only scan for the different color/underlined
> entries when I'm searching for a directory in tree view.  I don't even
> look at the left-most column.
> 
> NACK!

I'd rather like it.


More important though would be to add better support for symlinks,
perhaps in the UNIX form

        symlink -> _target_

Whete _text_ denotes link.

By the way, I miss somewhat the "redundant" tree/blob links in tree
view...
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  reply	other threads:[~2006-10-07 19:06 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-05 19:22 [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view Luben Tuikov
2006-10-06  7:44 ` Jakub Narebski
2006-10-06 16:35   ` Petr Baudis
2006-10-06 22:16   ` Luben Tuikov
2006-10-07 13:24     ` Petr Baudis
2006-10-07 14:05       ` Jakub Narebski
2006-10-07 14:17         ` Petr Baudis
2006-10-07 14:10       ` [PATCH 1/2] gitweb: Show snapshot links for tree entries in tree listing Petr Baudis
2006-10-07 18:37         ` Luben Tuikov
2006-10-07 18:41           ` Petr Baudis
2006-10-07 18:52             ` Luben Tuikov
2006-10-07 19:15               ` Petr Baudis
2006-10-07 22:31                 ` Junio C Hamano
2006-10-08  1:04                 ` Luben Tuikov
2006-10-07 14:10       ` [PATCH 2/2] gitweb: Show trailing slash when listing tree entry " Petr Baudis
2006-10-07 18:44         ` Luben Tuikov
2006-10-07 19:06           ` Jakub Narebski [this message]
2006-10-07 19:12             ` Petr Baudis
2006-10-07 20:38               ` Jakub Narebski
2006-10-07 21:15                 ` Petr Baudis
2006-10-07 21:27                   ` Jakub Narebski
2006-10-09 20:55               ` Petr Baudis
2006-10-09 22:52                 ` Junio C Hamano
2006-10-10  5:10                   ` Junio C Hamano
2006-10-10  5:38                     ` Luben Tuikov
2006-10-10  5:46                       ` Junio C Hamano
2006-10-10  6:34                         ` Luben Tuikov
2006-10-10  5:46                       ` Jeff King
2006-10-10  6:41                         ` Luben Tuikov
2006-10-10  6:58                           ` Jeff King
2006-10-10  9:15                       ` Jakub Narebski
2006-10-10 19:19                         ` Luben Tuikov
2006-10-10 19:57                           ` Junio C Hamano
2006-10-10 20:31                             ` Jakub Narebski
2006-10-10 21:02                               ` Luben Tuikov
2006-10-10 21:13                                 ` Jakub Narebski
2006-10-10 22:18                                   ` Luben Tuikov
2006-10-10 20:52                             ` Luben Tuikov
2006-10-10 21:00                               ` Jakub Narebski
2006-10-10 22:14                                 ` Luben Tuikov
2006-10-10 22:40                                   ` Jakub Narebski
2006-10-10 20:29                           ` Jakub Narebski
2006-10-11 15:35                           ` Andreas Ericsson
2006-10-10  6:21                 ` Luben Tuikov
2006-10-10  7:05                   ` Jeff King
2006-10-10  8:07                     ` Andreas Ericsson
2006-10-10 13:14                       ` Josef Weidendorfer
2006-10-10 18:23                         ` Luben Tuikov
2006-10-10 18:52                           ` Josef Weidendorfer
2006-10-10 18:50                         ` Luben Tuikov
2006-10-10  8:28                     ` Junio C Hamano
2006-10-07 21:31           ` A Large Angry SCM
2006-10-07 22:34           ` Junio C Hamano
2006-10-08  1:16             ` Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='eg8tpu$drj$1@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.