From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: Question about commit message conventions
Date: Tue, 24 Oct 2006 16:08:02 +0200 [thread overview]
Message-ID: <ehl6n6$6jn$1@sea.gmane.org> (raw)
In-Reply-To: 200610241549.48238.t.toedter@gmx.net
Tobias Toedter wrote:
> Hi,
>
> although I've read the documentation of git very carefully, I could not find
> anything related to certain commit message conventions. It would be great
> if someone here could explain a few things, maybe this could be added to
> the wiki afterwards (<http://git.or.cz/gitwiki/CommitMessageConventions>).
>
> First of all, what's the intended use of the "Signed-off-by:" lines? Does it
> make sense to add my name there, even when I'm listed as the author or
> committer of a commit? I thought that they are intended mostly to note the
> approval of other developers.
>
> On the other hand, concerning the approval of other developers, what's the
> difference between "Signed-off-by:" and "Acked-by:"? Are there any
> more "*-by:" fields that are in use?
>From Documentation/SubmittingPatches:
(6) Sign your work
[...]
The sign-off is a simple line at the end of the explanation for
the patch, which certifies that you wrote it or otherwise have
the right to pass it on as a open-source patch.
"Acked-by:" is used to notify that patch was accepted by somebody,
which usually is maintainer of part affected by patch.
I have seen exactly on "Cheered-on-by:", and there are probably some
"Noticed-by:" there.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-10-24 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 13:49 Question about commit message conventions Tobias Toedter
2006-10-24 14:08 ` Jakub Narebski [this message]
2006-10-24 14:14 ` Tobias Toedter
2006-10-24 14:08 ` Erik Mouw
2006-10-25 15:23 ` Andreas Ericsson
2006-10-25 18:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ehl6n6$6jn$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.