From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: git_get_projects_list and $projects_list
Date: Tue, 31 Oct 2006 12:59:11 +0100 [thread overview]
Message-ID: <ei7dq4$828$1@sea.gmane.org> (raw)
In-Reply-To: cc723f590610310347h58cdd69bse6d96b19479a4f6a@mail.gmail.com
Aneesh Kumar wrote:
> Ok if i have
>
> $projects_list = "/a/git////" ==> ending "/" . the function will fail
> at check_export_ok()
>
> That is because we get the $pfxlen wrong. We should ignore all the trailing "/"
> my $subdir = substr($File::Find::name, $pfxlen + 1);
Perhaps it would be enough to just add
$dir =~ s!/+$//;
before
my $pfxlen = length("$dir");
(or something equivalent). Try it and send us a patch.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-10-31 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 11:47 git_get_projects_list and $projects_list Aneesh Kumar
2006-10-31 11:59 ` Jakub Narebski [this message]
2006-10-31 12:23 ` Jakub Narebski
2006-11-02 4:13 ` Aneesh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ei7dq4$828$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.