All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] git-add: warn when adding an ignored file with an explicit request.
Date: Mon, 25 Dec 2006 23:24:30 +0100	[thread overview]
Message-ID: <empitl$t6p$1@sea.gmane.org> (raw)
In-Reply-To: 7vodprizuw.fsf_-_@assigned-by-dhcp.cox.net

Junio C Hamano wrote:

> We allow otherwise ignored paths to be added to the index by
> spelling its path out on the command line, but we would warn the
> user about them when we do so.

I'm for warning user that the file to be added is ignored file and
telling how to make an exception in .gitignore _AND_ that -f option
can be used to bypass that check. And adding ignored path as above
with -f option.

But otherwise: nice series of patches.

P.S. Were all the patches sent as replies to introductory letter?
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  reply	other threads:[~2006-12-25 22:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-25 11:13 [PATCH 5/5] git-add: add ignored files when asked explicitly Junio C Hamano
2006-12-25 13:47 ` Johannes Schindelin
2006-12-25 17:27   ` Junio C Hamano
2006-12-25 18:39     ` [PATCH] git-add: warn when adding an ignored file with an explicit request Junio C Hamano
2006-12-25 22:24       ` Jakub Narebski [this message]
2006-12-26 16:19         ` Johannes Schindelin
2006-12-25 19:57     ` [PATCH 5/5] git-add: add ignored files when asked explicitly Nicolas Pitre
2006-12-26 15:34     ` Johannes Schindelin
2006-12-26 19:05       ` Junio C Hamano
2006-12-26 22:48         ` Johannes Schindelin
2007-01-04 13:58     ` Andreas Ericsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='empitl$t6p$1@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.