All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: How to commit removed file?
Date: Fri, 12 Jan 2007 11:42:54 +0100	[thread overview]
Message-ID: <eo7omq$1ap$1@sea.gmane.org> (raw)
In-Reply-To: 877ivtxbt2.wl%cworth@cworth.org

Carl Worth wrote:

> But now that I tried this case with a recent git (2a3a3c247) for which
> git-rm does working-tree removal without -f, I see that it does
> irretrievably destroy information in this case:
> 
>         $ echo "important stuff" > new-file
>         $ git add new-file
>         $ git rm new-file
> 
> This now deletes new-file from the working tree and there's no copy of
> the data inside git. The old git-rm would just return the file to it's
> "untracked" state in this case.
> 
> I had thought the safety check was going to be that the index state
> matched the HEAD state before git-rm would delete from the working
> tree.

That is certainly bug in new git-rm; it should remove file _only_
if it can be recovered with the same state as it was before git-rm. 

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

  reply	other threads:[~2007-01-12 10:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-31 10:24 How to commit removed file? Michael S. Tsirkin
2006-12-31 15:06 ` Johannes Schindelin
2007-01-02 20:10 ` Michael S. Tsirkin
2007-01-02 21:12   ` Johannes Schindelin
2007-01-02 21:40     ` Junio C Hamano
2007-01-02 22:13       ` Jakub Narebski
2007-01-02 22:20       ` Johannes Schindelin
2007-01-03  0:55       ` Carl Worth
2007-01-06  1:57         ` Junio C Hamano
2007-01-12  1:40           ` Carl Worth
2007-01-12 10:42             ` Jakub Narebski [this message]
2007-01-03  6:06       ` Michael S. Tsirkin
2007-01-03  6:51         ` Junio C Hamano
2007-01-03  7:14           ` Junio C Hamano
2007-01-04 17:41             ` Michael S. Tsirkin
2007-01-02 21:49     ` Juergen Ruehle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='eo7omq$1ap$1@sea.gmane.org' \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.