Re: [PATCH v4 2/2] arm64: dts: freescale: add MR-NAVQ95 basic board support

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 9/9/26 5:39 PM, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> 
> Add basic support for NXP's MR-NAVQ95 board. This board is designed for
> robotics applications (e.g. drones, rovers, humanoids, etc..) and has the
> following hardware feats (list is not exhaustive):
> 
> * based on i.MX95 19x19 SoC
> * 64GB eMMC
> * up to 16GB of LPDDR5 memory
> * 1 x USB 2.0 TypeC
> * 1 x USB 3.0 TypeC
> * 1 x RJ45 port with RTL8211 PHY
> 
> The support targets revision B of the board.
> 
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---

> +	chosen {
> +		stdout-path = &lpuart1;

I would recommend instead "serial0:115200n8" here. This introduces no
change for Linux, but for other consumers of the device tree, they will
be able to agree on a common baudrate.

> +	memory@80000000 {
> +		device_type = "memory";
> +		/* actual size filled in by the bootloader */
> +		reg = <0x0 0x80000000 0 0x80000000>;

If the board has at least 2G always, this is fine.

> +&usdhc2 {
> +	bootph-pre-ram;
> +	bus-width = <4>;
> +	cd-gpios = <&gpio3 0 GPIO_ACTIVE_LOW>;
> +	pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> +	pinctrl-1 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> +	pinctrl-2 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> +	pinctrl-3 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> +	pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep";

Looks unexpected to have same pinctrl groups for the higher speeds.
Are higher speed modes even possible on this board?

If not, I would suggest dropping the extra states.

Cheers,
Ahmad

> +	vmmc-supply = <&reg_usdhc2_vmmc>;
> +
> +	status = "okay";
> +};
-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |