From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 970EAC33CB1 for ; Wed, 15 Jan 2020 07:39:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68364222C3 for ; Wed, 15 Jan 2020 07:39:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LHWN/wCZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=dlink.ru header.i=@dlink.ru header.b="Cv7wHqPl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68364222C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=dlink.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vskl+SDlBFAQF0qiKkBPRI19fYe13xq0b2FgCbkt/+M=; b=LHWN/wCZL0ObYFDG8hYsnsPOj 8zUMepOUxWZStCH/QFQDH4XBvxagk11VMWB05mooagHdIMJKgGvXrjz/z8aEO43kmXu/hi7Kds1mw AcFiXVD7LfDfqKEobeGreWdfc8LH5SQYqkDkpycp0ajf5NQ89880bLFjkZwXViwB44Fd+y1RMLahJ ZwIKjRE9gZacikIX5zAxvKn1MTU5mQ84HodszZGY5y1TmF5VMBVlFTBq5VSeWazN105TL8P2SMqxC 0ugq9vF45Ho2sX9eI4qHEo90BuMkPwzOTZWj29CX18url2xgghcOwE+hn1dlxmRnFVliJbPG1fpcA wIvITinzg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irdGG-000852-DQ; Wed, 15 Jan 2020 07:38:44 +0000 Received: from mail.dlink.ru ([178.170.168.18] helo=fd.dlink.ru) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irdG1-0007wp-Lx; Wed, 15 Jan 2020 07:38:34 +0000 Received: by fd.dlink.ru (Postfix, from userid 5000) id 444801B20857; Wed, 15 Jan 2020 10:38:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 fd.dlink.ru 444801B20857 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dlink.ru; s=mail; t=1579073908; bh=CxEiSPavtIlJWlMwr6AuhfGibqHNMwLCY9kUK5W5q30=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Cv7wHqPl+qAWKunjxq0HVohvH8s53UaBFABoCjAulPPLJMqFJG7beeKbMhXE/H6be n0Ooygzk2gUgMhvTzO1u983m4Pnyr2CZtDtnuMoD93BD3x7UuE0zCErcaK3Ilpzc8k vllgAZBKuZDXVehg1W6XgS7DdYy25158dtcMywxo= Received: from mail.rzn.dlink.ru (mail.rzn.dlink.ru [178.170.168.13]) by fd.dlink.ru (Postfix) with ESMTP id 257691B20968; Wed, 15 Jan 2020 10:38:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 fd.dlink.ru 257691B20968 Received: from mail.rzn.dlink.ru (localhost [127.0.0.1]) by mail.rzn.dlink.ru (Postfix) with ESMTP id 243EB1B21422; Wed, 15 Jan 2020 10:38:20 +0300 (MSK) Received: from mail.rzn.dlink.ru (localhost [127.0.0.1]) by mail.rzn.dlink.ru (Postfix) with ESMTPA; Wed, 15 Jan 2020 10:38:20 +0300 (MSK) MIME-Version: 1.0 Date: Wed, 15 Jan 2020 10:38:19 +0300 From: Alexander Lobakin To: Florian Fainelli Subject: Re: [PATCH RFC net-next 05/19] net: dsa: tag_ar9331: add GRO callbacks In-Reply-To: <129bf2bc-c0e9-02a3-7d40-0f7920803769@gmail.com> References: <20191230143028.27313-1-alobakin@dlink.ru> <20191230143028.27313-6-alobakin@dlink.ru> <0002a7388dfd5fb70db4b43a6c521c52@dlink.ru> <129bf2bc-c0e9-02a3-7d40-0f7920803769@gmail.com> User-Agent: Roundcube Webmail/1.4.0 Message-ID: X-Sender: alobakin@dlink.ru X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200114_233830_102477_497201DB X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Song Liu , Jakub Kicinski , Yoshiki Komachi , lkml , Eric Dumazet , Stanislav Fomichev , Matteo Croce , Edward Cree , Jakub Sitnicki , Daniel Borkmann , Paolo Abeni , Vivien Didelot , Hauke Mehrtens , Sean Wang , Jiri Pirko , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , netdev , Paul Blakey , Stephen Hemminger , Vladimir Oltean , "David S. Miller" , Taehee Yoo Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org RmxvcmlhbiBGYWluZWxsaSB3cm90ZSAxNS4wMS4yMDIwIDAwOjU2Ogo+IE9uIDEvMTMvMjAgMjoy OCBBTSwgVmxhZGltaXIgT2x0ZWFuIHdyb3RlOgo+PiBPbiBNb24sIDEzIEphbiAyMDIwIGF0IDEx OjQ2LCBBbGV4YW5kZXIgTG9iYWtpbiA8YWxvYmFraW5AZGxpbmsucnU+IAo+PiB3cm90ZToKPj4+ IAo+Pj4gVmxhZGltaXIgT2x0ZWFuIHdyb3RlIDEzLjAxLjIwMjAgMTI6NDI6Cj4+Pj4gSGkgQWxl eGFuZGVyLAo+Pj4+IAo+Pj4+IE9uIE1vbiwgMTMgSmFuIDIwMjAgYXQgMTE6MjIsIEFsZXhhbmRl ciBMb2Jha2luIDxhbG9iYWtpbkBkbGluay5ydT4KPj4+PiB3cm90ZToKPj4+Pj4gCj4+Pj4+IENQ VSBwb3J0cyBjYW4ndCBiZSBicmlkZ2VkIGFueXdheQo+Pj4+PiAKPj4+Pj4gUmVnYXJkcywKPj4+ Pj4g4Zq3IOGbliDhmqIg4ZqmIOGaoCDhmrEKPj4+PiAKPj4+PiBUaGUgZmFjdCB0aGF0IENQVSBw b3J0cyBjYW4ndCBiZSBicmlkZ2VkIGlzIGFscmVhZHkgbm90IGlkZWFsLgo+Pj4+IE9uZSBjYW4g aGF2ZSBhIERTQSBzd2l0Y2ggd2l0aCBjYXNjYWRlZCBzd2l0Y2hlcyBvbiBlYWNoIHBvcnQsIHNv IGl0Cj4+Pj4gYWN0cyBsaWtlIE4gRFNBIG1hc3RlcnMgKG5vdCBhcyBEU0EgbGlua3MsIHNpbmNl IHRoZSB0YWdnZXJzIGFyZQo+Pj4+IGluY29tcGF0aWJsZSksIHdpdGggZWFjaCBzd2l0Y2ggZm9y bWluZyBpdHMgb3duIHRyZWUuIEl0IGlzIAo+Pj4+IGRlc2lyYWJsZQo+Pj4+IHRoYXQgdGhlIHBv cnRzIG9mIHRoZSBEU0Egc3dpdGNoIG9uIHRvcCBhcmUgYnJpZGdlZCwgc28gdGhhdAo+Pj4+IGZv cndhcmRpbmcgYmV0d2VlbiBjYXNjYWRlZCBzd2l0Y2hlcyBkb2VzIG5vdCBwYXNzIHRocm91Z2gg dGhlIENQVS4KPj4+IAo+Pj4gT2gsIEkgc2VlLiBCdXQgY3VycmVudGx5IERTQSBpbmZyYSBmb3Ji aWRzIHRoZSBhZGRpbmcgRFNBIG1hc3RlcnMgdG8KPj4+IGJyaWRnZXMgSUlSQy4gQ2FuJ3QgbmFt ZSBpdCBnb29kIG9yIGJhZCBkZWNpc2lvbiwgYnV0IHdhcyBpbnRyb2R1Y2VkCj4+PiB0byBwcmV2 ZW50IGFjY2lkZW50YWwgcGFja2V0IGZsb3cgYnJlYWtpbmcgb24gRFNBIHNldHVwcy4KPj4+IAo+ PiAKPj4gSSBqdXN0IHdhbnRlZCB0byBwb2ludCBvdXQgdGhhdCBzb21lIHBlb3BsZSBhcmUgZ29p bmcgdG8gYmUgbG9va2luZyBhdAo+PiB3YXlzIGJ5IHdoaWNoIHRoZSBFVEhfUF9YRFNBIGhhbmRs ZXIgY2FuIGJlIG1hZGUgdG8gcGxheSBuaWNlIHdpdGggdGhlCj4+IG1hc3RlcidzIHJ4X2hhbmRs ZXIsIGFuZCB0aGF0IGl0IHdvdWxkIGJlIG5pY2UgdG8gYXQgbGVhc3Qgbm90IG1ha2UKPj4gdGhl IGxpbWl0YXRpb24gd29yc2UgdGhhbiBpdCBpcyBieSBjb252ZXJ0aW5nIGV2ZXJ5dGhpbmcgdG8K Pj4gcnhfaGFuZGxlcnMgKHdoaWNoICJjdXJyZW50bHkiIGNhbid0IGJlIHN0YWNrZWQsIGZyb20g dGhlIGNvbW1lbnRzIGluCj4+IG5ldGRldmljZS5oKS4KPiAKPiBJIGFtIG5vdCBzdXJlIHRoaXMg d291bGQgY2hhbmdlIHRoZSBzaXR1YXRpb24gbXVjaCwgdG9kYXkgd2UgY2Fubm90IAo+IGhhdmUK PiBhbnl0aGluZyBidXQgc3dpdGNoIHRhZ3MgdHJhdmVsIG9uIHRoZSBEU0EgbWFzdGVyIG5ldHdv cmsgZGV2aWNlLAo+IHdoZXRoZXIgd2UgYWNjb21wbGlzaCB0aGUgUlggdGFwIHRocm91Z2ggYSBz cGVjaWFsIHNrYi0+cHJvdG9jb2wgdmFsdWUKPiBvciB2aWEgcnhfaGFuZGxlciwgaXQgcHJvYmFi bHkgZG9lcyBub3QgZnVuY3Rpb25hbGx5IG1hdHRlciwgYnV0IGl0Cj4gY291bGQgY2hhbmdlIHRo ZSBwZXJmb3JtYW5jZS4KCkFzIGZvciBub3csIEkgdGhpbmsgdGhhdCB3ZSBzaG91bGQga2VlcCB0 aGlzIFJGQyBhcyBpdCBpcyBzbwpkZXZlbG9wZXJzIHdvcmtpbmcgd2l0aCBkaWZmZXJlbnQgRFNB IHN3aXRjaGVzIGNvdWxkIHRlc3QgaXQgb3IKaW1wbGVtZW50IEdSTyBvZmZsb2FkIGZvciBvdGhl ciB0YWdnZXJzIGxpa2UgRFNBIGFuZCBFRFNBLCAqYnV0KgphbnkgZnV0dXJlIHdvcmsgb24gdGhp cyBzaG91bGQgY29tZSBvbmx5IHdoZW4gd2UnbGwgcmV2aXNlL3JlaW1hZ2luZQpiYXNpYyBEU0Eg cGFja2V0IGZsb3csIGFzIHdlIGFscmVhZHkga25vdyAoYXQgbGVhc3QgbWUgYW5kIEZsb3JpYW4K cmVwcm9kdWNlIGl0IHdlbGwpIHRoYXQgdGhlIGN1cnJlbnQgcGF0aCB0aHJvdWdoIHVubGlrZWx5 IGJyYW5jaGVzCmluIGV0aF90eXBlX3RyYW5zKCkgYW5kIGZyYW1lIGNhcHR1cmluZyB0aHJvdWdo IHBhY2tldF90eXBlIGlzIHNvCnN1Ym9wdGltYWwgdGhhdCBuZWFybHkgZGVzdHJveXMgb3ZlcmFs bCBwZXJmb3JtYW5jZSBvbiBzZXZlcmFsCnNldHVwcy4KU3dpdGNoaW5nIHRvIG5ldF9kZXZpY2U6 OnJ4X2hhbmRsZXIoKSBpcyBqdXN0IG9uZSBvZiBhbGwgdGhlIHBvc3NpYmxlCnZhcmlhbnRzLCBJ J20gc3VyZSB3ZSdsbCBmaW5kIHRoZSBiZXN0IHNvbHV0aW9uIHRvZ2V0aGVyLgoKUmVnYXJkcywK 4Zq3IOGbliDhmqIg4ZqmIOGaoCDhmrEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkxpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlzdApMaW51eC1tZWRpYXRl a0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD4BEC33CB1 for ; Wed, 15 Jan 2020 07:38:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A591B222C3 for ; Wed, 15 Jan 2020 07:38:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="levc3EZB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=dlink.ru header.i=@dlink.ru header.b="Cv7wHqPl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A591B222C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=dlink.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wcRDj8ABRnlVcTehWtNr6vO8VVPHLNhWuD74NAxnlLQ=; b=levc3EZB5wz+dYmsmVrfNrSwy c/ZQUHyCK8kT/J4col5M9ndMQwgB7C2Ma3MDADmbPaOx32h6KOPJAiD4RhUfHmI7pLM6lXw2NwlKz 9yErBELgyYxA940PnhG83EeeDgHqnug1dfT8hirSAprC5f778c4HTWMEz0yS4OlTIg9woXT4xBqnS xN6TE2FomsxQrl4nHsKeoqGSimoZDZbKVVVkUAGYBhhYJyYh/Geqe9UgY2PKzFcZcDCVrtuNZqECL 20kaPLSdEQ1+OAQR/zZsv98i9XNNHEq0ltbfu3THNMHfZ/qML9ok9aBhW41FiDviAOZyiomlJZt4l iBjrgPeHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irdG7-0007xU-QX; Wed, 15 Jan 2020 07:38:35 +0000 Received: from mail.dlink.ru ([178.170.168.18] helo=fd.dlink.ru) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irdG1-0007wp-Lx; Wed, 15 Jan 2020 07:38:34 +0000 Received: by fd.dlink.ru (Postfix, from userid 5000) id 444801B20857; Wed, 15 Jan 2020 10:38:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 fd.dlink.ru 444801B20857 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dlink.ru; s=mail; t=1579073908; bh=CxEiSPavtIlJWlMwr6AuhfGibqHNMwLCY9kUK5W5q30=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Cv7wHqPl+qAWKunjxq0HVohvH8s53UaBFABoCjAulPPLJMqFJG7beeKbMhXE/H6be n0Ooygzk2gUgMhvTzO1u983m4Pnyr2CZtDtnuMoD93BD3x7UuE0zCErcaK3Ilpzc8k vllgAZBKuZDXVehg1W6XgS7DdYy25158dtcMywxo= Received: from mail.rzn.dlink.ru (mail.rzn.dlink.ru [178.170.168.13]) by fd.dlink.ru (Postfix) with ESMTP id 257691B20968; Wed, 15 Jan 2020 10:38:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 fd.dlink.ru 257691B20968 Received: from mail.rzn.dlink.ru (localhost [127.0.0.1]) by mail.rzn.dlink.ru (Postfix) with ESMTP id 243EB1B21422; Wed, 15 Jan 2020 10:38:20 +0300 (MSK) Received: from mail.rzn.dlink.ru (localhost [127.0.0.1]) by mail.rzn.dlink.ru (Postfix) with ESMTPA; Wed, 15 Jan 2020 10:38:20 +0300 (MSK) MIME-Version: 1.0 Date: Wed, 15 Jan 2020 10:38:19 +0300 From: Alexander Lobakin To: Florian Fainelli Subject: Re: [PATCH RFC net-next 05/19] net: dsa: tag_ar9331: add GRO callbacks In-Reply-To: <129bf2bc-c0e9-02a3-7d40-0f7920803769@gmail.com> References: <20191230143028.27313-1-alobakin@dlink.ru> <20191230143028.27313-6-alobakin@dlink.ru> <0002a7388dfd5fb70db4b43a6c521c52@dlink.ru> <129bf2bc-c0e9-02a3-7d40-0f7920803769@gmail.com> User-Agent: Roundcube Webmail/1.4.0 Message-ID: X-Sender: alobakin@dlink.ru X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200114_233830_102477_497201DB X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Song Liu , Jakub Kicinski , Yoshiki Komachi , lkml , Eric Dumazet , Stanislav Fomichev , Matteo Croce , Edward Cree , Jakub Sitnicki , Daniel Borkmann , Paolo Abeni , Vivien Didelot , Hauke Mehrtens , Sean Wang , Jiri Pirko , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , netdev , Paul Blakey , Stephen Hemminger , Vladimir Oltean , "David S. Miller" , Taehee Yoo Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org RmxvcmlhbiBGYWluZWxsaSB3cm90ZSAxNS4wMS4yMDIwIDAwOjU2Ogo+IE9uIDEvMTMvMjAgMjoy OCBBTSwgVmxhZGltaXIgT2x0ZWFuIHdyb3RlOgo+PiBPbiBNb24sIDEzIEphbiAyMDIwIGF0IDEx OjQ2LCBBbGV4YW5kZXIgTG9iYWtpbiA8YWxvYmFraW5AZGxpbmsucnU+IAo+PiB3cm90ZToKPj4+ IAo+Pj4gVmxhZGltaXIgT2x0ZWFuIHdyb3RlIDEzLjAxLjIwMjAgMTI6NDI6Cj4+Pj4gSGkgQWxl eGFuZGVyLAo+Pj4+IAo+Pj4+IE9uIE1vbiwgMTMgSmFuIDIwMjAgYXQgMTE6MjIsIEFsZXhhbmRl ciBMb2Jha2luIDxhbG9iYWtpbkBkbGluay5ydT4KPj4+PiB3cm90ZToKPj4+Pj4gCj4+Pj4+IENQ VSBwb3J0cyBjYW4ndCBiZSBicmlkZ2VkIGFueXdheQo+Pj4+PiAKPj4+Pj4gUmVnYXJkcywKPj4+ Pj4g4Zq3IOGbliDhmqIg4ZqmIOGaoCDhmrEKPj4+PiAKPj4+PiBUaGUgZmFjdCB0aGF0IENQVSBw b3J0cyBjYW4ndCBiZSBicmlkZ2VkIGlzIGFscmVhZHkgbm90IGlkZWFsLgo+Pj4+IE9uZSBjYW4g aGF2ZSBhIERTQSBzd2l0Y2ggd2l0aCBjYXNjYWRlZCBzd2l0Y2hlcyBvbiBlYWNoIHBvcnQsIHNv IGl0Cj4+Pj4gYWN0cyBsaWtlIE4gRFNBIG1hc3RlcnMgKG5vdCBhcyBEU0EgbGlua3MsIHNpbmNl IHRoZSB0YWdnZXJzIGFyZQo+Pj4+IGluY29tcGF0aWJsZSksIHdpdGggZWFjaCBzd2l0Y2ggZm9y bWluZyBpdHMgb3duIHRyZWUuIEl0IGlzIAo+Pj4+IGRlc2lyYWJsZQo+Pj4+IHRoYXQgdGhlIHBv cnRzIG9mIHRoZSBEU0Egc3dpdGNoIG9uIHRvcCBhcmUgYnJpZGdlZCwgc28gdGhhdAo+Pj4+IGZv cndhcmRpbmcgYmV0d2VlbiBjYXNjYWRlZCBzd2l0Y2hlcyBkb2VzIG5vdCBwYXNzIHRocm91Z2gg dGhlIENQVS4KPj4+IAo+Pj4gT2gsIEkgc2VlLiBCdXQgY3VycmVudGx5IERTQSBpbmZyYSBmb3Ji aWRzIHRoZSBhZGRpbmcgRFNBIG1hc3RlcnMgdG8KPj4+IGJyaWRnZXMgSUlSQy4gQ2FuJ3QgbmFt ZSBpdCBnb29kIG9yIGJhZCBkZWNpc2lvbiwgYnV0IHdhcyBpbnRyb2R1Y2VkCj4+PiB0byBwcmV2 ZW50IGFjY2lkZW50YWwgcGFja2V0IGZsb3cgYnJlYWtpbmcgb24gRFNBIHNldHVwcy4KPj4+IAo+ PiAKPj4gSSBqdXN0IHdhbnRlZCB0byBwb2ludCBvdXQgdGhhdCBzb21lIHBlb3BsZSBhcmUgZ29p bmcgdG8gYmUgbG9va2luZyBhdAo+PiB3YXlzIGJ5IHdoaWNoIHRoZSBFVEhfUF9YRFNBIGhhbmRs ZXIgY2FuIGJlIG1hZGUgdG8gcGxheSBuaWNlIHdpdGggdGhlCj4+IG1hc3RlcidzIHJ4X2hhbmRs ZXIsIGFuZCB0aGF0IGl0IHdvdWxkIGJlIG5pY2UgdG8gYXQgbGVhc3Qgbm90IG1ha2UKPj4gdGhl IGxpbWl0YXRpb24gd29yc2UgdGhhbiBpdCBpcyBieSBjb252ZXJ0aW5nIGV2ZXJ5dGhpbmcgdG8K Pj4gcnhfaGFuZGxlcnMgKHdoaWNoICJjdXJyZW50bHkiIGNhbid0IGJlIHN0YWNrZWQsIGZyb20g dGhlIGNvbW1lbnRzIGluCj4+IG5ldGRldmljZS5oKS4KPiAKPiBJIGFtIG5vdCBzdXJlIHRoaXMg d291bGQgY2hhbmdlIHRoZSBzaXR1YXRpb24gbXVjaCwgdG9kYXkgd2UgY2Fubm90IAo+IGhhdmUK PiBhbnl0aGluZyBidXQgc3dpdGNoIHRhZ3MgdHJhdmVsIG9uIHRoZSBEU0EgbWFzdGVyIG5ldHdv cmsgZGV2aWNlLAo+IHdoZXRoZXIgd2UgYWNjb21wbGlzaCB0aGUgUlggdGFwIHRocm91Z2ggYSBz cGVjaWFsIHNrYi0+cHJvdG9jb2wgdmFsdWUKPiBvciB2aWEgcnhfaGFuZGxlciwgaXQgcHJvYmFi bHkgZG9lcyBub3QgZnVuY3Rpb25hbGx5IG1hdHRlciwgYnV0IGl0Cj4gY291bGQgY2hhbmdlIHRo ZSBwZXJmb3JtYW5jZS4KCkFzIGZvciBub3csIEkgdGhpbmsgdGhhdCB3ZSBzaG91bGQga2VlcCB0 aGlzIFJGQyBhcyBpdCBpcyBzbwpkZXZlbG9wZXJzIHdvcmtpbmcgd2l0aCBkaWZmZXJlbnQgRFNB IHN3aXRjaGVzIGNvdWxkIHRlc3QgaXQgb3IKaW1wbGVtZW50IEdSTyBvZmZsb2FkIGZvciBvdGhl ciB0YWdnZXJzIGxpa2UgRFNBIGFuZCBFRFNBLCAqYnV0KgphbnkgZnV0dXJlIHdvcmsgb24gdGhp cyBzaG91bGQgY29tZSBvbmx5IHdoZW4gd2UnbGwgcmV2aXNlL3JlaW1hZ2luZQpiYXNpYyBEU0Eg cGFja2V0IGZsb3csIGFzIHdlIGFscmVhZHkga25vdyAoYXQgbGVhc3QgbWUgYW5kIEZsb3JpYW4K cmVwcm9kdWNlIGl0IHdlbGwpIHRoYXQgdGhlIGN1cnJlbnQgcGF0aCB0aHJvdWdoIHVubGlrZWx5 IGJyYW5jaGVzCmluIGV0aF90eXBlX3RyYW5zKCkgYW5kIGZyYW1lIGNhcHR1cmluZyB0aHJvdWdo IHBhY2tldF90eXBlIGlzIHNvCnN1Ym9wdGltYWwgdGhhdCBuZWFybHkgZGVzdHJveXMgb3ZlcmFs bCBwZXJmb3JtYW5jZSBvbiBzZXZlcmFsCnNldHVwcy4KU3dpdGNoaW5nIHRvIG5ldF9kZXZpY2U6 OnJ4X2hhbmRsZXIoKSBpcyBqdXN0IG9uZSBvZiBhbGwgdGhlIHBvc3NpYmxlCnZhcmlhbnRzLCBJ J20gc3VyZSB3ZSdsbCBmaW5kIHRoZSBiZXN0IHNvbHV0aW9uIHRvZ2V0aGVyLgoKUmVnYXJkcywK 4Zq3IOGbliDhmqIg4ZqmIOGaoCDhmrEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D20C33CB1 for ; Wed, 15 Jan 2020 07:38:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 573E4222C3 for ; Wed, 15 Jan 2020 07:38:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=dlink.ru header.i=@dlink.ru header.b="gmIFfkyP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729211AbgAOHii (ORCPT ); Wed, 15 Jan 2020 02:38:38 -0500 Received: from fd.dlink.ru ([178.170.168.18]:46316 "EHLO fd.dlink.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726088AbgAOHih (ORCPT ); Wed, 15 Jan 2020 02:38:37 -0500 Received: by fd.dlink.ru (Postfix, from userid 5000) id BCF101B21254; Wed, 15 Jan 2020 10:38:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 fd.dlink.ru BCF101B21254 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dlink.ru; s=mail; t=1579073914; bh=CxEiSPavtIlJWlMwr6AuhfGibqHNMwLCY9kUK5W5q30=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=gmIFfkyPm7iywN2d5hK4aX1BTbGnYfpazghsAal7Udzm/YlHKT66E8AVZ7t4B/+Vz k1q9WjqvGlMMytMVqviW5Px4tIEIgq6zYg93koqXYOseMEGSXMNw21krlaTuEAVQwz KU74WOHtFFH7yj706gojdHFav+KiqJGciyAjd/cM= Received: from mail.rzn.dlink.ru (mail.rzn.dlink.ru [178.170.168.13]) by fd.dlink.ru (Postfix) with ESMTP id 257691B20968; Wed, 15 Jan 2020 10:38:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 fd.dlink.ru 257691B20968 Received: from mail.rzn.dlink.ru (localhost [127.0.0.1]) by mail.rzn.dlink.ru (Postfix) with ESMTP id 243EB1B21422; Wed, 15 Jan 2020 10:38:20 +0300 (MSK) Received: from mail.rzn.dlink.ru (localhost [127.0.0.1]) by mail.rzn.dlink.ru (Postfix) with ESMTPA; Wed, 15 Jan 2020 10:38:20 +0300 (MSK) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 15 Jan 2020 10:38:19 +0300 From: Alexander Lobakin To: Florian Fainelli Cc: Vladimir Oltean , "David S. Miller" , Edward Cree , Andrew Lunn , Vivien Didelot , Hauke Mehrtens , Sean Wang , Matthias Brugger , Jiri Pirko , Eric Dumazet , Paolo Abeni , Jakub Kicinski , Taehee Yoo , Stephen Hemminger , Stanislav Fomichev , Daniel Borkmann , Song Liu , Matteo Croce , Jakub Sitnicki , Paul Blakey , Yoshiki Komachi , netdev , lkml , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH RFC net-next 05/19] net: dsa: tag_ar9331: add GRO callbacks In-Reply-To: <129bf2bc-c0e9-02a3-7d40-0f7920803769@gmail.com> References: <20191230143028.27313-1-alobakin@dlink.ru> <20191230143028.27313-6-alobakin@dlink.ru> <0002a7388dfd5fb70db4b43a6c521c52@dlink.ru> <129bf2bc-c0e9-02a3-7d40-0f7920803769@gmail.com> User-Agent: Roundcube Webmail/1.4.0 Message-ID: X-Sender: alobakin@dlink.ru Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Florian Fainelli wrote 15.01.2020 00:56: > On 1/13/20 2:28 AM, Vladimir Oltean wrote: >> On Mon, 13 Jan 2020 at 11:46, Alexander Lobakin >> wrote: >>> >>> Vladimir Oltean wrote 13.01.2020 12:42: >>>> Hi Alexander, >>>> >>>> On Mon, 13 Jan 2020 at 11:22, Alexander Lobakin >>>> wrote: >>>>> >>>>> CPU ports can't be bridged anyway >>>>> >>>>> Regards, >>>>> ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ >>>> >>>> The fact that CPU ports can't be bridged is already not ideal. >>>> One can have a DSA switch with cascaded switches on each port, so it >>>> acts like N DSA masters (not as DSA links, since the taggers are >>>> incompatible), with each switch forming its own tree. It is >>>> desirable >>>> that the ports of the DSA switch on top are bridged, so that >>>> forwarding between cascaded switches does not pass through the CPU. >>> >>> Oh, I see. But currently DSA infra forbids the adding DSA masters to >>> bridges IIRC. Can't name it good or bad decision, but was introduced >>> to prevent accidental packet flow breaking on DSA setups. >>> >> >> I just wanted to point out that some people are going to be looking at >> ways by which the ETH_P_XDSA handler can be made to play nice with the >> master's rx_handler, and that it would be nice to at least not make >> the limitation worse than it is by converting everything to >> rx_handlers (which "currently" can't be stacked, from the comments in >> netdevice.h). > > I am not sure this would change the situation much, today we cannot > have > anything but switch tags travel on the DSA master network device, > whether we accomplish the RX tap through a special skb->protocol value > or via rx_handler, it probably does not functionally matter, but it > could change the performance. As for now, I think that we should keep this RFC as it is so developers working with different DSA switches could test it or implement GRO offload for other taggers like DSA and EDSA, *but* any future work on this should come only when we'll revise/reimagine basic DSA packet flow, as we already know (at least me and Florian reproduce it well) that the current path through unlikely branches in eth_type_trans() and frame capturing through packet_type is so suboptimal that nearly destroys overall performance on several setups. Switching to net_device::rx_handler() is just one of all the possible variants, I'm sure we'll find the best solution together. Regards, ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ