From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0B96C83F01 for ; Wed, 30 Aug 2023 15:16:41 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.593062.925961 (Exim 4.92) (envelope-from ) id 1qbMvl-0004A1-Hb; Wed, 30 Aug 2023 15:16:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 593062.925961; Wed, 30 Aug 2023 15:16:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qbMvl-00049u-Eu; Wed, 30 Aug 2023 15:16:29 +0000 Received: by outflank-mailman (input) for mailman id 593062; Wed, 30 Aug 2023 15:16:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qbMvk-00049o-HY for xen-devel@lists.xenproject.org; Wed, 30 Aug 2023 15:16:28 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3079def3-4748-11ee-8783-cb3800f73035; Wed, 30 Aug 2023 17:16:27 +0200 (CEST) Received: from [192.168.8.109] (unknown [151.38.20.102]) by support.bugseng.com (Postfix) with ESMTPSA id 8F7E64EE0738; Wed, 30 Aug 2023 17:16:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3079def3-4748-11ee-8783-cb3800f73035 Message-ID: Date: Wed, 30 Aug 2023 17:16:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [XEN PATCH 06/13] x86/EFI: address violations of MISRA C:2012 Directive 4.10 Content-Language: en-US To: Jan Beulich , sstabellini@kernel.org Cc: consulting@bugseng.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <5bc8dfaa-122c-e076-eb8c-5bfd9a459dad@suse.com> From: Simone Ballarin Organization: BUGSENG In-Reply-To: <5bc8dfaa-122c-e076-eb8c-5bfd9a459dad@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/08/23 15:27, Jan Beulich wrote: > On 28.08.2023 15:20, Simone Ballarin wrote: >> Add inclusion guards to address violations of >> MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order >> to prevent the contents of a header file being included more than >> once"). >> >> Mechanical change. >> >> Signed-off-by: Simone Ballarin >> --- >> xen/arch/x86/efi/efi-boot.h | 6 ++++++ >> xen/arch/x86/efi/runtime.h | 5 +++++ >> 2 files changed, 11 insertions(+) >> >> diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h >> index 92f4cfe8bd..2c6be062cc 100644 >> --- a/xen/arch/x86/efi/efi-boot.h >> +++ b/xen/arch/x86/efi/efi-boot.h >> @@ -3,6 +3,10 @@ >> * is intended to be included by common/efi/boot.c _only_, and >> * therefore can define arch specific global variables. >> */ >> + >> +#ifndef __X86_EFI_EFI_BOOT_H__ >> +#define __X86_EFI_EFI_BOOT_H__ > > Considering the comment, I find the need for a guard here quite > "interesting", to be honest. > > Jan I don't think a simple comment is enough to say that "precautions have been taken". For the moment, I will drop this change to keep this patch going. -- Simone Ballarin, M.Sc. Field Application Engineer, BUGSENG (https://bugseng.com)