Re: [cocci] spatch 1.1.1 segmentation fault report

[Denis Efremov <efremov@linux.com>]

On 2/6/22 21:43, Julia Lawall wrote:
> 
> 
> On Sun, 6 Feb 2022, Denis Efremov wrote:
> 
>> Hi,
>>
>> I'm observing a weird crash with spatch 1.1.1
>>
>> $ spatch --version
>> spatch version 1.1.1 compiled with OCaml version 4.11.2
>> Flags passed to the configure script: --enable-opt --enable-ocaml --enable-python --enable-pcre-syntax --enable-pcre --prefix /home/work/.opam/4.11.2 --libdir /home/work/.opam/4.11.2/lib
>> OCaml scripting support: yes
>> Python scripting support: yes
>> Syntax of regular expressions: PCRE
>>
>> $ cat segfault.cocci
>> @err@
>> position p;
>> @@
>>
>> amd_energy_is_visible(...)
>> {
>> *       return 0444;@p
>> }
>>
>> @script:python@
>> p << err.p;
>> @@
>>
>> coccilib.report.print_report(p[0], "found")
>>
>> $ mkdir empty_dir # creating empty directory
>> $ spatch segfault.cocci empty_dir
>> init_defs_builtins: /home/work/.opam/4.11.2/lib/coccinelle/standard.h
>> 0 files match
>> [1]    152475 segmentation fault (core dumped)  spatch segfault.cocci test
> 
> I tried 1.1.1 with the options --enable-opt --enable-ocaml --enable-python
> --enable-pcre-syntax --enable-pcre, but it seems to work find for me.
> Does the problem go away if there is a file in the directory?  If you
> remove the python code?

It doesn't crash if I run it on the linux kernel sources on commits prior to
9049572fb145 hwmon: Remove amd_energy driver


$ git checkout 9049572fb145~
# there is amd_energy_is_visible in drivers/hwmon/amd_energy.c
# spatch doesn't crash on this commit

$ git checkout 9049572fb145
# no amd_energy_is_visible in kernel source
# spatch crashes

If I remove python code then spatch doesn't crash.

$ python --version
Python 3.10.2

Thanks,
Denis