From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 00/10] New pragmas for the xdrgen tool
Date: Fri, 04 Sep 2026 13:04:46 -0400 [thread overview]
Message-ID: <f089f788ab03bdd941954be29fc1fe968a8c689e.camel@kernel.org> (raw)
In-Reply-To: <20260904165052.153327-1-cel@kernel.org>
On Fri, 2026-09-04 at 12:50 -0400, Chuck Lever wrote:
> The NFSv2, NFSv3, and NFS_ACL conversions to xdrgen-generated codecs
> need two important new features in the xdrgen tool to deal with a
> few of the more complex structures that XDR can express.
>
> The first is a payload that resides in the Linux page cache.
> Currently the generated codec for a variable-length opaque copies
> through a data pointer, but a READ result already sits in the pages
> of rq_res and a WRITE payload arrives in the pages of the Receive
> buffer. Marshaling and unmarshaling this type of payload needs to
> avoid copying the payload's content.
>
> The second is an array of non-scalar objects. Examples include the
> NFS_ACL aclent<> list, which is the on-the-wire form of the kernel's
> posix_acl, and the READDIR entry list, which is produced from a VFS
> iteration.
>
> No in-tree XDR specification applies either directive yet, so the
> generated output remains unchanged across the whole series.
>
> ---
> Changes in v2:
> - Reject a type whose members reach more than one "pages" payload.
> - Reject an aggregate element type with nested variable-length storage.
> - Require a pointer element type for an optional-data aggregate.
> - Reject an optional-data aggregate in an RPC argument type.
> - Document how a producer reports an error that stops the list.
> - Link to v1: https://lore.kernel.org/r/20260903150351.9572-1-cel@kernel.org
>
> Chuck Lever (10):
> SUNRPC: Carry a generated-codec context pointer in struct xdr_stream
> SUNRPC: Bind the svc_rqst to its XDR streams
> SUNRPC: Add svcxdr_encode_opaque_payload()
> xdrgen: Pass the containing struct name to member codec emitters
> xdrgen: Add a "pragma pages" directive
> SUNRPC: Add svcxdr_decode_opaque_payload()
> xdrgen: Extend the pages directive to page-resident arguments
> xdrgen: Add hook-driven aggregate codec for variable-length arrays
> xdrgen: Extend the aggregate codec to optional-data list members
> xdrgen: Stream optional-data aggregate lists during encode
>
> fs/nfsd/nfs4xdr.c | 1 +
> include/linux/sunrpc/svc.h | 77 +++
> include/linux/sunrpc/xdr.h | 1 +
> include/linux/sunrpc/xdrgen/_defs.h | 34 ++
> net/sunrpc/xdr.c | 3 +
> tools/net/sunrpc/xdrgen/README | 146 +++++-
> tools/net/sunrpc/xdrgen/generators/pointer.py | 68 ++-
> tools/net/sunrpc/xdrgen/generators/struct.py | 197 +++++++-
> tools/net/sunrpc/xdrgen/generators/union.py | 69 ++-
> tools/net/sunrpc/xdrgen/grammars/xdr.lark | 2 +
> .../C/pointer/decoder/pages_opaque.j2 | 6 +
> .../C/pointer/definition/pages_opaque.j2 | 5 +
> .../C/pointer/encoder/pages_opaque.j2 | 10 +
> .../C/struct/declaration/aggregate_hooks.j2 | 14 +
> .../C/struct/decoder/aggregate_array.j2 | 35 ++
> .../C/struct/decoder/aggregate_optional.j2 | 31 ++
> .../C/struct/decoder/pages_opaque.j2 | 6 +
> .../C/struct/definition/pages_opaque.j2 | 5 +
> .../C/struct/encoder/aggregate_array.j2 | 39 ++
> .../C/struct/encoder/aggregate_optional.j2 | 29 ++
> .../C/struct/encoder/pages_opaque.j2 | 10 +
> .../templates/C/union/encoder/pages_opaque.j2 | 10 +
> tools/net/sunrpc/xdrgen/xdr_ast.py | 473 ++++++++++++++++++
> 23 files changed, 1228 insertions(+), 43 deletions(-)
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/pointer/decoder/pages_opaque.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/pointer/definition/pages_opaque.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/pointer/encoder/pages_opaque.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/declaration/aggregate_hooks.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/decoder/aggregate_array.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/decoder/aggregate_optional.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/decoder/pages_opaque.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/definition/pages_opaque.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/encoder/aggregate_array.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/encoder/aggregate_optional.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/encoder/pages_opaque.j2
> create mode 100644 tools/net/sunrpc/xdrgen/templates/C/union/encoder/pages_opaque.j2
Acked-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2026-09-04 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 16:50 [PATCH v2 00/10] New pragmas for the xdrgen tool Chuck Lever
2026-09-04 16:50 ` [PATCH v2 01/10] SUNRPC: Carry a generated-codec context pointer in struct xdr_stream Chuck Lever
2026-09-04 16:50 ` [PATCH v2 02/10] SUNRPC: Bind the svc_rqst to its XDR streams Chuck Lever
2026-09-04 16:50 ` [PATCH v2 03/10] SUNRPC: Add svcxdr_encode_opaque_payload() Chuck Lever
2026-09-04 16:50 ` [PATCH v2 04/10] xdrgen: Pass the containing struct name to member codec emitters Chuck Lever
2026-09-04 16:50 ` [PATCH v2 05/10] xdrgen: Add a "pragma pages" directive Chuck Lever
2026-09-04 16:50 ` [PATCH v2 06/10] SUNRPC: Add svcxdr_decode_opaque_payload() Chuck Lever
2026-09-04 16:50 ` [PATCH v2 07/10] xdrgen: Extend the pages directive to page-resident arguments Chuck Lever
2026-09-04 16:50 ` [PATCH v2 08/10] xdrgen: Add hook-driven aggregate codec for variable-length arrays Chuck Lever
2026-09-04 16:50 ` [PATCH v2 09/10] xdrgen: Extend the aggregate codec to optional-data list members Chuck Lever
2026-09-04 16:50 ` [PATCH v2 10/10] xdrgen: Stream optional-data aggregate lists during encode Chuck Lever
2026-09-04 17:04 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f089f788ab03bdd941954be29fc1fe968a8c689e.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.