From: Jes Sorensen <jes.sorensen@gmail.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, kernel-team@fb.com,
Jes Sorensen <jsorensen@fb.com>
Subject: Re: [PATCH 1/9] Build basic shared library framework
Date: Tue, 21 Apr 2020 17:00:10 -0400 [thread overview]
Message-ID: <f09aba36-316b-cc42-b3ab-84a94b722fd6@gmail.com> (raw)
In-Reply-To: <20200322053349.GG111151@sol.localdomain>
On 3/22/20 1:33 AM, Eric Biggers wrote:
> On Thu, Mar 12, 2020 at 05:47:50PM -0400, Jes Sorensen wrote:
>> From: Jes Sorensen <jsorensen@fb.com>
>>
>> This introduces a dummy shared library to start moving things into.
>>
>> Signed-off-by: Jes Sorensen <jsorensen@fb.com>
>> ---
>> Makefile | 18 +++++++++++++++---
>> libverity.c | 10 ++++++++++
>> 2 files changed, 25 insertions(+), 3 deletions(-)
>> create mode 100644 libverity.c
>>
>> diff --git a/Makefile b/Makefile
>> index b9c09b9..bb85896 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1,20 +1,32 @@
>> EXE := fsverity
>> +LIB := libfsverity.so
>> CFLAGS := -O2 -Wall
>> CPPFLAGS := -D_FILE_OFFSET_BITS=64
>> LDLIBS := -lcrypto
>> DESTDIR := /usr/local
>> +LIBDIR := /usr/lib64
>
> LIBDIR isn't used at all. I assume you meant for it to be location where the
> library gets installed? The proper way to handle installation locations
> (assuming we stay with a plain Makefile and not move to another build system)
> would be:
>
> PREFIX ?= /usr/local
> BINDIR ?= $(PREFIX)/bin
> INCDIR ?= $(PREFIX)/include
> LIBDIR ?= $(PREFIX)/lib
>
> then install binaries into $(DESTDIR)$(BINDIR), headers into
> $(DESTDIR)$(INCDIR), and libraries into $(DESTDIR)$(LIBDIR).
> This matches the conventions for autoconf.
I pushed a change to git which addresses this, I still need to address
the soname though.
Long term it might be nice to switch to autoconf/automake, at the same
time I love dealing with it about as much as going to the dentist for a
root canal.
Cheers,
Jes
next prev parent reply other threads:[~2020-04-21 21:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 21:47 [PATCH v3 0/9] Split fsverity-utils into a shared library Jes Sorensen
2020-03-12 21:47 ` [PATCH 1/9] Build basic shared library framework Jes Sorensen
2020-03-22 5:23 ` Eric Biggers
2020-03-22 5:33 ` Eric Biggers
2020-04-21 21:00 ` Jes Sorensen [this message]
2020-03-12 21:47 ` [PATCH 2/9] Change compute_file_measurement() to take a file descriptor as argument Jes Sorensen
2020-03-12 21:47 ` [PATCH 3/9] Move fsverity_descriptor definition to libfsverity.h Jes Sorensen
2020-03-22 4:57 ` Eric Biggers
2020-04-21 16:07 ` Jes Sorensen
2020-04-21 16:16 ` Eric Biggers
2020-04-21 16:20 ` Jes Sorensen
2020-03-12 21:47 ` [PATCH 4/9] Move hash algorithm code to shared library Jes Sorensen
2020-03-22 5:38 ` Eric Biggers
2020-04-22 17:57 ` Jes Sorensen
2020-03-12 21:47 ` [PATCH 5/9] Create libfsverity_compute_digest() and adapt cmd_sign to use it Jes Sorensen
2020-03-22 5:40 ` Eric Biggers
2020-03-12 21:47 ` [PATCH 6/9] Introduce libfsverity_sign_digest() Jes Sorensen
2020-03-12 21:47 ` [PATCH 7/9] Validate input arguments to libfsverity_compute_digest() Jes Sorensen
2020-03-12 21:47 ` [PATCH 8/9] Validate input parameters for libfsverity_sign_digest() Jes Sorensen
2020-03-22 5:27 ` Eric Biggers
2020-03-12 21:47 ` [PATCH 9/9] Document API of libfsverity Jes Sorensen
2020-03-22 5:54 ` Eric Biggers
2020-03-22 5:05 ` [PATCH v3 0/9] Split fsverity-utils into a shared library Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f09aba36-316b-cc42-b3ab-84a94b722fd6@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=ebiggers@kernel.org \
--cc=jsorensen@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.