From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFBE5C5479D for ; Wed, 11 Jan 2023 13:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EUgql3miCxinAUE4tCTSIYr5Xu4wTxNCREWInu1Ds34=; b=jDBe8MQVhhv5PQkpxR35tHh0f3 tRMfKLRNVGyHZFfLf+Gt4FU4dik+x6GNHaVBa2EZgaLPQieLQ7fqD7YPTp8OAJ87X21JhmyTiyPB3 LhnSeoErYF1M0clDaSMuZimH31afPo4t/alEGFJjRxdg2kRDQaTqR+aF5//YS/O5U3FPqLziL/QfJ r9KdJAn5w3YnyELYiOQlTPHlxJ4j21nROx7Ot8TK1UbAJ9lx3bh+GVgTb+v8GX31CxKRglZ4YFDYe ltLdTFMbCm/sHsBupL/ERbuZiQnNPr/fJrm+L8H1gqb5v2+57kBMpa7IhVdlkX7Gyf2vHV8n3i8hM m1Czfxzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFbHZ-00Bd9c-3w; Wed, 11 Jan 2023 13:36:45 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFbHW-00Bd8P-1g for linux-arm-kernel@lists.infradead.org; Wed, 11 Jan 2023 13:36:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3D7EB81BDB; Wed, 11 Jan 2023 13:36:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BAE8C433EF; Wed, 11 Jan 2023 13:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673444197; bh=jmhq9ChkH2NfqzWnvmpx3kh3Vnp+p3wr2mRMyDf+7DI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bU0z/WMfvYKXzmujZknAssAgPbjR1WKv89ti7YI8qpGJLQ/8EpzUjf7wm5/JQw7sa OFsj129pM1cvw618L1MZAWFc7kuB7WmqjIGVjVSTyCNK2jb84kADMAQdzBuY9z+d+g z9bCmRt1aegtA4sbUlNJ37wwrMX4NOKoE06XhPe1Zt2ierjC/vcfdaXM15uOtAnatT dHVnZkw3BYZ8Q3cHlgl7iqUMHzEHv06LP9AJXVEEaIP2V85J5OGXSp9juuORbArXjL rWLj61/n+bskBJny2Rf/noHUdFprxkM3zAgWyRjE8Aixd4B3ZkvoRYvthrGFgrcPz5 SEOkPs4uUs+KQ== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pFbHO-000sOo-Vh; Wed, 11 Jan 2023 13:36:35 +0000 MIME-Version: 1.0 Date: Wed, 11 Jan 2023 13:36:34 +0000 From: Marc Zyngier To: Ganapatrao Kulkarni Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, scott@os.amperecomputing.com, Darren Hart Subject: Re: [PATCH 0/3] KVM: arm64: nv: Fixes for Nested Virtualization issues In-Reply-To: References: <20220824060304.21128-1-gankulkarni@os.amperecomputing.com> <6171dc7c-5d83-d378-db9e-d94f27afe43a@os.amperecomputing.com> <87o7r6dpi8.wl-maz@kernel.org> <4d952300-0681-41ff-b416-38fbae4ebea6@os.amperecomputing.com> <2169cc83d3015727f5f486844c8c4647@kernel.org> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: gankulkarni@os.amperecomputing.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, scott@os.amperecomputing.com, darren@os.amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_053642_427116_7024E0E4 X-CRM114-Status: GOOD ( 22.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMy0wMS0xMSAxMjo0NiwgR2FuYXBhdHJhbyBLdWxrYXJuaSB3cm90ZToKPiBPbiAxMS0w MS0yMDIzIDA1OjA5IHBtLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+IE9uIDIwMjMtMDEtMTEgMDg6 NDYsIEdhbmFwYXRyYW8gS3Vsa2Fybmkgd3JvdGU6Cj4+PiBPbiAxMS0wMS0yMDIzIDAzOjI0IGFt LCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+Pj4gT24gVHVlLCAxMCBKYW4gMjAyMyAxMjoxNzoyMCAr MDAwMCwKPj4+PiBHYW5hcGF0cmFvIEt1bGthcm5pIDxnYW5rdWxrYXJuaUBvcy5hbXBlcmVjb21w dXRpbmcuY29tPiB3cm90ZToKPj4+Pj4gCj4+Pj4+IEkgYW0gY3VycmVudGx5IHdvcmtpbmcgYXJv dW5kIHRoaXMgd2l0aCAibm9obHQiIGtlcm5lbCBwYXJhbSB0bwo+Pj4+PiBOZXN0ZWRWTS4gQW55 IHN1Z2dlc3Rpb25zIHRvIGhhbmRsZS9maXggdGhpcyBjYXNlL2lzc3VlIGFuZCBhdm9pZCAKPj4+ Pj4gdGhlCj4+Pj4+IHNsb3duZXNzIG9mIGJvb3Rpbmcgb2YgTmVzdGVkVk0gd2l0aCBtb3JlIGNv cmVzPwo+Pj4+PiAKPj4+Pj4gTm90ZTogR3Vlc3QtSHlwZXJ2aXNvciBhbmQgTmVzdGVkVk0gYXJl IHVzaW5nIGRlZmF1bHQga2VybmVsIAo+Pj4+PiBpbnN0YWxsZWQKPj4+Pj4gdXNpbmcgRmVkb3Jh IDM2IGlzby4KPj4+PiAKPj4+PiBEZXNwaXRlIHdoYXQgSSBzYWlkIGVhcmxpZXIsIEkgaGF2ZSBh IHZhZ3VlIGlkZWEgaGVyZSwgdGhhbmtzIHRvIHRoZQo+Pj4+IGludGVyZXN0aW5nIGNhbGwgdHJh Y2VzIHRoYXQgeW91IHByb3ZpZGVkICh0aGlzIGlzIHJlYWxseSBhd2Vzb21lIAo+Pj4+IHdvcmsK Pj4+PiBCVFcsIGdpdmVuIGhvdyBoYXJkIGl0IGlzIHRvIHRyYWNlIHRoaW5ncyBhY3Jvc3MgMyBk aWZmZXJlbnQgCj4+Pj4ga2VybmVscykuCj4+Pj4gCj4+Pj4gV2UgY2FuIHNsaWdodGx5IGxpbWl0 IHRoZSBpbXBhY3Qgb2YgdGhlIHByZXBhcmUvZmluaXNoIHNlcXVlbmNlIGlmIAo+Pj4+IHRoZQo+ Pj4+IGd1ZXN0IGh5cGVydmlzb3Igb25seSBhY2Nlc3NlcyB0aGUgYWN0aXZlIHJlZ2lzdGVycyBm b3IgU0dJcy9QUElzIG9uCj4+Pj4gdGhlIHZjcHUgdGhhdCBvd25zIHRoZW0sIGZvcmJpZGRpbmcg YW55IGNyb3NzLUNQVS10by1yZWRpc3RyaWJ1dG9yCj4+Pj4gYWNjZXNzLgo+Pj4+IAo+Pj4+IFNv bWV0aGluZyBhbG9uZyB0aGVzZSBsaW5lcywgd2hpY2ggaXMgb25seSBib290LXRlc3RlZC4gTGV0 IG1lIGtub3cKPj4+PiBob3cgdGhpcyBmYXJlcyBmb3IgeW91Lgo+Pj4+IAo+Pj4+IFRoYW5rcywK Pj4+PiAKPj4+PiDCoMKgwqDCoE0uCj4+Pj4gCj4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQv a3ZtL3ZnaWMvdmdpYy1tbWlvLmMgCj4+Pj4gYi9hcmNoL2FybTY0L2t2bS92Z2ljL3ZnaWMtbW1p by5jCj4+Pj4gaW5kZXggYjMyZDQzNGMxZDRhLi4xY2NhNDViZTUzMzUgMTAwNjQ0Cj4+Pj4gLS0t IGEvYXJjaC9hcm02NC9rdm0vdmdpYy92Z2ljLW1taW8uYwo+Pj4+ICsrKyBiL2FyY2gvYXJtNjQv a3ZtL3ZnaWMvdmdpYy1tbWlvLmMKPj4+PiBAQCAtNDczLDkgKzQ3MywxMCBAQCBpbnQgdmdpY191 YWNjZXNzX3dyaXRlX2NwZW5kaW5nKHN0cnVjdCBrdm1fdmNwdSAKPj4+PiAqdmNwdSwKPj4+PiDC oMKgICogYWN0aXZlIHN0YXRlIGNhbiBiZSBvdmVyd3JpdHRlbiB3aGVuIHRoZSBWQ1BVJ3Mgc3Rh dGUgaXMgc3luY2VkIAo+Pj4+IGNvbWluZyBiYWNrCj4+Pj4gwqDCoCAqIGZyb20gdGhlIGd1ZXN0 Lgo+Pj4+IMKgwqAgKgo+Pj4+IC0gKiBGb3Igc2hhcmVkIGludGVycnVwdHMgYXMgd2VsbCBhcyBH SUN2MyBwcml2YXRlIGludGVycnVwdHMsIHdlIAo+Pj4+IGhhdmUgdG8KPj4+PiAtICogc3RvcCBh bGwgdGhlIFZDUFVzIGJlY2F1c2UgaW50ZXJydXB0cyBjYW4gYmUgbWlncmF0ZWQgd2hpbGUgd2Ug Cj4+Pj4gZG9uJ3QgaG9sZAo+Pj4+IC0gKiB0aGUgSVJRIGxvY2tzIGFuZCB3ZSBkb24ndCB3YW50 IHRvIGJlIGNoYXNpbmcgbW92aW5nIHRhcmdldHMuCj4+Pj4gKyAqIEZvciBzaGFyZWQgaW50ZXJy dXB0cyBhcyB3ZWxsIGFzIEdJQ3YzIHByaXZhdGUgaW50ZXJydXB0cyAKPj4+PiBhY2Nlc3NlZCBm cm9tIHRoZQo+Pj4+ICsgKiBub24tb3duaW5nIENQVSwgd2UgaGF2ZSB0byBzdG9wIGFsbCB0aGUg VkNQVXMgYmVjYXVzZSBpbnRlcnJ1cHRzIAo+Pj4+IGNhbiBiZQo+Pj4+ICsgKiBtaWdyYXRlZCB3 aGlsZSB3ZSBkb24ndCBob2xkIHRoZSBJUlEgbG9ja3MgYW5kIHdlIGRvbid0IHdhbnQgdG8gCj4+ Pj4gYmUgY2hhc2luZwo+Pj4+ICsgKiBtb3ZpbmcgdGFyZ2V0cy4KPj4+PiDCoMKgICoKPj4+PiDC oMKgICogRm9yIEdJQ3YyIHByaXZhdGUgaW50ZXJydXB0cyB3ZSBkb24ndCBoYXZlIHRvIGRvIGFu eXRoaW5nIAo+Pj4+IGJlY2F1c2UKPj4+PiDCoMKgICogdXNlcnNwYWNlIGFjY2Vzc2VzIHRvIHRo ZSBWR0lDIHN0YXRlIGFscmVhZHkgcmVxdWlyZSBhbGwgVkNQVXMgCj4+Pj4gdG8gYmUKPj4+PiBA QCAtNDg0LDcgKzQ4NSw4IEBAIGludCB2Z2ljX3VhY2Nlc3Nfd3JpdGVfY3BlbmRpbmcoc3RydWN0 IGt2bV92Y3B1IAo+Pj4+ICp2Y3B1LAo+Pj4+IMKgwqAgKi8KPj4+PiDCoCBzdGF0aWMgdm9pZCB2 Z2ljX2FjY2Vzc19hY3RpdmVfcHJlcGFyZShzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUsIHUzMiAKPj4+ PiBpbnRpZCkKPj4+PiDCoCB7Cj4+Pj4gLcKgwqDCoCBpZiAodmNwdS0+a3ZtLT5hcmNoLnZnaWMu dmdpY19tb2RlbCA9PSBLVk1fREVWX1RZUEVfQVJNX1ZHSUNfVjMgCj4+Pj4gfHwKPj4+PiArwqDC oMKgIGlmICgodmNwdS0+a3ZtLT5hcmNoLnZnaWMudmdpY19tb2RlbCA9PSAKPj4+PiBLVk1fREVW X1RZUEVfQVJNX1ZHSUNfVjMgJiYKPj4+PiArwqDCoMKgwqDCoMKgwqDCoCB2Y3B1ID09IGt2bV9n ZXRfcnVubmluZ192Y3B1KCkpIHx8Cj4+PiAKPj4+IFRoYW5rcyBNYXJjIGZvciB0aGUgcGF0Y2gh Cj4+PiAKPj4+IEkgdGhpbmssIHlvdSBtZWFuIG5vdCBlcXVhbCB0bz8KPj4+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoCB2Y3B1ICE9IGt2bV9nZXRfcnVubmluZ192Y3B1KCkpIHx8Cj4+IAo+PiBZZWFo LCBleGFjdGx5LiBJIHdva2UgdXAgdGhpcyBtb3JuaW5nIHJlYWxpc2luZyB0aGlzIHBhdGNoIHdh cwo+PiAqYWxtb3N0KiByaWdodC4gRG9uJ3Qgd3JpdGUgcGF0Y2hlcyBsaWtlIHRoaXMgYWZ0ZXIg YSBsb25nIGRheQo+PiBhdCB3b3JrLi4uCj4+IAo+Pj4gV2l0aCB0aGUgY2hhbmdlIHRvIG5vdC1l cXVhbCwgdGhlIGlzc3VlIGlzIGZpeGVkIGFuZCBJIGNvdWxkIHNlZSB0aGUKPj4+IE5lc3RlZFZN IGJvb3RpbmcgaXMgcHJldHR5IGZhc3Qgd2l0aCBoaWdoZXIgbnVtYmVyIG9mIGNvcmVzIGFzIHdl bGwuCj4+IAo+PiBHb29kLCB0aGFua3MgZm9yIHRlc3RpbmcgaXQuIEknbGwgcm9sbCB1cCBhbiBh Y3R1YWwgcGF0Y2ggZm9yIHRoYXQKPj4gYW5kIHN0aWNrIGl0IGluIHRoZSBtb25zdGVyIHF1ZXVl Lgo+IAo+IFRoYW5rcywgUGxlYXNlIHB1bGwgcGF0Y2ggMy8zIGFsc28gdG8gbnYtNi4yIHRyZWUg YWxvbmcgd2l0aCB0aGlzCj4gcGF0Y2guIEkgd2lsbCBtb3ZlIG15IHNldHVwIHRvIG52LTYuMiBv bmNlIHRoZXNlIHBhdGNoZXMgYXJlIGluLgoKMy8zIHNob3VsZCBhbHJlYWR5IGJlIGluIHRoZSBi cmFuY2gsIG1lcmdlZCB3aXRoIHRoZSBzaGFkb3cKUzIgZmF1bHQgaGFuZGxpbmcuCgogICAgICAg ICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQganVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29EEAC54EBC for ; Wed, 11 Jan 2023 13:39:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239246AbjAKNjZ (ORCPT ); Wed, 11 Jan 2023 08:39:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239209AbjAKNjH (ORCPT ); Wed, 11 Jan 2023 08:39:07 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FBEB1ADAD for ; Wed, 11 Jan 2023 05:36:40 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C501BB81BE6 for ; Wed, 11 Jan 2023 13:36:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BAE8C433EF; Wed, 11 Jan 2023 13:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673444197; bh=jmhq9ChkH2NfqzWnvmpx3kh3Vnp+p3wr2mRMyDf+7DI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bU0z/WMfvYKXzmujZknAssAgPbjR1WKv89ti7YI8qpGJLQ/8EpzUjf7wm5/JQw7sa OFsj129pM1cvw618L1MZAWFc7kuB7WmqjIGVjVSTyCNK2jb84kADMAQdzBuY9z+d+g z9bCmRt1aegtA4sbUlNJ37wwrMX4NOKoE06XhPe1Zt2ierjC/vcfdaXM15uOtAnatT dHVnZkw3BYZ8Q3cHlgl7iqUMHzEHv06LP9AJXVEEaIP2V85J5OGXSp9juuORbArXjL rWLj61/n+bskBJny2Rf/noHUdFprxkM3zAgWyRjE8Aixd4B3ZkvoRYvthrGFgrcPz5 SEOkPs4uUs+KQ== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pFbHO-000sOo-Vh; Wed, 11 Jan 2023 13:36:35 +0000 MIME-Version: 1.0 Date: Wed, 11 Jan 2023 13:36:34 +0000 From: Marc Zyngier To: Ganapatrao Kulkarni Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, scott@os.amperecomputing.com, Darren Hart Subject: Re: [PATCH 0/3] KVM: arm64: nv: Fixes for Nested Virtualization issues In-Reply-To: References: <20220824060304.21128-1-gankulkarni@os.amperecomputing.com> <6171dc7c-5d83-d378-db9e-d94f27afe43a@os.amperecomputing.com> <87o7r6dpi8.wl-maz@kernel.org> <4d952300-0681-41ff-b416-38fbae4ebea6@os.amperecomputing.com> <2169cc83d3015727f5f486844c8c4647@kernel.org> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: gankulkarni@os.amperecomputing.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, scott@os.amperecomputing.com, darren@os.amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2023-01-11 12:46, Ganapatrao Kulkarni wrote: > On 11-01-2023 05:09 pm, Marc Zyngier wrote: >> On 2023-01-11 08:46, Ganapatrao Kulkarni wrote: >>> On 11-01-2023 03:24 am, Marc Zyngier wrote: >>>> On Tue, 10 Jan 2023 12:17:20 +0000, >>>> Ganapatrao Kulkarni wrote: >>>>> >>>>> I am currently working around this with "nohlt" kernel param to >>>>> NestedVM. Any suggestions to handle/fix this case/issue and avoid >>>>> the >>>>> slowness of booting of NestedVM with more cores? >>>>> >>>>> Note: Guest-Hypervisor and NestedVM are using default kernel >>>>> installed >>>>> using Fedora 36 iso. >>>> >>>> Despite what I said earlier, I have a vague idea here, thanks to the >>>> interesting call traces that you provided (this is really awesome >>>> work >>>> BTW, given how hard it is to trace things across 3 different >>>> kernels). >>>> >>>> We can slightly limit the impact of the prepare/finish sequence if >>>> the >>>> guest hypervisor only accesses the active registers for SGIs/PPIs on >>>> the vcpu that owns them, forbidding any cross-CPU-to-redistributor >>>> access. >>>> >>>> Something along these lines, which is only boot-tested. Let me know >>>> how this fares for you. >>>> >>>> Thanks, >>>> >>>>     M. >>>> >>>> diff --git a/arch/arm64/kvm/vgic/vgic-mmio.c >>>> b/arch/arm64/kvm/vgic/vgic-mmio.c >>>> index b32d434c1d4a..1cca45be5335 100644 >>>> --- a/arch/arm64/kvm/vgic/vgic-mmio.c >>>> +++ b/arch/arm64/kvm/vgic/vgic-mmio.c >>>> @@ -473,9 +473,10 @@ int vgic_uaccess_write_cpending(struct kvm_vcpu >>>> *vcpu, >>>>    * active state can be overwritten when the VCPU's state is synced >>>> coming back >>>>    * from the guest. >>>>    * >>>> - * For shared interrupts as well as GICv3 private interrupts, we >>>> have to >>>> - * stop all the VCPUs because interrupts can be migrated while we >>>> don't hold >>>> - * the IRQ locks and we don't want to be chasing moving targets. >>>> + * For shared interrupts as well as GICv3 private interrupts >>>> accessed from the >>>> + * non-owning CPU, we have to stop all the VCPUs because interrupts >>>> can be >>>> + * migrated while we don't hold the IRQ locks and we don't want to >>>> be chasing >>>> + * moving targets. >>>>    * >>>>    * For GICv2 private interrupts we don't have to do anything >>>> because >>>>    * userspace accesses to the VGIC state already require all VCPUs >>>> to be >>>> @@ -484,7 +485,8 @@ int vgic_uaccess_write_cpending(struct kvm_vcpu >>>> *vcpu, >>>>    */ >>>>   static void vgic_access_active_prepare(struct kvm_vcpu *vcpu, u32 >>>> intid) >>>>   { >>>> -    if (vcpu->kvm->arch.vgic.vgic_model == KVM_DEV_TYPE_ARM_VGIC_V3 >>>> || >>>> +    if ((vcpu->kvm->arch.vgic.vgic_model == >>>> KVM_DEV_TYPE_ARM_VGIC_V3 && >>>> +         vcpu == kvm_get_running_vcpu()) || >>> >>> Thanks Marc for the patch! >>> >>> I think, you mean not equal to? >>> +           vcpu != kvm_get_running_vcpu()) || >> >> Yeah, exactly. I woke up this morning realising this patch was >> *almost* right. Don't write patches like this after a long day >> at work... >> >>> With the change to not-equal, the issue is fixed and I could see the >>> NestedVM booting is pretty fast with higher number of cores as well. >> >> Good, thanks for testing it. I'll roll up an actual patch for that >> and stick it in the monster queue. > > Thanks, Please pull patch 3/3 also to nv-6.2 tree along with this > patch. I will move my setup to nv-6.2 once these patches are in. 3/3 should already be in the branch, merged with the shadow S2 fault handling. M. -- Jazz is not dead. It just smells funny...