From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258EDC10F11 for ; Sat, 13 Apr 2019 18:26:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E60692084E for ; Sat, 13 Apr 2019 18:26:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S3cwI/Cw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726998AbfDMS03 (ORCPT ); Sat, 13 Apr 2019 14:26:29 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38665 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbfDMS03 (ORCPT ); Sat, 13 Apr 2019 14:26:29 -0400 Received: by mail-wr1-f65.google.com with SMTP id k11so16182985wro.5 for ; Sat, 13 Apr 2019 11:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QuSsfUnOWpd8wrPhCbF0uJVuwNUKiw0aeZjytWZAykA=; b=S3cwI/CwHIJo+/hn1XI4mTDH4IV1Rbdf7dJjlXrP+hXb/82wfy7iHy4RprDcCDhwA8 MUHwQWcVV1Ow3/rmQDw6S1l4eIQHLkO9SNq8jXvL4ztAke0NxSXnYlfUGxctwuQuc3gV LivrOAKK+gIgiS85xf8wKfsgjLn3IO+5gCqLec50Z2lRsRh0JHuYFpu1vyKwcCuP+81+ ec1xMt5H+RBoy4l3B9LmBOcM+HwDv/aD/aqJJbrxayupgLyxJG962gTLN2mbkThaIkPZ Ei03KqwrGzqrlJ+5GwgzUjckItxUHx9N0ugusfH0LbE/L3KjhAn58OiUaqVaS5S+yLs2 mlQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QuSsfUnOWpd8wrPhCbF0uJVuwNUKiw0aeZjytWZAykA=; b=FQmvmo5+NtjgxExNQg2tOoYlySpJvLMeaisjBePOKRPuARmrwQ5ANQy/44c7N1hQx5 9wTlRkm+htl6YfL2KMjd47pMjCLwPCM9642TRgqSbFbzNmsOlpgbc1bMRN4SQi+b3VRh 1Kc8fK2uV+QFv89PGwFliKcdpaBIKn37L62LMf6Ux/Eqoctc1MdDP27ST1bTTDWwPgIU FTiuDXcB9zq9a0bkSuOpwLVrvbi/w7STxSOKHuzHZmLjwikH4RBvPUcVaAZbzfGUnJ1i YYsAJ1I2WPVSY8kpIQuk54Pbiso3Gd+9ca89tSXs1LTutudP/8UfUufMQ7pIyWHmNxsm fWow== X-Gm-Message-State: APjAAAVPEpvZi53+zMVSVpebCFRpyoE9iVHP95M/An1YwnL03sbYj7mh hKmJMQNV+Fp7eDizSiaQPf8= X-Google-Smtp-Source: APXvYqzuN4PbjF7mZph/ooPve39jpE+Fen0Nu82zFxnSwujXr+s/A2KrzqyrnLd2/nBT1gzqskmvqQ== X-Received: by 2002:adf:c7c8:: with SMTP id y8mr24387221wrg.149.1555179987862; Sat, 13 Apr 2019 11:26:27 -0700 (PDT) Received: from ?IPv6:2003:ea:8bd4:5700:55d5:e2ee:33f5:6950? (p200300EA8BD4570055D5E2EE33F56950.dip0.t-ipconnect.de. [2003:ea:8bd4:5700:55d5:e2ee:33f5:6950]) by smtp.googlemail.com with ESMTPSA id o5sm11560265wmc.16.2019.04.13.11.26.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Apr 2019 11:26:27 -0700 (PDT) Subject: Re: [PATCH netnext 04/16] net: aquantia: link interrupt handling functions To: Igor Russkikh , Andrew Lunn Cc: "David S . Miller" , "netdev@vger.kernel.org" , Nikita Danilov , Dmitry Bogdanov References: <063cc941fd2fac3d999b0020c1dce7bcc96e93c9.1555158087.git.igor.russkikh@aquantia.com> <20190413181023.GQ17901@lunn.ch> From: Heiner Kallweit Message-ID: Date: Sat, 13 Apr 2019 20:26:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 13.04.2019 20:22, Igor Russkikh wrote: > > Hi Heiner, Andrew, > > >>> If you just schedule a task from the hard irq handler, why not using >>> a threaded interrupt? >> >> Yes, i was just about to say that. > > Thanks, will check that. > >>> And a further question because I worked on the Aquantia PHY driver: >>> I assume the integrated PHY's are identical or at least very similar >>> to the external ones like AQR107. Did you ever consider to switch >>> the PHY handling part of this driver to phylib? This may help to >>> reduce complexity and code size of the driver. >> >> Hi Heiner >> >> I think this was discussed at the time the driver was first >> submitted. Or it could of been the USB version. The first version did >> actually allow access to PHY registers, and the MAC driver did poke >> some of the registers. >> >> My guess is, other operating systems don't have a suitable PHY >> driver. So they pushed it all into firmware. As a result, they now >> possibly have an inferior experience on Linux than if they used the >> new PHY driver. > > Not only because of that. Mainly because this product delivers integrated > mac/phy solution and MAC FW is made to rule all the specific phy configuration > and subtle work (things like pcie configuration, link interrupts, WOL features, > etc). > > To use separate phylib driver, FW should be totally disabled, but hardware > is not designed to run in full featured mode without FW. > > phylib driver could be used, and phy registers access is actually possible > from host, but using it will definitely cause conflicts with FW. > > Hope that explains the current design. And Andrew is right, very similar > design is chosen on USB AQC driver we submitted recently. > OK, I see. Thanks for the explanation! > Regards, > Igor > Heiner