From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 370DBC0015E for ; Wed, 9 Aug 2023 14:15:13 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.581152.909717 (Exim 4.92) (envelope-from ) id 1qTjxk-0004C3-2I; Wed, 09 Aug 2023 14:15:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 581152.909717; Wed, 09 Aug 2023 14:15:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjxj-0004Bw-Vu; Wed, 09 Aug 2023 14:14:59 +0000 Received: by outflank-mailman (input) for mailman id 581152; Wed, 09 Aug 2023 14:14:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTjxi-0004B4-QN for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 14:14:58 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ed36ac9-36bf-11ee-b281-6b7b168915f2; Wed, 09 Aug 2023 16:14:58 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id B2F574EE073F; Wed, 9 Aug 2023 16:14:57 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ed36ac9-36bf-11ee-b281-6b7b168915f2 MIME-Version: 1.0 Date: Wed, 09 Aug 2023 16:14:57 +0200 From: Nicola Vetrini To: Luca Fancellu Cc: Xen-devel , Stefano Stabellini , michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Wei Liu Subject: Re: [XEN PATCH 3/8] xen: address MISRA C:2012 Rule 8.4 In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.3 Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 09/08/2023 15:50, Luca Fancellu wrote: >> On 9 Aug 2023, at 12:02, Nicola Vetrini >> wrote: >> >> The variable 'saved_cmdline' can be defined static, >> as its only uses are within the same file. This in turn avoids >> violating Rule 8.4 because no declaration is present. >> >> Signed-off-by: Nicola Vetrini >> --- >> xen/common/kernel.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/common/kernel.c b/xen/common/kernel.c >> index fb919f3d9c..52aa287627 100644 >> --- a/xen/common/kernel.c >> +++ b/xen/common/kernel.c >> @@ -28,7 +28,7 @@ CHECK_feature_info; >> >> enum system_state system_state = SYS_STATE_early_boot; >> >> -xen_commandline_t saved_cmdline; >> +static xen_commandline_t saved_cmdline; > > I see this line was touched by > fa97833ae18e4a42c0e5ba4e781173457b5d3397, > have you checked that making it static was not affecting anything else? > > Though Jan already replied on this, the commit(s) were tested by patchew and our pipeline. This is normally our process, apart from MISRA checks. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)