From: David Ahern <dsahern@kernel.org>
To: zys.zljxml@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
eric.dumazet@gmail.com, pabeni@redhat.com,
katrinzhou <katrinzhou@tencent.com>
Subject: Re: [PATCH v3] ipv6/sit: fix ipip6_tunnel_get_prl return value
Date: Tue, 28 Jun 2022 09:05:05 -0600 [thread overview]
Message-ID: <f11640fc-7ffc-e74d-1cf6-a3889bd62f93@kernel.org> (raw)
In-Reply-To: <20220628035030.1039171-1-zys.zljxml@gmail.com>
On 6/27/22 9:50 PM, zys.zljxml@gmail.com wrote:
> From: katrinzhou <katrinzhou@tencent.com>
>
> When kcalloc fails, ipip6_tunnel_get_prl() should return -ENOMEM.
> Move the position of label "out" to return correctly.
>
> Addresses-Coverity: ("Unused value")
> Fixes: 300aaeeaab5f ("[IPV6] SIT: Add SIOCGETPRL ioctl to get/dump PRL.")
> Signed-off-by: katrinzhou <katrinzhou@tencent.com>
> ---
>
> Changes in v2:
> - Move the position of label "out"
>
> Changes in v3:
> - Modify commit message
>
> net/ipv6/sit.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2022-06-28 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 3:50 [PATCH v3] ipv6/sit: fix ipip6_tunnel_get_prl return value zys.zljxml
2022-06-28 11:57 ` Eric Dumazet
2022-06-28 15:05 ` David Ahern [this message]
2022-06-29 4:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f11640fc-7ffc-e74d-1cf6-a3889bd62f93@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=katrinzhou@tencent.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
--cc=zys.zljxml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.