All of lore.kernel.org
 help / color / mirror / Atom feed
From: ppvk@codeaurora.org
To: Matthew Wilcox <willy@infradead.org>
Cc: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org,
	stummala@codeaurora.org, sayalil@codeaurora.org
Subject: Re: [PATCH V2] fuse: Fix VM_BUG_ON_PAGE issue while accessing zero ref count page
Date: Fri, 28 Aug 2020 18:29:08 +0530	[thread overview]
Message-ID: <f147e3ceb8bbdbe3849b264e431540e2@codeaurora.org> (raw)
In-Reply-To: <20200827123424.GF14765@casper.infradead.org>

On 2020-08-27 18:04, Matthew Wilcox wrote:
> On Wed, Aug 26, 2020 at 07:57:15PM +0530, Pradeep P V K wrote:
>> Fix this by protecting fuse_copy_pages() with fc->lock.
> 
> No.  This is a spinlock and fuse_copy_pages() can allocate memory
> with GFP_KERNEL.  You need to enable more debugging on your test
> system.

Thanks Matthew for the review and comments. I will address this in my
next patch set. BTW, can you please share your thoughts, if there is a
way to extract fuse_connection Data Structure from fuse_copy_state DS ?
This would really help to use fc->lock only on intended function 
(fuse_ref_page()).

  reply	other threads:[~2020-08-28 12:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 14:27 [PATCH V2] fuse: Fix VM_BUG_ON_PAGE issue while accessing zero ref count page Pradeep P V K
2020-08-27 12:34 ` Matthew Wilcox
2020-08-28 12:59   ` ppvk [this message]
2020-09-07  9:05 ` [LTP] [fuse] 2ff3ba3472: dmesg.BUG:sleeping_function_called_from_invalid_context_at_include/linux/pagemap.h kernel test robot
2020-09-07  9:05   ` kernel test robot
2020-09-07  9:05   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f147e3ceb8bbdbe3849b264e431540e2@codeaurora.org \
    --to=ppvk@codeaurora.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=sayalil@codeaurora.org \
    --cc=stummala@codeaurora.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.