From: Andrew Lunn <andrew@lunn.ch>
To: "René Rebe" <rene@exactco.de>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
nic_swsd@realtek.com
Subject: Re: [PATCH] r8169: fix RTL8117 Wake-on-Lan in DASH mode
Date: Tue, 2 Dec 2025 16:41:49 +0100 [thread overview]
Message-ID: <f14f1078-311e-47ff-ad5f-01d2fd9ea40d@lunn.ch> (raw)
In-Reply-To: <20251201.201706.660956838646693149.rene@exactco.de>
> While at it, enable wake on magic packet by default, like most other
> Linux drivers do.
Please give examples, because i think that is false.
You should have the option to enable any WoL mode the hardware
supports, but none should be enabled by default.
> There is still another issue that should be fixed: the dirver init
> kills the OOB BMC connection until if up, too. We also should probaly
> not even conditionalize rtl8168_driver_stop on wol_enabled as the BMC
> should always be accessible. IMHO even on module unload.
Is there any way to know there is a BMC connected?
Andrew
next prev parent reply other threads:[~2025-12-02 15:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 19:17 [PATCH] r8169: fix RTL8117 Wake-on-Lan in DASH mode René Rebe
2025-12-01 20:15 ` Heiner Kallweit
2025-12-01 20:31 ` René Rebe
2025-12-01 21:12 ` Heiner Kallweit
2025-12-01 23:26 ` René Rebe
2025-12-02 7:07 ` Heiner Kallweit
2025-12-02 13:46 ` René Rebe
2025-12-02 15:52 ` Andrew Lunn
2025-12-02 15:56 ` René Rebe
2025-12-02 17:04 ` Heiner Kallweit
2025-12-02 17:23 ` René Rebe
2025-12-02 15:41 ` Andrew Lunn [this message]
2025-12-02 15:47 ` René Rebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f14f1078-311e-47ff-ad5f-01d2fd9ea40d@lunn.ch \
--to=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=rene@exactco.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.