From: Damien Le Moal <dlemoal@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>, Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, Niklas Cassel <cassel@kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata: Fix scsi_done() documentation
Date: Mon, 28 Sep 2026 08:24:18 +0200 [thread overview]
Message-ID: <f15b895a-ec2d-409c-aa52-2cd7cc899b61@kernel.org> (raw)
In-Reply-To: <291519238580d795929d44437f3c863403d14e1f.1790359497.git.bvanassche@acm.org>
On 2026/09/25 20:05, Bart Van Assche wrote:
> In 2008 the SCSI core was converted to use the block layer timeout
> infrastructure instead of its own infrastructure (see also patch
> "block: unify request timeout handling"). Since then, calling
> scsi_done() while SCSI host recovery is in progress has no effect.
> Originally the REQ_ATOM_COMPLETE flag was used to prevent double
> completions. Today the SCMD_STATE_COMPLETE flag is used to prevent
> double completions.
>
> Instead of mentioning that calling scsi_done() is not allowed while
> host recovery is in progress, mention that it has no effect.
>
> Cc: Damien Le Moal <dlemoal@kernel.org>
> Cc: Niklas Cassel <cassel@kernel.org>
> Cc: linux-ide@vger.kernel.org
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Looks good.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-09-28 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 18:05 [PATCH] ata: libata: Fix scsi_done() documentation Bart Van Assche
2026-09-28 6:24 ` Damien Le Moal [this message]
2026-09-29 8:58 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f15b895a-ec2d-409c-aa52-2cd7cc899b61@kernel.org \
--to=dlemoal@kernel.org \
--cc=bvanassche@acm.org \
--cc=cassel@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.