From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH v4] drivers: fix possible
 overflow with strcat
Date: Wed, 6 Mar 2019 18:14:24 +0000
Message-ID: <f17c8b2c-d409-c314-527a-83a8ccb5b562@intel.com>
References: <1551247371-32624-1-git-send-email-tallurix.chaitanya.babu@intel.com>
 <1551791666-26746-1-git-send-email-tallurix.chaitanya.babu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: reshma.pattan@intel.com, jananeex.m.parthasarathy@intel.com,
 rmody@marvell.com, shshaikh@marvell.com, beilei.xing@intel.com,
 qi.z.zhang@intel.com, alejandro.lucero@netronome.com,
 pablo.de.lara.guarch@intel.com, declan.doherty@intel.com, stable@dpdk.org
To: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1551791666-26746-1-git-send-email-tallurix.chaitanya.babu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

<...>

> @@ -11734,13 +11735,14 @@ static const char *get_bnx2x_flags(uint32_t flags)
>  
>  	for (i = 0; i < 5; i++)
>  		if (flags & (1 << i)) {
> -			strcat(flag_str, flag[i]);
> +			strlcat(flag_str, flag[i], sizeof(flag_str));
>  			flags ^= (1 << i);
>  		}
>  	if (flags) {
>  		static char unknown[BNX2X_INFO_STR_MAX];
>  		snprintf(unknown, 32, "Unknown flag mask %x", flags);
>  		strcat(flag_str, unknown);
> +		strlcat(flag_str, unknown, sizeof(flag_str));

Intention is to replace the 'strcat' right, seems missed to remove old code.