From: Balbir Singh <bsingharora@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@lists.ozlabs.org
Cc: Anton Blanchard <anton@au1.ibm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [RFC/PATCH 3/4] powerpc/64/kexec: Copy image with MMU off when possible
Date: Fri, 8 Jul 2016 13:08:44 +1000 [thread overview]
Message-ID: <f1887661-e287-2235-ab72-0d2abdce7dfa@gmail.com> (raw)
In-Reply-To: <1467779707.13965.103.camel@kernel.crashing.org>
On 06/07/16 14:35, Benjamin Herrenschmidt wrote:
> Currently we turn the MMU off after copying the image, and we make
> sure there is no overlap between the hash table and the target pages
> in that case.
>
> That doesn't work for Radix however. In that case, the page tables
> are scattered and we can't really enforce that the target of the
> image isn't overlapping one of them.
>
> So instead, let's turn the MMU off before copying the image in radix
> mode. Thankfully, in radix mode, even under a hypervisor, we know we
> don't have the same kind of RMA limitations that hash mode has.
>
> While at it, also turn the MMU off early when using hash in non-LPAR
> mode, that way we can get rid of the collision check completely.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> Currently only compile tested
This makes sense
Acked-by: Balbir Singh <bsingharora@gmail.com>
prev parent reply other threads:[~2016-07-08 3:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 4:35 [RFC/PATCH 3/4] powerpc/64/kexec: Copy image with MMU off when possible Benjamin Herrenschmidt
2016-07-08 3:08 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1887661-e287-2235-ab72-0d2abdce7dfa@gmail.com \
--to=bsingharora@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anton@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.