From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: ComixHe <heyuming@deepin.org>
Cc: linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v2] build: support building static library liberofsfuse
Date: Tue, 11 Jun 2024 17:23:06 +0800 [thread overview]
Message-ID: <f190347b-17c5-4b3d-b3e8-d145157adb25@linux.alibaba.com> (raw)
In-Reply-To: <3399126AB01D5AB6+2bad5767fc035a7a2234408b0fffa53b3a07aa51.1717659178.git.heyuming@deepin.org>
Hi,
On 2024/6/6 15:39, ComixHe wrote:
> add new option '--enable-static-fuse' so that we
> could import erofsfuse as a static library directly
> into other projects
>
> Signed-off-by: ComixHe <heyuming@deepin.org>
...
> +
> +if ENABLE_STATIC_FUSE
> +lib_LIBRARIES = liberofsfuse.a
> +liberofsfuse_a_SOURCES = main.c
> +liberofsfuse_a_CFLAGS = -Wall -I$(top_srcdir)/include
> +liberofsfuse_a_CFLAGS += -Dmain=erofsfuse_main ${libfuse2_CFLAGS} ${libfuse3_CFLAGS} ${libselinux_CFLAGS}
> +liberofsfuse_la_LIBADD = $(top_builddir)/lib/liberofs.la ${libfuse2_LIBS} ${libfuse3_LIBS} ${liblz4_LIBS} \
> + ${libselinux_LIBS} ${liblzma_LIBS} ${zlib_LIBS} ${libdeflate_LIBS} ${libzstd_LIBS}
I guess this line should be the following:
-liberofsfuse_la_LIBADD = $(top_builddir)/lib/liberofs.la ${libfuse2_LIBS} ${libfuse3_LIBS} ${liblz4_LIBS} \
- ${libselinux_LIBS} ${liblzma_LIBS} ${zlib_LIBS} ${libdeflate_LIBS} ${libzstd_LIBS} ${libqpl_LIBS}
+liberofsfuse_a_LIBADD = $(top_builddir)/lib/liberofs.la
Since we may not have all dependent libraries, so it's up to users to use liberofsfuse.a and
link static (or dynamic) dependencies themselves.
I will update this patch manually.
Thanks,
Gao Xiang
> +endif
prev parent reply other threads:[~2024-06-11 9:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 7:31 [PATCH] build: support building static library ComixHe
2024-05-23 8:05 ` Gao Xiang
2024-06-06 2:13 ` Chen Linxuan
2024-06-06 2:22 ` Gao Xiang
2024-06-06 2:25 ` Chen Linxuan
2024-06-06 2:45 ` Gao Xiang
2024-06-06 3:06 ` Chen Linxuan
2024-06-06 3:13 ` Gao Xiang
2024-06-06 3:17 ` Chen Linxuan
2024-06-06 3:22 ` Gao Xiang
2024-06-06 4:18 ` [PATCH] build: support building static library liberofsfuse ComixHe
2024-06-06 6:31 ` Gao Xiang
2024-06-06 7:39 ` [PATCH v2] " ComixHe
2024-06-06 7:53 ` Gao Xiang
2024-06-11 9:23 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f190347b-17c5-4b3d-b3e8-d145157adb25@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=heyuming@deepin.org \
--cc=linux-erofs@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.